[Exile CR] Totem Issues

[benkoren]

Hello.

I'm having some issues with the bot's handling of the spell totem:

Range
This one in particular is with Incinerate. Often, the bot detects the totem as being within range of the enemy, when really it is just barely in range. With the way the Incinerate projectiles wave back and forth, about one in every 5 or so fluffs of fire actually hit the target. So while I understand that the target can technically be within Incinerate's range at that point, we should not regard it as such. Bonus: If the spell totem is linked to LMP or GMP, it'd be great for the ensuredrange to be much smaller so that multiple projectiles hit your target. This would greatly increase the damage output.

ShouldCastTotem() and CalculateTotemPlacement()
It is fairly frequent that the bot does not cast a totem when there are no totems near the current target. This only happens when the maximum number of totems have been deployed (yet are far away from the current target). Once one of the previous totems expire, the bot immediately casts one in the proper position near the current target, but not until that expiration. I believe the issue is line of sight. I've attached my log file - the last 30 seconds of the log you see a big gap. That's when the bot was just sitting there not casting a totem. My suspicion is that the problem is that CalculateTotemPlacement() does not test line of sight.

Both ShouldCastTotem() and CalculateTotemPlacement() need to be aware of line of sight in order for a spell totem build to work. I see that there is an IsInLineOfSight() usable on BestTarget, but there doesn't appear to be a means to apply that to totem line of sight or else I'd whip up a proof of concept.


Thanks for your help.

- Ben

 

[benkoren]

Bump; I'm just making sure this is on your radar.

 

[pushedx]

Sorry, forgot to reply.

The current totem issues and limitations are known, but in terms of priority bot wise, making better CRs is on our todo list, but not near the very top just because of some things we'd like to change to make being able to do more advanced logic in the CRs easier.

 

[benkoren]

Understood. Thanks for the response.

 

[leroy1978]

I'm using this instead of the default function and it is working for me, try it:

        internal Composite CreateCastTotemComposite(string spellName)
        {
            return new PrioritySelector(

                        new Decorator(ret => !LokiPoe.RangedLineOfSight.CanSee(LokiPoe.ObjectManager.Me.Position, TargetList.First().Position),
                            CommonBehaviors.MoveTo(ret => TargetList.First().Position, ret => " ************ CreateMoveToLos (ranged) ************ \n")
                            ),

                        new Decorator(ret => TargetList.First().Distance > 110,
                            CommonBehaviors.MoveTo(ret => TargetList.First().Position, ret => " ************ CreateMoveToRange ************ \n")),

                        SpellManager.CreateSpellCastComposite(spellName, ctx => ShouldCastTotem(spellName, ctx as Actor), ctx => CalculateTotemPlacement(BestTarget.Position))
            );

        }