darkbluefirefly
Community Developer
- Joined
- Nov 8, 2013
- Messages
- 1,927
- Reaction score
- 18
I personally call CloseBlockingWindows every time I use movement to avoid such situations, because you never know what can happen. It's not hard to add, won't break anything and make's life easier in case of not your's plugin fault.
I didn't feel the need of posting full log because I already checked it before posting on the forum. I have enough knowledge to lurk trough the logs and code (made a visual studio project of QuestPlugin so it's easier to check). Wanted to save your time so I posted a ready solution.
IMHO CloseBlockingWindows should be called internally in every movement function. PHM is not blocking keyboard clicks so that would be logical. But pushedx would need to see that post to do that (or block keyboard too).
EDIT: The Black Core issue was propably caused by PoESmoother I've used for testing, already mentioned it somewhere.
I trust you it can do everything without interaction. I even merged optional and main tasks today (after posting the line the shitstorm is going about!) to do them at once. AutoEquip is next on my todo list
Default Tasks Already call close blocking windows.
Calling Close All Blocking windows will have an adverse effect on other's plugins. How?
For instance.
Task A is someone else's
Task B is yours
Task C is someone else's
Task A is some stash task, Task B is your Stash Buddy, Stash C requires stash to be open
You will never be able to account for what task requires what.
Task A finishes, task B closes window, then opens stash again.
Task C is a divination trader plugin , it requires stash to be open and closed when it moves.
So since it already closed stash because task B called it when it started, CPU cycles wasted in opening stash again. Task C Needs stash open when whit drawing, and closed when moving, and it does just that when it's needed to close all windows, Never at the start of a task.
Do logic when needed, not in case it's needed.
You make your work with others that have been there before you, not make others change their work to accommodate you. The underlying issue is not adding a line of code, it's the pretense of telling someone to change their logic to match yours, which cannot happen when deving. Each person has their own style, make yours work with, not make someone work their for you.
What you said you called close blocking windows when you move. If you look at my task, close blocking windows, will always get called by default task, always. There's no reason for me to add another a 5th wheel to a 4 wheel car. I make it work with the assumption everyone will run default task, it has worked thus far and with other plugins when needed. You need to add close blocking windows to the end of your stash task, because you called the window to be opened in the first place.
PHM is used to send keys to the client to emulate actions, EB does not use packets or anything, because that would get us banned. PHM is meant so no one should touch the bot when it's running. If you need to adjust something, stop the bot do the adjustment and run again. If you can't do the with your plugin, you need to rethink your logic, because it's achievable.
The reason I separated the quests to 2 sections is because I felt it would give more control to the user, some wanted to rush through content, some wanted just to get the side quests done, some wanted both. I opted out the latter because i would cause issues with users posting about things not working, it's doing this quest before that quest. No, not going to have any of that.
Gl on auto equip, we've got one for a year or so, the underlying logic has always been the same consensus, too many variables to account for, and equipment won't change much in end game, leveling, yes, it will change a lot. But a character spends 10% of his time leveling, and the rest end game. Why bother, rather spend time automating thing we can, so we can have time to make more things to automate more things, Auto-mate-ception.
) about the best way to handle and the data that has to be exposed for plugins. Few tweaks for the core tasks and I guess I'll start working on GUI after that 
