CLU (Codified Likeness Utility)

Claaslexion · Jun 29, 2012

I was wondering how the holy paladun is doing in pve, raids and dungeons. I have a old holy pally that needs some playing

wulf · Jun 29, 2012

guys there is a serious flaw in the Party AoE healing distance detection I am working on it..this is why all the AoE heals (PoH, Wild Growth, Holy Radiance, etc) are not casting when they should

[CLU TARGETING] 2.7.0: Target AREA MEMBER: Myself REASON: party healing: Avg: 10-80, 30yrds, count: 3 or 2
[CLU TARGETING] 2.7.0: player5 Max 145348, Current 72708, Defecit 72640, HealthPercent: 50, Distance from Myself: 1118.177
[CLU TARGETING] 2.7.0: player4 Max 148123, Current 117375, Defecit 30748, HealthPercent: 79, Distance from Myself: 341.1611
[CLU TARGETING] 2.7.0: Myself Max 170792, Current 130851, Defecit 39941, HealthPercent: 76, Distance from Myself: 0
[CLU TARGETING] 2.7.0: player3 Max 165479, Current 132781, Defecit 32698, HealthPercent: 80, Distance from Myself: 13.95291
[CLU TARGETING] 2.7.0: player2 Max 252387, Current 147385, Defecit 105002, HealthPercent: 58, Distance from Myself: 216.6065
[CLU SUCCEED] 2.7.0: Itson Distance: 33, Prayer of Healing, MaxHealth: 145348, CurrentHealth: 72708, Deficit: 72640, HealthPercent: 50

If that makes no sense to you, All party members were within a 40yrd radius of me (player3 was right beside me)..the large numbers you see are suppose to be the distance (30f) but the detection I am using is giving huge numbers back, apologies for not picking it up sooner..

should be fixed soon.

Stormchasing · Jun 29, 2012

can u tell me the routine / method / composite to have a look at?

okay i think i found the bug

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers

should be

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers * maxDistanceBetweenPlayers

most time your code is not kickin cause a distance of 8y is 64y (sqr -> square and not sqareRoot^^)
Found this in TargetBase.cs
private Composite FindAreaHealSubroutine(int minAverageHealth, int maxAverageHealth, float maxDistanceBetweenPlayers, int minUnits, string label)
haven't checked all the other Targetting Routines, but i think u did this mistake on other places too

---edit---

yep double checked it with holy radiance

u call

Code:

// Holy Radiance
                    Healer.FindAreaHeal(a => true, 10, 80, 30f, (Me.IsInRaid ? 5 : 3),
                        Spells.CastSpell("Holy Radiance", a => HolyPower < 3 && Me.ManaPercent > 15, "Holy Radiance")),

with this call all units has to be in a Distance of 5.477y to meet the requirements of Holy Radiance (sqrt 30 = 5.477)

wulf · Jun 29, 2012

Stormchasing said:
can u tell me the routine / method / composite to have a look at?

var hits = players.Where(p => p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers);

will upload the latest to SVN for you.

wulf · Jun 29, 2012

Stormchasing said:
can u tell me the routine / method / composite to have a look at?

okay i think i found the bug

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers

should be

Code:

p.Location.Distance2DSqr(player.Location) < maxDistanceBetweenPlayers * maxDistanceBetweenPlayers

most time your code is not kickin cause a distance of 8y is 64y (sqr -> square and not sqareRoot^^)
Found this in TargetBase.cs
private Composite FindAreaHealSubroutine(int minAverageHealth, int maxAverageHealth, float maxDistanceBetweenPlayers, int minUnits, string label)
haven't checked all the other Targetting Routines, but i think u did this mistake on other places too

That was fast! that was a bit of a Doh! moment.

Stormchasing · Jun 29, 2012

wulf said:
That was fast! that was a bit of a Doh! moment.

yeah checked the files and took the one that i thought it would be the correct one^^ while waiting for answer

wulf · Jun 29, 2012

Stormchasing said:
yeah checked the files and took the one that i thought it would be the correct one^^ while waiting for answer

latest svn is still reporting odd numbers....

[CLU] 2.7.0: [Casting] Prayer of healing
[CLU TARGETING] 2.7.0: Target AREA MEMBER: xxxxxx REASON: party healing: Avg: 10-80, 30yrds, count: 3 or 2
[CLU TARGETING] 2.7.0: xxxxxx Max 168113, Current 103583, Defecit 64530, HealthPercent: 61, Distance from xxxxxx : 0
[CLU TARGETING] 2.7.0: vvvvvvv Max 165334, Current 121569, Defecit 43765, HealthPercent: 73, Distance from xxxxxx : 55.54219
[CLU TARGETING] 2.7.0: Myself Max 165028, Current 161076, Defecit 3952, HealthPercent: 97, Distance from xxxxxx : 60.1671
[CLU TARGETING] 2.7.0: vvvvvdfdsf Max 220856, Current 178061, Defecit 42795, HealthPercent: 80, Distance from xxxxxx : 578.404

everyone was in a circle no bigger than 20yrds.

Soeski · Jun 29, 2012

wulf said:
guys there is a serious flaw in the Party AoE healing distance detection I am working on it..this is why all the AoE heals (PoH, Wild Growth, Holy Radiance, etc) are not casting when they should
If that makes no sense to you, All party members were within a 40yrd radius of me (player3 was right beside me)..the large numbers you see are suppose to be the distance (30f) but the detection I am using is giving huge numbers back, apologies for not picking it up sooner..
should be fixed soon.

Noticed indeed that my Priest was not using PoH at all, I manually popped it. Didn't mention it to you before. Not a big deal though, it's a 8 min CD so I don't want to pop it anyway at the last minute of a fight or so. Haven't noticed my Druid (Wild Growth) not doing it right though; it's doing a lot of Wild Growths...

I especially like the enthusiasm and passion you put in this; it's really appreciated. Stormchasing seems to be a good help as well!

wulf · Jun 29, 2012

Soeski said:
Noticed indeed that my Priest was not using PoH at all, I manually popped it. Didn't mention it to you before. Not a big deal though, it's a 8 min CD so I don't want to pop it anyway at the last minute of a fight or so. Haven't noticed my Druid (Wild Growth) not doing it right though; it's doing a lot of Wild Growths...

I especially like the enthusiasm and passion you put in this; it's really appreciated. Stormchasing seems to be a good help as well!

Thanks Soeski, I don't know what I would do without Stormchasing sometimes haha.

Stormchasing · Jun 29, 2012

this is only a bug in your output

Code:

match.Location.Distance2DSqr(best.Location)

this again returns the SQUARE of the Distance, not the SQUAREROOT

wulf · Jun 29, 2012

Stormchasing said:
this is only a bug in your output

Code:

match.Location.Distance2DSqr(best.Location)

this again returns the SQUARE of the Distance, not the SQUAREROOT

way too many beers tonight lol...time to put the coding goggles down

ok thats better

[CLU TARGETING] 2.7.0: Target AREA MEMBER: Myself REASON: party healing: Avg: 10-80, 30yrds, count: 3 or 2
[CLU TARGETING] 2.7.0: Myself Max 165511, Current 103328, Defecit 62183, HealthPercent: 62, Distance from Myself: 0
[CLU TARGETING] 2.7.0: cccccc Max 149740, Current 114830, Defecit 34910, HealthPercent: 76, Distance from Myself: 13.8102561543524
[CLU TARGETING] 2.7.0: vvvvvv Max 142521, Current 142521, Defecit 0, HealthPercent: 100, Distance from Myself: 20.1233978581506

Math.Sqrt(match.Location.Distance2DSqr(best.Location)

...hic

Soeski · Jun 29, 2012

wulf said:
way too many beers tonight lol...time to put the coding goggles down

Just out of Curiosity, where are you located anyway? I notice when I'm going to bed, you're going to work (real life job).
Also right now, when you're talking about beers tonight, I just finished lunch (1:30pm)... hehe.

Stormchasing · Jun 29, 2012

wulf said:
way too many beers tonight lol...time to put the coding goggles down

ok thats better

Math.Sqrt(match.Location.Distance2DSqr(best.Location) ...hic

did u ever tried

Code:

match.Location.Distance2D(best.Location)

i see atm no reason to use the Distance2DSqr

but ... that's your code^^ do it like u prefer it ... and ...CHEERS

wulf · Jun 29, 2012

Soeski said:
Just out of Curiosity, where are you located anyway? I notice when I'm going to bed, you're going to work (real life job).
Also right now, when you're talking about beers tonight, I just finished lunch (1:30pm)... hehe.

I come from a land down under

Soeski · Jun 29, 2012

wulf said:
I come from a land down under

Ah, then I get it! Land of the kangaroo or something hehe. That's at least 9 timezones away from mine then hehe... it's about midnight at your place then. Explains why my midnight is your morning to go to work

wulf · Jun 29, 2012

Change Log
-------------

* 29/6/2012 [2.7.0]

Patchs added for Warlock Pets and Ele and enh shaman weapon issues - thanks stormchasing.
Fix for DPS-ing the Burning Tendons and Deathwing head.
Fix for LoS healing
Fix for AoE healing detection.
Resto Druid changes/tweaks (still not happy with it.)

Stay tuned...party healing is now working!!!!

[CLU] 2.7.0: [Casting] Prayer of healing
[CLU TARGETING] 2.7.0: Target PARTY 3 MEMBER: vvvvvvvvv REASON: party healing: Avg: 10-80, 30yrds, count: 3 or 2
[CLU TARGETING] 2.7.0: bbbbbb Max 266696, Current 179222, Defecit 87474, HealthPercent: 67, Distance from vvvvvvvvv : 0
[CLU TARGETING] 2.7.0: ccccccc Max 166739, Current 128187, Defecit 38552, HealthPercent: 76, Distance from vvvvvvvvv : 11.2041430576048
[CLU TARGETING] 2.7.0: ssssssss Max 165432, Current 129090, Defecit 36342, HealthPercent: 78, Distance from vvvvvvvvv : 14.8891780186252
[CLU TARGETING] 2.7.0: fdfdfd Max 186653, Current 152490, Defecit 34163, HealthPercent: 81, Distance from vvvvvvvvv : 4.28102211450124
[CLU TARGETING] 2.7.0: eeeeeee Max 153312, Current 130787, Defecit 22525, HealthPercent: 85, Distance from vvvvvvvvv : 1.33879911665658

Disc Priest has Party Healing enabled, should revert to area healing when out of Raid.

Soeski · Jun 29, 2012

Wulf, nice to mention to you:
Last night, LFR. 6 healers, 3 priests, 1 shaman and 1 druid.
Breakdown:

Shaman: 13K HPS
Druid: 12K HPS
Priest 1: 10K HPS
Myself: 8K HPS
Priest 3: 7K HPS

But guess what; although I was the second lowest healer in the charts, I also checked the overhealing charts. Breakdown:

Shaman: >14K OHPS (56%)
Druid: ~13K OHPS (>50%)
Priest 1: ~9K OHPS (>40%)
Myself: ~5K OHPS (29%) !!
Priest 3: ~6K OHPS (>40%)

Soooo... we can safely assume the Priest is very efficient; I did not go OOM this time as well!! (LFR Fall of DW).
I can only say; great work and according results. Of course this was before the fix you've just made with PoH...

/edit: Also did the same run with my Resto Druid with Noobrage. Overhealing 50%... and no mana issues at all. Having said that, Innervate is not THAT great at all. During a fight it usually gets me 10% more mana than before Innervate, but certainly not from empty to full. No where near that...

myslex · Jun 29, 2012

myslex said:
Ah yes, this feature is enabled. Movement is working as intended. However, I think I should add that im using this CC farming low level mobs, and still it does not automatically target/attack these unless targeted _BY_ them, or _manually_ targeted by me..

Any news on this Low level mob targeting business Wulf?

AGain, REALLY appreciate your work buddy

wulf · Jun 29, 2012

Will check it out first thing tommorow mate. I haven't forgotten you

Sippinhaterade · Jun 29, 2012

At what point does CLU change to AOE healing for a Holy Priest?

CLU (Codified Likeness Utility)

New Member

Community Developer

Community Developer

Community Developer

Community Developer

Community Developer

Community Developer

Member

Community Developer

Community Developer

Community Developer

Member

Community Developer

Community Developer

Member

Community Developer

Member

Member

Community Developer

Member