I LOVE THIS CC TY MORDD!!
ok... now the rest of the post.
for those of you asking about COI spam, assuming you ALWAYS want to use COI in pvp, you could just open the .cs file and change all the icytouch() calls over to chainsofice() calls i would think... then set it to pull with icy touch, and it will cast chains of ice every time it would have cast icy touch.
as to the pet glitch, it may be common knowledge to you mordd, but it seems that the ghoul and bloodworms only have the aggro glitch if you are NOT specc'd unholy (perma-ghoul) if the ghoul isn't permanent, isn't it considered a guardian just like the worms? also did have this issue when i was unholy with my gargoyle pulling aggro, and me stopping attacking. but when i was unholy i don't remember having any issues with the ghoul (perma-pet).
also noticed that with the blood rotation if you have it pull with icy touch it double casts it, but looking through your code i can't see why, when it pulls it is supposed to flag icytouch as cast, the easy hack i tried was to add a call to set the flag to true at the beginning of the bloodrotation call. that worked, but then it wouldn't reapply it, because i was constantly setting theflag to true, trying a new fix now of adding a check for frost fever to the first icy touch call in the rotation, will update with results
anyway 2.1 is a massive upgrade, and i am super grateful for you effort.
hmm gonna be trouble only changing this on pvp mode, but ill give it a shot, the icy touch to chains thingy.
swapped out all IcyTouch() to ChainsOfIce().
no change.
swapped out a few other icytouch related things to chainsofice, he still casts icy touch sometimes, but now he casts chains alot more often, tho i dont know what effect these changes will have on the rest of the cc, as there are stuff like look like this now.
if ((!_icyTouchCast) && (SpellManagerEx.CanCast("Icy Touch")))
{
if (SrChecks())
return true;
ChainsOfIce();
_icyTouchCast = true;
return true;
if ((!_icyTouchCast) && (SpellManagerEx.CanCast("Icy Touch")))
{
if (MbChecks())
return true;
ChainsOfIce();
_icyTouchCast = true;
return true;
}
and alot more of those types.
so it sorta works, but probobly breaks alot of logic in the cc :/
would love a simple, (always use chains of ice to apply frostfever in pvp) feature & or just "always use chains of ice instead of icy touch in pvp"
ok this seems to be enough, for pvp only.
Deathknight.cs
line 4678, change icytouch to Chains();
line 4641 same thing
line 4590 same thing
line 4551 same thing
line 4396 change to Chains(); //Do Opener
line 4380 Chains(); //Do Opener
4010 Chains();
that seems like it was all for pvp, since chains of ice has the same cost as icy touch, minimal editing seemed to be needed. tho it does still cast icy touch sometimes, not sure why.
btw, i am amateur so i might have messed up ;P.
edit; just realised i was repeating what halestrom88 just wrote, in any case its called chains() not chainsofice()