Bug(s) in Trinity ItemRules Interpreter.cs

[zyzzyva]

itemDic.Add("[POISONDMG%]", item.Stats.PosionSkillDamagePercentBonus);
(...)

itemDic.Add("[ELEMDMG%]", new float[] { item.Stats.FireSkillDamagePercentBonus,
item.Stats.LightningSkillDamagePercentBonus,
item.Stats.ColdSkillDamagePercentBonus,
item.Stats.PosionSkillDamagePercentBonus,
item.Stats.ArcaneSkillDamagePercentBonus,
item.Stats.HolySkillDamagePercentBonus }.Max());

itemDic.Add("[SKILLDMG%]", new float[] { item.Stats.FireSkillDamagePercentBonus,
item.Stats.LightningSkillDamagePercentBonus,
item.Stats.ColdSkillDamagePercentBonus,
item.Stats.PosionSkillDamagePercentBonus,
item.Stats.ArcaneSkillDamagePercentBonus,
item.Stats.HolySkillDamagePercentBonus,
item.Stats.SkillDamagePercentBonus}.Max());

Shouldn't those be poison and not posion?

Also, I'm trying to figure out how to check for all the elements % damage together (poison,cold,physical,holy,lightning,fire,arcane) and the above "[ELEMDMG%]" seems to be the closest, however you'll notice it doesn't include physical. I was just going to manually add it but then I noticed that physical seems to be treated differently than the rest:

itemDic.Add("[FIREDMG%]", item.Stats.FireSkillDamagePercentBonus);
itemDic.Add("[LIGHTNINGDMG%]", item.Stats.LightningSkillDamagePercentBonus);
itemDic.Add("[COLDDMG%]", item.Stats.ColdSkillDamagePercentBonus);
itemDic.Add("[POISONDMG%]", item.Stats.PosionSkillDamagePercentBonus);
itemDic.Add("[ARCANEDMG%]", item.Stats.ArcaneSkillDamagePercentBonus);
itemDic.Add("[HOLYDMG%]", item.Stats.HolySkillDamagePercentBonus);

itemDic.Add("[PHYSDMG%]", item.Stats.SkillDamagePercentBonus);

Shouldn't that read PhysicalSkillDamagePercentBonus? I'm new to this whole DB/Trinity experience but it seems to me that PHYSDMG% is pointing to +dmg% (as in, you do +25% damage) (?) Or is it the case that physical element is somehow different? It doesn't even follow the same naming scheme here which is also making me hesitant.


Edit: To clarify, if I were right now to implement this rule:
[QUALITY] == "Legendary" && [TYPE] == "Bracer" # [MAXSTATVIT] > 900 && ([CRIT%] == 6 || [ELEMDMG%] > 15)

It looks like it would only keep legendary bracers with 900 stat+vit and either 6 crit or (fire+cold+posion[sic]+lightning+holy+arcane)>15 and would IGNORE this bracer:
20% to physical skills
500 int
500 vitality
+1234 life on hit

 

[zyzzyva]

Bump