Amulet itemrule help

[putricide]

Can someone help me with rule for amulets? need to know if i´ve done right
take this for example:

[QUALITY] == "Legendary" && [NAME] == "Countess Julia's Cameo" # ([CRIT%] < 8 && [CRITDMG%] < 80) || ([CRIT%] < 8 && [SOCKETS] == 0) || ([CRITDMG%] < 80 && [SOCKETS] == 0) -> [TRASH]

planning on testing this on all amulets but i need to know if i´ve messed up or if im actually correct when i wrote it that it will keep anything that after enchanting winds up with crit, crit dmg and socket

 

[thw]

my rule for amulet is simple.

@GOODAMULET:=([CRIT%].dual +[CRITDMG%].dual +[SOCKETS].dual) >= 2
[QUALITY]=="Legendary" && [TYPE]=="Amulet" # [@GOODAMULET] -> [KEEP]

means any amulet with at least two of crit, crit dmg and socket is valuable and kept.
Your rule can't check the minimum requirement to add a gem-stone to the amulet.

 

[putricide]

where do i put that code? not used to do this
and i want it to keep for example amu with 80+critdmg and socket or crit 8%+ and socket or dual crit. doesnt have to be all three, just 2 of those criteria to be able to enchant the 3rd option

Edit: Im using hitmans legendary.dis edit of jobs itemrules

 

[thw]

The following is what you want.
Put it to your 'legendary.dis" as the first line.
@GOODAMULET := ([CRIT%] > 8 && [CRITDMG%] > 80) || ([SOCKETS] > 0 && [CRIT%] > 8) || ([SOCKETS] > 0 && [CRITDMG%] > 80)

 

[putricide]

The following is what you want.
Put it to your 'legendary.dis" as the first line.
@GOODAMULET := ([CRIT%] > 8 && [CRITDMG%] > 80) || ([SOCKETS] > 0 && [CRIT%] > 8) || ([SOCKETS] > 0 && [CRITDMG%] > 80)

The rules i´m using is using trash if < so i changed it to:
@GOODAMULET := ([CRIT%] < 8 && [CRITDMG%] < 80) || ([SOCKETS] < 0 && [CRIT%] < 8) || ([SOCKETS] < 0 && [CRITDMG%] < 80)

So it looks like this now:

[QUALITY] == "Legendary" && [NAME] == "Countess Julia's Cameo" # [@GOODAMULET] -> [TRASH]

Correct?

 

[thw]

Sorry!!
Correct rule is as following.

BADAMULET:= ([CRIT%] < 8 || [CRITDMG%] < 80) && ([SOCKETS] == 0 || [CRIT%] < 8) && ([SOCKETS] == 0 || [CRITDMG%] < 80
[QUALITY] == "Legendary" && [NAME] == "Countess Julia's Cameo" # [@BADAMULET] -> [TRASH]

 

[putricide]

Sorry!!
Correct rule is as following.

BADAMULET:= ([CRIT%] < 8 || [CRITDMG%] < 80) && ([SOCKETS] == 0 || [CRIT%] < 8) && ([SOCKETS] == 0 || [CRITDMG%] < 80
[QUALITY] == "Legendary" && [NAME] == "Countess Julia's Cameo" # [@BADAMULET] -> [TRASH]

Thanks again! =) testing now =)

 

[putricide]

One problem though, it keeps The Ess of Johan with no crit or critdmg or socket

nvm, think it was another rule that screwed it up for ancients keeping items with stats above 500