ActiveAura Question, help please.

[Truman422]

I've tried a million ways, but honorbuddy keeps trying to cast it INSTANTLY, unlike the rest of the abilities, then it never tries it again. And by trying to cast it instantly, I mean its missing it because I'm still on GCD from the previous spell.. Tips on avoiding this?

                        else if (SpellManager.CanCast("Slam"))
                        {
                            if (Me.ActiveAuras.ContainsKey("Bloodsurge"))
                            {
                                SpellManager.Cast("Slam");
                                slog("Slam");
                            }
                        }

Anyone know why it won't go back and check my auras again? I've tried it the above way, the below way, and about every way you can check an aura. I even used Singular's code for HaveAuraStacks just to see, and still nothing. WTF.

                        else if (SpellManager.CanCast("Slam") && Me.ActiveAuras.ContainsKey("Bloodsurge"))
                        {
                            SpellManager.Cast("Slam");
                            slog("Slam");
                        }

 

[Thacai]

i had this issue aswell, sometimes it seems like a simple lookup is not enough, since it sometimes contains "talent auras"

public static WoWAura Bloodsurge
{
get
{
return Me.GetAuraById(46916);
}
}

and then if i have the aura:

WarriorAuras.Bloodsurge != null then do something

 

[CodenameG]

Active Aura's should only contain Procs and buffs you can actuily see, the Normal Me.Auras contains everything including hidden talent aura's
for getting stacks you wanna do something like
Me.ActiveAuras["Whatever"].StackCount

just make sure to do a normal ContainsKey lookup before checking StackCount and you should be ok

as far as the spell spamming, it looks like the Else If logic might have a hole in it somewhere, however i cant tell without looking at the whole section. but generally "Else If's" are bad practice.

 

[Truman422]

I've tried standard if statements as well, nothing seems to work, I'll try you guy's suggestions. Thank you.

 

[Thacai]

Active Aura's should only contain Procs and buffs you can actuily see, the Normal Me.Auras contains everything including hidden talent aura's
for getting stacks you wanna do something like
Me.ActiveAuras["Whatever"].StackCount

just make sure to do a normal ContainsKey lookup before checking StackCount and you should be ok

as far as the spell spamming, it looks like the Else If logic might have a hole in it somewhere, however i cant tell without looking at the whole section. but generally "Else If's" are bad practice.

thing is bloodsurge doesnt have any stacks, so his code is "perfectly" fine

 

[Thacai]

Could try Me.Buffs.ContainsKey["Bloodsurge"]

 

[Nesox]

Or you could do

WoWAura aura;
if(StyxWoW.Me.ActiveAuras.TryGetValue("Arcane Intellect", out aura))
{
    uint stackCount = aura.StackCount;
    // more awesum shit here
}

Then you don't have to check if the key exists

 

[Truman422]

Hmm, at least I'll have something to do when I get home tonight. lol. Thanks for the help all.

 

[Truman422]

Nesox, I love you dude. lol. It worked. Thanks.

 

[iggi66]

Or you could do

WoWAura aura;
if(StyxWoW.Me.ActiveAuras.TryGetValue("Arcane Intellect", out aura))
{
    uint stackCount = aura.StackCount;
    // more awesum shit here
}

Then you don't have to check if the key exists

This will only work on english clients, won't it?

 

[Nesox]

This will only work on english clients, won't it?

No, Honorbuddy has a file with all English names for spells.
It does a lookup in that file to get the english name of spells/auras etc.

 

[iggi66]

Alright, I didn't know about that library.