To Magi and blubby: can you guys agree with this? Should I release v0.44 with bombastic's mod? Or is there something else that needs fixing with monk routines?I've started to play a monk, and made a "inna edtion" version based on 0.43.
What that version does? If you have the popular combo breath of heaven / blind flash / sweeping wind AND a full inna set, some things will change:
* Sweeping Wind never goes off. It will auto recast before it wears off;
* Sweeping Wind is casted only after breath of heaven and blinding flash are both activated (to maximize damage);
* Mantra of Conviction is more spammed to maximize damage as well.
* You must have a 5 pieces inna set for this to work. And check the option in the GUI, obviously.
* Without sweeping wind wearing off your monk always have full damage, because of an bug/exploit blizzard never fixed
In rares occasions is still possible to lose the buff: looting chest / corpses when the buff is wearing off, if connection lags, or for being incapacited (frozen, nightmare, stunned, etc)
Now we need a plugin to equip a dual weapon / cast sw / equip dual wield
ps: all my changes regarding inna set are marked with //intell -- inna
Unified GilesPlugin's Unnoficial Updates File
- Thread starter jubisman
- Start date
- Status
bombastic
New Member
- Joined
- Jun 18, 2012
- Messages
- 430
- Reaction score
- 3
Exactly this. There's an inna's check in every skill I changed.
Oh gosh, what did I get myself into
I agree ksmaze that it's unfortunate Giles himself isn't here to chime in, but, "the show must go on" ...
I must say I've never done an open source project before and have only worked in a closed source environment with trusted peers, so I'm not really sure how to setup and manage this context. Need to look up some best practices I suppose.
I would be happy just being a contributor, rather than doing the administrative or ownership end.
I have no preference to a revision control system, but agree we need one.
Please note that I am not a software engineer by profession, but rather an enterprise sysadmin with a big toolbox to get things done.
Questions that come to mind:
Who should have access to make changes?
How do we manage the circle of trust?
Do changes have to be approved before they're available to everyone?
How should testing work - e.g. if I make a change that fixes my problem but breaks something hti had spent 3 hours on?
No problem dude, I keep organizational management =) Never work on open source project, but I have habit of project management on Closed Community and enterprise.
the less the better, others should fork the source and ask to merge if you try to use Git. there are many online free Git server except Github(and I don't like its free version)
wow, are you really talking about a circle?!... if you want to keep the code correct and safe, give only the guaranteed contributor the permission to commit the changes. like here only J and Darkfriend can change the source code.
no problem, that's what version control for. just reverse back to the right version. and I believe this is what Nesox is always doing
but... testing is painful anyway.... lol
I don't have habit to work with Git Source Control but I can learn ^^ If everybody prefer, and you can advise me a good free private Git repository (or what else which permit branch management, grant access for 2 or 3 dude, and pull request).
have u guys same problem with giles?
sometimes when they should go and identify items, they just use teleport and stay in town doing nothing.
testing it on db 282 and 285, only have atom and giles plugin, so i think it must be gilestrinity
[12:05:40.613 N] [GilesTrinity] No more space to pickup a 2-slot item, now running town-run routine.
[12:05:40.613 N] Using town portal
sometimes when they should go and identify items, they just use teleport and stay in town doing nothing.
testing it on db 282 and 285, only have atom and giles plugin, so i think it must be gilestrinity
[12:05:40.613 N] [GilesTrinity] No more space to pickup a 2-slot item, now running town-run routine.
[12:05:40.613 N] Using town portal
Following thoughts I already mentioned to Magi:
the real dps lost without inna's is the sweeping wind, this one should be casted also if blinding flash is not ready...
I thought a lot about that today and came to following logical expression:
1. check if Inna or not
-> yes: see 2.
-> no: see 3.
2. use implementation with first blinding flash followed by sweeping wind & spamming sweeping wind constantly
3. To avoid loosing a lot of dps of not active sweeping wind: check iElite or iAnythingInRange
-> iElite: see 4.
-> iAnything: see 5.
4. wait till 85 spirit is ready and cast first blinding flash then sweeping wind
5. just cast sweeping wind and do not bother with blinding flash!
the real dps lost without inna's is the sweeping wind, this one should be casted also if blinding flash is not ready...
I thought a lot about that today and came to following logical expression:
1. check if Inna or not
-> yes: see 2.
-> no: see 3.
2. use implementation with first blinding flash followed by sweeping wind & spamming sweeping wind constantly
3. To avoid loosing a lot of dps of not active sweeping wind: check iElite or iAnythingInRange
-> iElite: see 4.
-> iAnything: see 5.
4. wait till 85 spirit is ready and cast first blinding flash then sweeping wind
5. just cast sweeping wind and do not bother with blinding flash!
I think, you could launch Healing skill (with DPS rune) just before SW in case of you have Inna set
In my morning search, I find Assembla...
I have create repo "UnifiedTrinity" and start to setup
For people need access send me a PM with your Assembla Username or address email (for send invite).
jiznadj
New Member
- Joined
- Nov 3, 2012
- Messages
- 412
- Reaction score
- 1
Is there any way to get the bot to salvage the junk legendary items for brimstones but still sell the junk rares? Was doing it manually but it is time consuming. Right now if you set it to salvage, it will salvage everything, producing a lot of worthless junk mats and losing much gold.
Last edited:
I'm having this very same problem as well, but I didn't think it was Unified until you said it was happening with #282 as well. Are you sure about this? Because my problems started after #285 and I don't see what Unified update could have possibly caused something like this
If anyone would be so kind as to send me a link via pm for #282 I will test this.
There is no way to this this yet. Sounds like a good idea, though
fuimusbruce
New Member
- Joined
- Aug 2, 2012
- Messages
- 450
- Reaction score
- 2
This is an issue I am having just in general sometimes when porting to town, just standing there. I think its an issue with db, although it could be unified I guess. Its random, if I am watching and walk my bot back through the portal, he will port back to town again and carrying on like nothing happened. Its almost like db stopped communicating with the plugin so the plugin couldnt give directions anymore for that period of time until you force it to run the command again.
fuimusbruce
New Member
- Joined
- Aug 2, 2012
- Messages
- 450
- Reaction score
- 2
Well it should already be doing this...with the if not in town then port command. I think the problem is db stops plugins from pulsing so the command doesnt continue to go through. All it takes is a split second of dropped communication between db and the plugin for pulsing to stop. Once you force it to run the command again it starts back up again. For me I have never had the issue of it not porting to town, but once it gets to town just standing there. Walk back through the portal and it runs the if not in town then port command again and everything picks back up.
Only thing I can think of is maybe putting in an extra pulse command. Not sure how you would do this though as if it is already not pulsing, how does it run another pulse command. I know radonic tried to bypass this by seperating his pulses from db pulses. Cant remember how successful it was though.
Magi
New Member
- Joined
- Oct 12, 2012
- Messages
- 1,242
- Reaction score
- 7
You can use threads to make calls independent of pulse. I had attempted to do this when trying to pinpoint an exact death of a warden. Didn't work out as I had hoped but I can honestly say, I don't think I've encountered this town run bug. The only town run issues I have is the kill radius disappearing pretty much and taking forever to warp back with monsters around still.
Turkey Day today, I'm out!
Turkey Day today, I'm out!
bombastic
New Member
- Joined
- Jun 18, 2012
- Messages
- 430
- Reaction score
- 3
Done. If you have inna, it will cast SW only if you have BoH and BF buffs. It will always recast SW to not lose the increased damage (unchanged).
If inna option ins't checked, it will cast SW if there's no elites and bosses nearby, or if they are not the current target. Otherwise, it will first cast BF, then SW (changed). It will not try to perma recast on buff lose, obviously.
Something I've forgot to mention: If Inna is checked, Mantra of conviction will be spammed even if there's only a single enemy nearby (you don't have to save much spirit in that case). If no inna, only if there's at least 3 nearby (or elites).
Test / Feedback
Last edited:
Yeah, you guys have fun
I think we should leave the portal problem to Nesox... He seems to be sorting out this unsuccessfully recently.
AzureusPT
New Member
- Joined
- Sep 25, 2012
- Messages
- 439
- Reaction score
- 1
I had an issue with my monk not attacking his clone in the second phase of Diablo fight, please add the SNO so it can attack it:
Weird... My barb also didn't attack her clone...
I'm using v0.43, but I remember Giles could do Diablo without problem. I think a change has deleted all the SNO of the shadows for phase two.
EDIT: Yup! Original Giles 1.6.3.4 deals with shadows without problems...
Code:
Type: Unit Name: Diablo_shadowClone_Monk_Male-15198 ActorSNO: 141938, Distance: 10.44514
Code:
Type: Unit Name: Diablo_shadowClone_Barbarian_Female-1331 ActorSNO: 143994, Distance: 5.010004EDIT: Yup! Original Giles 1.6.3.4 deals with shadows without problems...
Last edited:
rrrix
New Member
- Joined
- Jul 11, 2010
- Messages
- 3,449
- Reaction score
- 61
Posted a new version of my fork.
http://www.thebuddyforum.com/demonb...4-full-questing-all-acts-complete-tested.html
Lets use this one to start our team project?
Bombastic, I can merge your stuff in once people test, or if you tell me to 'just do it' I haven't been using my Monk lately, and I don't have 4pc inna's on it either
Changelog:
Trinity x7
Merged with Unified v43
Additional Fixes and checks for Monk Wave of Light
Added a little Boss 15 sec Blacklist logic (hopefully fixing stucks in A4)
Cleaned up VendorRun BehaviorTrees (old code to be removed later)
Refactored AbilitySelector into Class-specific files
Fixed rare bug when flip-flopping targets after attempting to open a chest
Will no longer blacklist an avoidance if the ActorSNO is in both blacklist and avoidance lists (like if a blacklist entry was added through a profile)
Added WhimsyShire Pinata to loot container whitelist (211861)
Fixed Attempting to do Vendor/Town Run with monsters nearby
Added fix for Diablo Shadow Clone's - now recognized as bosses
http://www.thebuddyforum.com/demonb...4-full-questing-all-acts-complete-tested.html
Lets use this one to start our team project?
Bombastic, I can merge your stuff in once people test, or if you tell me to 'just do it'
I haven't been using my Monk lately, and I don't have 4pc inna's on it either Changelog:
Trinity x7
Merged with Unified v43
Additional Fixes and checks for Monk Wave of Light
Added a little Boss 15 sec Blacklist logic (hopefully fixing stucks in A4)
Cleaned up VendorRun BehaviorTrees (old code to be removed later)
Refactored AbilitySelector into Class-specific files
Fixed rare bug when flip-flopping targets after attempting to open a chest
Will no longer blacklist an avoidance if the ActorSNO is in both blacklist and avoidance lists (like if a blacklist entry was added through a profile)
Added WhimsyShire Pinata to loot container whitelist (211861)
Fixed Attempting to do Vendor/Town Run with monsters nearby
Added fix for Diablo Shadow Clone's - now recognized as bosses
- Status