What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

[Plugin] Giles Trinity

Status
Not open for further replies.
is there a way to config what skills to use and when?
sometimes the zombie bears are used when the target can not be hit, and poison darts are barely used when in fact it is safer to do so instead of bears

soul harvests are used most the time with 1 or 2 targets hit
 
nah you didnt mess up, for some reason pasting in here adds a space in the word "Barbarian", remove the spaces and it should work

Found and removed the space, however I still get:
[19:48:36.985 N] [GilesTrinity] System.NullReferenceException: Object reference not set to an instance of an object.
at GilesTrinity.GilesTrinity.get_DisplayWindow()

Never mind. That only seems to happen when I use the Settings window. The code works.
You sir, are a freaking machine!!!!!!!

You and Bom basically made this plugin perfect (from my perspective).
If you guys ever get lonely, my gf's pretty hot, let me know, I'll send her over.

Thanks a lot guys!
 
Last edited:
Found and removed the space, however I still get:


Never mind. That only seems to happen when I use the Settings window. The code works.
You sir, are a freaking machine!!!!!!!

You and Bom basically made this plugin perfect (from my perspective).
If you guys ever get lonely, my gf's pretty hot, let me know, I'll send her over.

Thanks a lot guys!
not sure what would cause the error with settings, but im glad sprint its working for you :D
 
I made some more fixes, now to WW usage... finally I could made a ww+sprint build and reduce the deaths to only 0~4 times on act 3.

The previous molten core fix is also included (along with another fix: giles not saving preferences)


tested first time ww barb... and it works like charm.

just one question the bot only casts WOTB when he fights an elite. if it runs out between an elite he never cast this again? but this would increased killspeed etc .... how i can change this
 
Thank you for the attempt, but it seems you still haven't fixed the biggest issue that WW seems to have with Trinity. The fact that it spams Sprint instead of using it once, draining all of the Fury avail.
If you could fix that, it would be bullet proof.
Thanks :)

To better illustrate the issue since most people seem not to have noticed this... Here's a vid.
Sprint Spam - YouTube

Edit: I've definitely gotta give you props though. This does work quite well. Thank you.
You're joking, right?

Not a single time in that video does he cast Sprint with it already up. He's running out of fury because he's spamming WW.

Are what you guys wanting is for the bot to only cast Sprint to get to packs and then not cast it again?
 
Last edited:
You're joking, right?

Not a single time in that video does he cast Sprint with it already up. He's running out of fury because he's spamming WW.

Are what you guys wanting is for the bot to only cast Sprint to get to packs and then not cast it again?
youre joking right?
Sprint Spam - YouTube
80~ fury to 0 in less than a second, from whirlwind?
 
You're joking, right?

Not a single time in that video does he cast Sprint with it already up. He's running out of fury because he's spamming WW.

Are what you guys wanting is for the bot to only cast Sprint to get to packs and then not cast it again?

Yes, it does. Right at the start, have a close look. It spams Sprint 3-4 times every time it casts it in the group, thus draining my Rage. It was fixed with Poly's code change.
 
So Giles has really moved on to other stuff/games?
Stop that crap...

Giles said:
Jesus Christ... Seriously guys?

Originally Posted by jinny1
Yea i got borderlands 2 mixed up with guild wars 2.. Anyhow trinity is finished..
I think I've played Borderlands 2 for a total of 3 hours, maybe 4 hours - which were all last night. The rest of my time I have been spending with about a thousand timers in Trinity to try and shave CPU usage off, improve attack speed, and generally improve intelligence of other aspects of Trinity for the last 3-4 days, including line-of-sight checking for attacks without any extra CPU-hits etc... I've also been preparing Trinity for the next DemonBuddy release, as I'll be able to fully handle barricades, disable built in DB unstucker, etc. - and I want to make sure that the moment the new Demonbuddy is released, I can have a new Trinity version released so that everybody can use Trinity immediately (no I do not have any release date/expectations for anybody, sorry, but I would guess and it is nothing but a guess within the next 7 days, or if there is a new Diablo 3 patch, within a few days of the patch!).

The current state of the RELEASED Trinity is in a good enough condition that I don't feel the need to be trying to maintain 2 simultaneous codesets (one for "release", one for "the next version") - and as an individual community developer doing this in my free time (and for the past 20 days, 'free time' has really meant 90% of my waking hours) - I don't have any motivation to be maintaining two copies side-by-side.

Not that I know why I feel the need to reveal my private life - if anything I've shown an extraordinary amount of devotion of my time to releasing plugins for other people over the past three months here - so why a discussion about how I might be spending my free time playing a new game is taking place I have no idea. Shall we discuss how many hours I spend visiting the shops instead of releasing Trinity updates, or sleeping, or having a wee? Perhaps essential body functions and requirements can be discounted, so we should measure how many hours I spend entertaining myself by means other than coding - which is very, very few

(do note: I am enjoy coding - I do consider my time spend coding Trinity and my past plugins as enjoyable and a great way to spend the vast majority of my free time, especially when I can then release it to the wild and see other people appreciating and enjoying my work - so I'm not complaining about how much time of my time I spend working on plugins - I'm complaining about other people analyzing that time and making ridiculous and unfounded statements about me).
 
can you post your build and settings

i am gonna try your modified version :D

barbbuild.jpg


Bash (Impunity): gives extra 24% damage to ww. Can be replaced with Instigation, if fury is not enough.
Threatening Shout (Grim Harvest): Not the best neither the usual choice, but I like the odds to drop a nice item... It could be easly changed to ignore pain, revenge, overpower or even wotb.

Actually 70+ on paragon :)

Thank you for the attempt, but it seems you still haven't fixed the biggest issue that WW seems to have with Trinity. The fact that it spams Sprint instead of using it once, draining all of the Fury avail.
If you could fix that, it would be bullet proof.
Thanks :)

To better illustrate the issue since most people seem not to have noticed this... Here's a vid.
Sprint Spam - YouTube

Edit: I've definitely gotta give you props though. This does work quite well. Thank you.

Never happened to me. Sprint only casts on buff cooldown.

I saw your video, sprint is casting fine. The guilt comes from ww eating fury. It's insane, and it's normal.
 
Last edited:
Never happened to me. Sprint only casts on buff cooldown.

I saw your video, sprint is casting fine. The guilt comes from ww eating fury. It's insane, and it's normal.

I beg to differ. If you look at the actual sprint skill when it casts it, you will see it refreshing from 95% to 100% multiple times. I tried to slow down the end-bit of the video to show it better, but it got cut off too quick. I am 100% sure that the bug exists, and I no longer have that disappearing fury issue with the fix that Poly gave me.
 
Polyester changes didn't really change anything.

He deleted from the code the part that forces sprint to recast if you have WW in the skill bar, but ONLY after sprint cooldown (GilesUseTimer(SNOPower.Barbarian_Sprint)) AND if you don't have the sprint buff already (!GilesHasBuff(SNOPower.Barbarian_Sprint)).

I rewatched your video, and what that "95% to 100% refreshing" seems to me is server lag (visual error).

What I advice you to change is {SNOPower.Barbarian_Sprint, 2800}, to {SNOPower.Barbarian_Sprint, 3000}.

Sprint cooldown is 3000ms (3s), but giles made trinity recasts it a bit early: 200ms (I doubt this would change much, but...)

You and Bom basically made this plugin perfect (from my perspective).
If you guys ever get lonely, my gf's pretty hot, let me know, I'll send her over.

Thanks a lot guys!

LOL

np mate :cool:
 
Last edited:
Polyester changes didn't really change anything.

He deleted from the code the part that forces sprint to recast if you have WW in the skill bar, but ONLY after sprint cooldown (GilesUseTimer(SNOPower.Barbarian_Sprint)) AND if you don't have the sprint buff already (!GilesHasBuff(SNOPower.Barbarian_Sprint)).

I rewatched your video, and what that "95% to 100% refreshing" seems to me is server lag (visual error).

What I advice you to change is {SNOPower.Barbarian_Sprint, 2800}, to {SNOPower.Barbarian_Sprint, 3000}.

Sprint cooldown is 3000ms (3s), but giles made trinity recasts it a bit early: 200ms (I doubt this would change much, but...)

Maybe it has something to do with the fact that I live in Australia and my MS is constantly 260+, however, I know for sure that was a major bug, because it has been happening since the last D3 update, and after I changed the code as Poly told me to, it no longer happens. So something wasn't going right. Also after watching my video, a few other people have said that they have the same issue.

In a selfless effort to try and prove this further. I made this.
Slowed down Trinity Sprint Bug - YouTube
Please observe that this 'stutter' does not happen on any other skill. It's a Sprint related thing only, and the drop in the Fury suggests that it is not a visual issue, as the rapid drop in Fury coincides with the Sprint buff finishing, and the re-casting of a new one.
 
I'll watch the video, but for now, I have added to the code a flag to test when sprint is being casted. Look to the times:

Code:
[09:25:57.124 N] Casting sprint...
[09:26:03.984 N] Casting sprint...
[09:26:11.604 N] Casting sprint...
[09:26:22.074 N] Casting sprint...
[09:26:48.324 N] Casting sprint...
[09:26:51.884 N] Casting sprint...
[09:26:55.794 N] Casting sprint...
[09:27:09.414 N] Casting sprint...
[09:27:17.244 N] Casting sprint...
[09:27:21.714 N] Casting sprint...
[09:27:35.774 N] Casting sprint...
[09:27:39.344 N] Casting sprint...
[09:28:06.284 N] Casting sprint...
[09:28:09.734 N] Casting sprint...
[09:28:31.104 N] Casting sprint...
[09:28:34.394 N] Casting sprint...
[09:28:54.804 N] Casting sprint...
[09:28:58.104 N] Casting sprint...
[09:29:27.124 N] Casting sprint...
[09:29:32.734 N] Casting sprint...
[09:29:38.844 N] Casting sprint...
[09:29:50.054 N] Casting sprint...
[09:30:01.764 N] Casting sprint...
[09:30:33.874 N] Casting sprint...
[09:30:37.314 N] Casting sprint...
[09:30:41.444 N] Casting sprint...
[09:30:44.754 N] Casting sprint...

Not a single time sprint was recasted less than 3 seconds from each other... If this is really a bug, for sure isn't happening to me.
 
...[/code]

Not a single time sprint was recasted less than 3 seconds from each other... If this is really a bug, for sure isn't happening to me.

Then it must have something to do with my normal Latency. As I said, I no longer have the issue after applying Poly's code portion.
If anyone else is having the issue, I guess this could help them out as well :).
 
I'll watch the video, but for now, I have added to the code a flag to test when sprint is being casted. Look to the times:

Code:
[09:25:57.124 N] Casting sprint...
[09:26:03.984 N] Casting sprint...
[09:26:11.604 N] Casting sprint...
[09:26:22.074 N] Casting sprint...
[09:26:48.324 N] Casting sprint...
[09:26:51.884 N] Casting sprint...
[09:26:55.794 N] Casting sprint...
[09:27:09.414 N] Casting sprint...
[09:27:17.244 N] Casting sprint...
[09:27:21.714 N] Casting sprint...
[09:27:35.774 N] Casting sprint...
[09:27:39.344 N] Casting sprint...
[09:28:06.284 N] Casting sprint...
[09:28:09.734 N] Casting sprint...
[09:28:31.104 N] Casting sprint...
[09:28:34.394 N] Casting sprint...
[09:28:54.804 N] Casting sprint...
[09:28:58.104 N] Casting sprint...
[09:29:27.124 N] Casting sprint...
[09:29:32.734 N] Casting sprint...
[09:29:38.844 N] Casting sprint...
[09:29:50.054 N] Casting sprint...
[09:30:01.764 N] Casting sprint...
[09:30:33.874 N] Casting sprint...
[09:30:37.314 N] Casting sprint...
[09:30:41.444 N] Casting sprint...
[09:30:44.754 N] Casting sprint...

Not a single time sprint was recasted less than 3 seconds from each other... If this is really a bug, for sure isn't happening to me.
like Hidden. i'm from australia so the "bug" might be something to do with latency, regardless, the changes i made fixed the issue for us.
 
Thanks for the Modified file, can you explain what you changed ? keen to learn :D but i can't seem to figure it out. something to do with molten core 2 being added ?
 
@GilesSmith sprint is currently sucking out the fury

I removed it from my skill build until you make an update
 
Status
Not open for further replies.
Back
Top