[Plugin] Giles Stash & Loot Rule Replacer

[GilesSmith]

Got quite a few posts to reply to, find it less spammy sticking them all in one post as usual;

Came home and looking in buddystats it seems to have sold a lvl63 blue with 1136dps (I am using the lvl61 blue rules because I am still trying to get gear and gold so I don't mind the little cash the vendoring gives me), would of liked to of kept that and seen what it was, I'll try figure how to keep all lvl63 stuff regardless, that will suit my current leveling needs.
All the stuff it did stash I have up for auction now, I'll see how it all goes.
G

Yeah 1136 blue 2-handed would be trashed - it really isn't worth anything at all. If I search for 2 handers with max buyout 10k gold there's still weapons with almost 1200 dps being listed!

Thanks for the plugin, using it for a bit now. Some problems with it:
1) Stashes the potions (I do set to pick em up, but I would like the plugin to leave it in the backpack for the bot to use). Hopefully it is fixed by setting a protected bag slot in general options as I did 20 minutes ago.
2) I've upped the default "leave items" score a bit as it stashed pretty ridiculous items (I doubt they would even sell, but I haven't checked so far so I might be wrong, will report later)
3) Would love some better log as to which items it is selling, better then just "Sold [item name]" in the window. Does this plugin answer for this or is it base DB sell algorithm? Anyway any input on how to set this point up would be appreciated.

1) There is an option in the config to keep potions instead of stash them, you could have just used that - but the plugin does support protected bag slots so protecting the bag slots will also work just as well!
2) Are you using the "test" version 1.6.1 posted here in post #130 of this thread? If not, would you be willing to start using that one instead, and see if the scores seem better to you using the default limits of 70k/15kl/13.5k? I'd love some people to try v1.6.1 and then give me specific feedback on stat combos/stat amounts/item slots you find that still have too much or too little score. The new version really does prevent some of the "trash" that was still filtering through as I've given a bit more intelligence to the scoring.
3) I'd rather spend effort just perfecting the scoring mechanism really, you salvage and sell so many items that having logs for them could get huge, but I'll think about it!

does it work for Russian client ?

Yes! But you will need to edit the .xml loot rule files and edit any of the English text to the appropriate Russian text. But the actual plugin does not need changing and will work on any language version

great plugin gile, love your work. one quick question, is it possible to not have the character ID the items and stash them unid'ed? thanks!

I'm thinking about adding support for this built in, but right now there is a plugin which is compatible with mine so it's not high priority - you can just use this plugin here. My plugin will auto-stash anything that gets left unidentified Note: I do not know if his plugin works with latest DB, check his thread first.

Giles any way you could add a few extra features, don't know if it would be possible but would be cool if you could:
Tick boxes similar to health potions for :

• Looting Flawless Square Gems (each colour tick box would be awsome, atm greens are the only ones worth out),
• Looting patterns,
• Looting Tomes,
• Idenitfy level 63's (Similar to thorines plugin, is down atm, but if you could incorporate it would be awsome, stashes 63's + all ring/amulents 60+ without identifying),

I'll definitely expand the plugin a bit more in the coming week, I also have plans to replace DB's behavior tree for the actual picking up of items and decision on doing a town-run or not (which is my current focus and may be done in a day or two), to remove bugs and allow me to remove the need for a loot file altogether!

 

[cdmichaelb]

Randomly it started vendoring good stuff... I'm using your plugin and your profile, it worked fine before randomly not working. I can't fix it. :\

[04:51:55.280 N] Sold item [Tome of Secrets] x18
[04:51:55.281 N] Sold item [Mythic Health Potion] x44
[04:51:55.281 N] Sold item [Flawless Square Topaz] x1
[04:52:00.303 N] Path with 4 hops received (partial: True)
[04:52:19.444 N] Sold item [Exquisite Essence] x17
[04:52:19.445 N] Sold item [Iridescent Tear] x9

 

[GilesSmith]

Randomly it started vendoring good stuff... I'm using your plugin and your profile, it worked fine before randomly not working. I can't fix it. :\

[04:51:55.280 N] Sold item [Tome of Secrets] x18
[04:51:55.281 N] Sold item [Mythic Health Potion] x44
[04:51:55.281 N] Sold item [Flawless Square Topaz] x1
[04:52:00.303 N] Path with 4 hops received (partial: True)
[04:52:19.444 N] Sold item [Exquisite Essence] x17
[04:52:19.445 N] Sold item [Iridescent Tear] x9

Hi. See the large red note at the top of this thread

NOTICE: DemonBuddy .185 has accidentally removed support for the "FollowerSpecial" itemType in rules files (a new feature added in .180). Because of this, all rules files for this plugin are currently broke in .185. I advise everybody to stick to .180 for now as there may be other item-related issues from things being accidentally deleted, but if you cannot revert, then remove all references to the FollowerSpecial in your rules files.

If you can't revert back to .180, then see my post #337 earlier in the thread here for a loot rule file you can use with DB .185 that will work

 

[Alexqq]

Hey giles! There is a way to add Salvage to the 61+ blues profile,to salvage 61+ blues and keep 61+ rares?thx and awesome work !

 

[imakii]

I got a Q, about this plug.. I think i saved it on the right place but .. when i click on the config .. i only see blank.. not sure if its like that with this new DB w/ delays ..

What I want to do is just customize what I want that toon to pick up .. I'm just currently leveling it up .. Barb on Norm lvl 36.. any reasons why i cant do that .. or am i missing another plug for it to populate?

 

[GilesSmith]

Hey giles! There is a way to add Salvage to the 61+ blues profile,to salvage 61+ blues and keep 61+ rares?thx and awesome work !

It already salvages all salvagable items that aren't worth stashing, no matter which of the loot rule files you use. If you use 61+ blues rules, it'll stash the good items it finds, and salvage the rest for inferno mats

I got a Q, about this plug.. I think i saved it on the right place but .. when i click on the config .. i only see blank.. not sure if its like that with this new DB w/ delays ..
What I want to do is just customize what I want that toon to pick up .. I'm just currently leveling it up .. Barb on Norm lvl 36.. any reasons why i cant do that .. or am i missing another plug for it to populate?

You probably haven't installed it correctly. You should have two files in \DemonBuddy\Plugins\GilesStashReplacer\ for example;
C:\DemonBuddy\Plugins\GilesStashReplacer\GilesStashConfig.xaml
C:\DemonBuddy\Plugins\GilesStashReplacer\GilesStashReplacer.cs

If you are sure you installed correctly, then I would suggest a fresh, new, clean install of Demonbuddy in a new folder (don't just copy the new version into the old folder - actually make a new, empty folder with a totally fresh clean install of DemonBuddy and fresh versions of plugins).

 

[haigent]

Hi, Giles

I'v encounted a bug may related to your great Stash & Loot Rule Replacer plugin.

* I maybe manually changed stash order, eg: put a ring in the following two slot(the bellow one, up one leaved empty)
* When stashing, DB try to put two slot weapon in that two slot, which end of swap gears.
* Then it loops.

 

[GilesSmith]

Hi, Giles
I'v encounted a bug may related to your great Stash & Loot Rule Replacer plugin.
* I maybe manually changed stash order, eg: put a ring in the following two slot(the bellow one, up one leaved empty)
* When stashing, DB try to put two slot weapon in that two slot, which end of swap gears.
* Then it loops.

Manually stashing things is fine (as long as you aren't stashing it while the bot is stashing things at the same time - this would be bad - always stop the bot before doing anything).

But there are some bugs in DB that cause it to fail to read an item at all, and so DB thinks it isn't there - and if DB says an item isn't there, then even my plugin can't help. I've seen this happen myself with a ring and a two-slot item. I closed DemonBuddy, re-opened it, started it and it stashed everything fine the next time. Good news is Apoc is working on fixing all these item-reading faults in DemonBuddy so hopefully not much longer for a new DB that doesn't have these random issues!

 

[greenxeyezz]

soverign helm ilvl 62 is NOT being picked up....anything you need from me to test or log for that?

Was using 185 so I switched to your beta 1.6.1 and new loot rules, will test and report back

ran backpack test, it counted....12 items...when i have 30 items in the backback....

Is the Backpack test not correct in counting items for keep or trash?

 

[GilesSmith]

soverign helm ilvl 62 is NOT being picked up....anything you need from me to test or log for that?
Was using 185 so I switched to your beta 1.6.1 and new loot rules, will test and report back

Always remember - pickups are DB. Stashes are plugin. If it's not being picked up, it's DB. If it's not being stashed, it's plugin.
(and yes if you are using DB 185, you need to use those separate rules files I uploaded to a post 2 or 3 pages back)

 

[haigent]

Manually stashing things is fine (as long as you aren't stashing it while the bot is stashing things at the same time - this would be bad - always stop the bot before doing anything).

But there are some bugs in DB that cause it to fail to read an item at all, and so DB thinks it isn't there - and if DB says an item isn't there, then even my plugin can't help. I've seen this happen myself with a ring and a two-slot item. I closed DemonBuddy, re-opened it, started it and it stashed everything fine the next time. Good news is Apoc is working on fixing all these item-reading faults in DemonBuddy so hopefully not much longer for a new DB that doesn't have these random issues!

Thanks for the reply, I did recall when I restarted the bot the problem goes away. Hopefully these Stashing issue will all goaway in a week, it really bugs me.

 

[Alexqq]

It already salvages all salvagable items that aren't worth stashing, no matter which of the loot rule files you use. If you use 61+ blues rules, it'll stash the good items it finds, and salvage the rest for inferno mats


You probably haven't installed it correctly. You should have two files in \DemonBuddy\Plugins\GilesStashReplacer\ for example;
C:\DemonBuddy\Plugins\GilesStashReplacer\GilesStashConfig.xaml
C:\DemonBuddy\Plugins\GilesStashReplacer\GilesStashReplacer.cs

If you are sure you installed correctly, then I would suggest a fresh, new, clean install of Demonbuddy in a new folder (don't just copy the new version into the old folder - actually make a new, empty folder with a totally fresh clean install of DemonBuddy and fresh versions of plugins).

Its possible to just salvage all 61+ blues? Its stashing a lot of shit because i don't know how the gearscore works...

 

[GilesSmith]

Its possible to just salvage all 61+ blues? Its stashing a lot of shit because i don't know how the gearscore works...

Basically you should use the gearscores that come with the plugin. The option to change them is for fussy people/people that want to experiment. I tried to design everything to be fully automatic with the default scores.

You can delete the .cfg config file ("StashReplacer.cfg") from the plugin folder, start DemonBuddy up and the plugin will be back to default values again (which are 70,000 weapon, 15,000 armor, 13500 jewelry). You should find these values work best, as they are the values I use and the values I try to base all the code off regarding what to stash, and what to trash

 

[simpleonin]

v1.6.1 Score Tweak Test Available Below:
I'm not uploading this to the main-post, as I want some feedback on this one from willing testers. I've changed scores for quite a few stats, I've added various checks in that check one stat against another (eg having good prime stat & vitality, makes other stats worth more, and vice-versa). I've added in some small points bonus for "armor bonus" (think this was the only slightly-valuable stat I didn't have before - plugin now checks 24 different stats on items). And I've added a minimum-of-max-possible to every single stat for a stat to give points (for example gold and magic find at 64% - which means if they have less than 64% of the max-possible, they get only a very small score for those stats, not counting the various bonuses for being paired with prime stat/vit or eachother... this means minimum of 12 magic find/16 gold find on a typical piece of armor etc.).

My hope is to rule out some of the stuff that would sometimes get stashed when actually it only sold for max 15k, and to start pushing the average prices to at least 100k "guaranteed sale" on everything if you use the default scores (70k weapons, 15k armor, 13.5k jewelry).

So far I'm very pleased with the output - it feels strict but in a good way (I kept checking items and thinking "It wants to junk that? No way!", then checking the auction house and seeing that actually items with better stats/extra stats were going for only 20k )... but I'd like some feedback from people willing to test scores out, and then go on the AH and search for these items to see if it's getting the majority right. If you find a particular set of stats that is DEFINITELY worth good gold (and is ACTUALLY SELLING - and check the actual stats of other listed items to make sure they are actually similar and not loads better!) but being listed as "Trash/junk", then please post here - screenshot of the item hosted on imgur.com would be great, if not just list the item type, all the important stats, and what sort of gold price you think it'd sell for at minimum (and what score my plugin was giving it).

I'll test this and give you feedback as I am getting crappy stuff with the previous versions.

1 Resist with GF and MF are being scored too high to be stashed.

 

[GilesSmith]

I'll test this and give you feedback as I am getting crappy stuff with the previous versions.
1 Resist with GF and MF are being scored too high to be stashed.

Yes try the 1.6.1 - and I'd really appreciate anyone willing to spend a bit of time with that plugin version, the default scores, and do a bunch of backpack "tests" from the config window test button. Have a good look at what it wants to trash/keep, and then give me feedback on what stat-combinations you think it is valuing too highly, or not valuing highly enough. I can then tweak the combo-code to make the whole scoring system much more dynamic & fluid, and less prone to stick trash in just because it has 2 good stats that actually aren't worth anything without a specific 3rd stat!

(be sure to double-check the AH first - I got surprised myself at how many things I thought the plugin should be keeping that it wanted to trash, which when I checked, really weren't worth more than 10-20k each at best!).

 

[PainfulDeath]

Just tested your 1.6.1 backpack test on the 7 items which your 1.6 rules deemed okay to stash, but which I found to be really bad (mostly combintaions of random stats + MF/GF or both) (and selling on AH from 5k to 50k), 1.6.1 check deemed them all trash, so kudos on that I guess. =)

Also:
Pants
2 sock (I already put +68 int there, dunno if that confuses your mechanism)
47 str
71 int
207 vita
Both 1.6 and 1.6.1 want to keep them. On AH it's a fast sell at probably around 50k (that's what I will post them for now), I see better ones for less than 100, so depending on what you think is a mediocre price - that combinaton might be valued a bit too high.

 

[GilesSmith]

Just tested your 1.6.1 backpack test on the 7 items which your 1.6 rules deemed okay to stash, but which I found to be really bad (mostly combintaions of random stats + MF/GF or both) (and selling on AH from 5k to 50k), 1.6.1 check deemed them all trash, so kudos on that I guess. =)
Also:
Pants
2 sock (I already put +68 int there, dunno if that confuses your mechanism)
47 str
71 int
207 vita
Both 1.6 and 1.6.1 want to keep them. On AH it's a fast sell at probably around 50k (that's what I will post them for now), I see better ones for less than 100, so depending on what you think is a mediocre price - that combinaton might be valued a bit too high.

Yeah the socket will "confuse" it - it doesn't check to see if something's been socketed and then try to deduct the socketed bonuses - as far as I remember it WOULD be possible to do that in DB (remove whatever stats the gems are giving it), but other than for testing button purposes that really shouldn't ever be needed (as it's really aimed at items you pickup from monster kills!) which are always empty. If you took the gems out of the sockets you'd get the "true" score.

Glad to hear the things you thought are trash, the new 1.6.1 also agrees with! I'd like a few more people testing it (or just a couple of us using it for a while longer) before I update the first post with it, as it is a lot "stricter" with items so I wanted to make sure it all seemed good. But so far I'm happy with the changes - I've not noticed it miss anything genuinely good, and I don't get so many "mediocre" items in the stash anymore (though I am getting fedup of all the legendaries... at least they always sell for 90k+ minimum cos of inferno craft mats ).

 

[simpleonin]

--- nvm ----

 

[Hajkfas]

It's keeping all scoundrel tokens and some junk wiz helms.

 

[simpleonin]

It is stashing this in version 1.6.1

Armor - MightyBelt 'Unstoppable Brace'. Score = 15159
Gold Find %=17. +All Resist=47

Armor - Boots 'Trail Idol'. Score = 18675
Magic Find %=20. Gold Find %=17. +Highest Single Resist=40
(with additional armor)