Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

sobora · Mar 7, 2012

How do I edit the Disc CC to remove shadow word pain from rotation?

nomnomnom · Mar 7, 2012

daorigin said:
doesnt switch back 2 Battle Stance to Overpower only does the first overpower and thats it. hs bug definitely fixed though.

I concur with this. Stance-Dancing doesnt work very well yet. I tried with and without Force proper stance.

0ld · Mar 7, 2012

Apoc said:
Try this version of the arms rotation, it should be less... silly with Heroic Strike usage. The issue was a bug with the Incite check (causing it to always return true)

Thank you, looks promising.

I've yet to try it live, but I have a few comments looking in the code (esp. regarding aoe - yes, I've seen it has TODO marks, just my suggestions).

First of all, popping sweeping strikes on >1 mobs is not the best idea and can even lead to raid wipe.
An example can be Yorsahj hc where you can easily kill a floating-by low-hp mana void thus leaving your casters with no mana on the next blue phase.
First thing I'll do before trying it, is changing it to >2 as we probably don't care about the mana void if other adds are around.

Also, using WW in aoe situation will simply drain your rage with no dps increase in most cases. It'd be much better to use it along with cleave (which we also wouldn't like to use in low rage situations) for rage dump.

And I'd prioritize MS over WW (we have 2 out of 3 gcds for aoe stuff anyway).

Another thing I will surely comment out is recklessness if current target is boss. Considering the fact its cd is 5min, you'll hardly use it twice a fight (except for the last 2 DS bosses), so timing it with BL/Heroism looks to be good idea (at least better than just using it on cd).

That's what I notice at the first glance, I may be missing something or plainly wrong /discuss

Nuok · Mar 7, 2012

Been working on some more advanced logic for taunting; I added this to Raid and call it when taunting.

Needs a bit of fleshing out but should improve taunting in LFR at least.

Note I've altered logging so I can change the colour so this wont work by copy & paste!

Code:

        /// <summary>        ///  Basic LFR tank taunting tactics, returns true if a taunt it needed
        /// </summary>
        public static bool NeedToRaidTaunt()
        {
            //Dragon Soul
            //Note this is for LFR mianly
            if (StyxWoW.Me.ZoneId == 5892)
            {
                // Morchok, Swaping on crush armour 2 stacks
                if (StyxWoW.Me.CurrentTarget.Entry == 55265)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Crush Armor", 2)
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && !StyxWoW.Me.HasAura("Crush Armor"))
                    {
                        Logger.Write(Color.Red, "Morchok: Taunting For Crush Armour");
                        return true;
                    }
                }


                //Ultraxion
                if (StyxWoW.Me.CurrentTarget.Entry == 55265)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Fading Light")
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid)
                    {
                        Logger.Write(Color.Red, "Ultraxion: Taunting other tank has fading light");
                        return true;
                    }
                }


                //Warmaster Blackhorn
                if (StyxWoW.Me.CurrentTarget.Entry == 56427)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Devastate", 2)
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && !StyxWoW.Me.HasAura("Devastate"))
                    {
                        Logger.Write(Color.Red, "Warmaster Blackhorn: Taunting other tank has devistate");
                        return true;
                    }
                }


                //Madness of Deathwing
                //Taunt on impale
                if (StyxWoW.Me.CurrentTarget.Entry == 56471)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Impale")
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && StyxWoW.Me.HasAura("Impale"))
                    {
                        Logger.Write(Color.Red, "Madness of Deathwing: Taunting for Impale");
                        return true;
                    } 
                }


                if (!Group.Tanks.Contains(StyxWoW.Me.CurrentTarget.CurrentTarget.ToPlayer()))
                {
                    Logger.Write("Taunting, " + StyxWoW.Me.CurrentTarget.Name + " is not targeting a Tank");
                    return true;
                }
                else return false;
            }
            return true;
        }

Apoc · Mar 7, 2012

0ld said:
Thank you, looks promising.

I've yet to try it live, but I have a few comments looking in the code (esp. regarding aoe - yes, I've seen it has TODO marks, just my suggestions).

First of all, popping sweeping strikes on >1 mobs is not the best idea and can even lead to raid wipe.
An example can be Yorsahj hc where you can easily kill a floating-by low-hp mana void thus leaving your casters with no mana on the next blue phase.
First thing I'll do before trying it, is changing it to >2 as we probably don't care about the mana void if other adds are around.

Also, using WW in aoe situation will simply drain your rage with no dps increase in most cases. It'd be much better to use it along with cleave (which we also wouldn't like to use in low rage situations) for rage dump.

And I'd prioritize MS over WW (we have 2 out of 3 gcds for aoe stuff anyway).

Another thing I will surely comment out is recklessness if current target is boss. Considering the fact its cd is 5min, you'll hardly use it twice a fight (except for the last 2 DS bosses), so timing it with BL/Heroism looks to be good idea (at least better than just using it on cd).

That's what I notice at the first glance, I may be missing something or plainly wrong /discuss

Sweeping Strikes is there mostly for the rest of DS as a whole. (I know on Yor it can cause some issues, but you'll just need to place yourself properly so it won't trigger, or just turn off SS altogether (just comment it out))

As for WW, thats also mostly for Madness. Having the spellweave procs during hemo is quite a DPS boost. (Also, you don't end up rage starved that much when using WW anyway)

I'll think about adjusting Cleave, but I think for pure AOE, you should be spamming it anyway, as the WW rage should keep you above enough to basically use it on CD (assuming IR isn't popped)

As for Reck... given that you should be prepotting, it will pop Reck at the start, pop DC, and burst its way to 50k+ DPS in low level gear, (I've seen it burst over 90k on Ultrax). Also, on Ultrax, you'll have it twice, more often than not. (This assumes your raid isn't completely outgearing the content, and you're not in LFR, in which case popping it early is fine anyway)

I'll rewrite the Arms settings, so you can toggle things on/off and change the number of required mobs for stuff like Cleave/Sweeping/etc

Apoc · Mar 7, 2012

Nuok said:

Been working on some more advanced logic for taunting; I added this to Raid and call it when taunting.

Needs a bit of fleshing out but should improve taunting in LFR at least.

Note I've altered logging so I can change the colour so this wont work by copy & paste!

Code:

        /// <summary>        ///  Basic LFR tank taunting tactics, returns true if a taunt it needed
        /// </summary>
        public static bool NeedToRaidTaunt()
        {
            //Dragon Soul
            //Note this is for LFR mianly
            if (StyxWoW.Me.ZoneId == 5892)
            {
                // Morchok, Swaping on crush armour 2 stacks
                if (StyxWoW.Me.CurrentTarget.Entry == 55265)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Crush Armor", 2)
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && !StyxWoW.Me.HasAura("Crush Armor"))
                    {
                        Logger.Write(Color.Red, "Morchok: Taunting For Crush Armour");
                        return true;
                    }
                }


                //Ultraxion
                if (StyxWoW.Me.CurrentTarget.Entry == 55265)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Fading Light")
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid)
                    {
                        Logger.Write(Color.Red, "Ultraxion: Taunting other tank has fading light");
                        return true;
                    }
                }


                //Warmaster Blackhorn
                if (StyxWoW.Me.CurrentTarget.Entry == 56427)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Devastate", 2)
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && !StyxWoW.Me.HasAura("Devastate"))
                    {
                        Logger.Write(Color.Red, "Warmaster Blackhorn: Taunting other tank has devistate");
                        return true;
                    }
                }


                //Madness of Deathwing
                //Taunt on impale
                if (StyxWoW.Me.CurrentTarget.Entry == 56471)
                {
                    if (StyxWoW.Me.CurrentTarget.CurrentTarget.HasAura("Impale")
                        && StyxWoW.Me.CurrentTarget.CurrentTarget.Guid != StyxWoW.Me.Guid
                        && StyxWoW.Me.HasAura("Impale"))
                    {
                        Logger.Write(Color.Red, "Madness of Deathwing: Taunting for Impale");
                        return true;
                    } 
                }


                if (!Group.Tanks.Contains(StyxWoW.Me.CurrentTarget.CurrentTarget.ToPlayer()))
                {
                    Logger.Write("Taunting, " + StyxWoW.Me.CurrentTarget.Name + " is not targeting a Tank");
                    return true;
                }
                else return false;
            }
            return true;
        }

Obviously not good enough. Tsk tsk!

Seriously though, looks good. I'll play with it later tonight.

Nuok · Mar 7, 2012

Apoc said:
Obviously not good enough. Tsk tsk!

Seriously though, looks good. I'll play with it later tonight.

Hehe, i know i did it in about 10mins and havent had a chance to test it. I was just bored waiting for the realms to come up.

0ld · Mar 7, 2012

nomnomnom said:
I concur with this. Stance-Dancing doesnt work very well yet. I tried with and without Force proper stance.

Confirmed.
First it looked fine, but when on ultraxion hc my overpower only made 3% of my damage with overall dps of 40k, I switched to older singular which made me 46k (15% overpower) the previous kill.

(UPD) I've checked my raid logs (5hc bosses) and generally this new arms cc was doing great, with stance dancing etc except 2 bosses:
1. on morchok (I was on kohcrom) it just stopped doing anything on the execute phase.
2. on ultraxion, it had problems with stance dancing leaving me with no overpower damage.
Though I enabled the use of cooldowns on this boss (I was using them manually on the other bosses), maybe it broke the stance dancing somehow.
3. There were minor predictable problems with yorsahj where it started aoe rotation on the oozes when they were close to the boss, though I was able to dodge that in most cases with positioning farther from them. It was also loosing dps when starting aoe rotation before all the black phase mobs got close. I'd trigger aoe on 6+ mobs in this fight.
So the setting for aoe mobs number which we could quickly change from fight to fight would be great.

The rest of the bosses were ok.

I was behind the other arms warrior from my raid on morchok, yorsahj and ultraxion due to the issues above, but straightly outdpsed him on haggara and zonozz even though his gear is slightly better.

Thank you, I believe it is gonna be the best arms raiding cc available (though I did not try and compare to titan arms and truman, as they are using the lua shit rendering their ccs unusable for non-english locales).

0ld · Mar 8, 2012

I've found out that stance dancing works without probems when aoe is turned off.
And if it's turned on, it sometimes (I didn't find the reason or pattern) it just sticks to the berserk stance after the first stance switch.

surfer999 · Mar 8, 2012

Kikeron said:
Could not compile CC from D:\Honorbuddy\CustomClasses\Singular!
File: MountManager.cs Line: 23 Error: 'Styx.Logic.MountUpEventArgs' does not contain a definition for 'Destination' and no extension method 'Destination' accepting a first argument of type 'Styx.Logic.MountUpEventArgs' could be found (are you missing a using directive or an assembly reference?)
File: MountManager.cs Line: 26 Error: 'Styx.Logic.MountUpEventArgs' does not contain a definition for 'Destination' and no extension method 'Destination' accepting a first argument of type 'Styx.Logic.MountUpEventArgs' could be found (are you missing a using directive or an assembly reference?)

Same here after updating to new version of Singular with MountManager.cs

Full Log:
View attachment 08-Mar-12_12_24 PM 4004 Log.txt

dimsil · Mar 9, 2012

Warrior tank on tupit ultraksion. All the while using a heroic leap. How to get rid of?

handnavi · Mar 9, 2012

surfer999 said:
Same here after updating to new version of Singular with MountManager.cs

Full Log:
View attachment 37657

Use the newest Version of HB -> problem solved

Smoogel · Mar 9, 2012

Hi.

I'm currently leveling a druid which will spec feral. Its currently level 10 but it keeps pulling/starting combat with moonfire which I find to be very annoying and rather silly. Is there any way to stop this or will it automaticlly stop when it has a spell like Feral Charge?

Thanks.

0ld · Mar 10, 2012

dimsil said:
Warrior tank on tupit ultraksion. All the while using a heroic leap. How to get rid of?

have you tried turning it off in settings?

Flyryan · Mar 10, 2012

Spriest seems to use fear when shaman's totems are around. Not sure if that's how it was meant to be.

soussi · Mar 11, 2012

paladin retribution, always uses aura when mounting again. Couldn't set it off with settings.. is it possible to add a setting to not use auras or make it so that it will not constantly spamm aura when mounting again? (looks bottish when using GB)

*edit 1: more specific
This Q is to the devs of singular, if u will make some changes (about that issue) to the pala class in singular at the next HB update? thanks

0ld · Mar 12, 2012

soussi said:
paladin retribution, always uses aura when mounting again. Couldn't set it off with settings.. is it possible to add a setting to not use auras or make it so that it will not constantly spamm aura when mounting again? (looks bottish when using GB)

you can force aura in cc settings. though there's no crusader aura there, so (with current singular) you should choose whether to fly faster and switch auras all the time (auto setting) or stick to one aura, but fly slower. of course, the options also include 'add it to the code it yourself' or 'use some other cc'.

HansWurst · Mar 12, 2012

Hey!

I tried some instances with my frost dk, but it doesnt stop pull the mobs with death grip.
Yes, i set "taunting for tanks" to false.
Is there an other option which has to be changed?

ChibiMatt · Mar 12, 2012

Having trouble loading Singular. Latest revision from svn, latest hb, as far as i know. Thanks.

handnavi · Mar 12, 2012

ChibiMatt said:
Having trouble loading Singular. Latest revision from svn, latest hb, as far as i know. Thanks.

You dont have the latest HB!

Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

New Member

Well-Known Member

New Member

Community Developer

Attachments

Well-Known Member

Well-Known Member

Community Developer

New Member

New Member

New Member

New Member

Well-Known Member

New Member

New Member

New Member

Member

New Member

New Member

New Member

Attachments

Well-Known Member