Magomat (the casting machine that can't walk)

mahe4 · Jan 12, 2012

Magomat
(when you are lazy enough to let someone else press the buttons)

This is a CC for lazy raider

what it does:
arcane rotation (burst and conservation rotations)
fire rotation (aoe and single target rotation)
counter spell kickable spells on boss targets
uses cooldowns like evocation and mirror image

What it doesn't:
walk
use trinkets (not fully integrated yet)
tell you to walk out of the fire (and it never will ;D)
tell you how to setup itself

Recommended Fire Spec:
Talent Calculator - World of Warcraft

All Credits goes to fiftypence for some of his functions.

any suggestions to improve the code or to improve the rotations are welcome
all whiners are not...

This will steal your IP-adress, your name, your wife or girlfriend, your socks and your first born child.... but at least it will do your mage rotations ;P

Code:

v0.8.0 release
v0.8.1 fixed Blast Wave bug
v0.9.0 got rid of stopwatch (flamestrike now checks for "burning ground")
v0.9.1 fixed some CD issues
v0.9.2 fixed version number; added mana gem to fire; added armor swapping to fire; added lag friendly Pyroblast
v0.9.3 should now cast pyroblast properly

SVN Checkout

hakara · Jan 13, 2012

only spams scorch~

mahe4 · Jan 13, 2012

hakara said:
only spams scorch~

it does use scorch on non bosses in 5man dungeons
but it should also use pyroblast on hot streak and use living bomb and combustion...

can you please send me a log file?
or give me at least some more information?

hakara · Jan 13, 2012

Sorry im not at home anymore, But i was only testing on Dummies. Will try again later when i get home thanks Mahe4!

kbrebel04 · Jan 13, 2012

I can tell you before looking at it that it spams scorch because:

You have it set to only use scorch when the critical mass debuff is missing.

Well when you have a warlock or frost Mage in your group they will apply the same buff with a different name and overwrites the critical mass debuff, leading to schoch spam

You need to include all similar debuffs to avoid this

mahe4 · Jan 13, 2012

kbrebel04 said:
I can tell you before looking at it that it spams scorch because:

You have it set to only use scorch when the critical mass debuff is missing.

Well when you have a warlock or frost Mage in your group they will apply the same buff with a different name and overwrites the critical mass debuff, leading to schoch spam

You need to include all similar debuffs to avoid this

Code:

CastSpell("Scorch", a => TargetDebuffTimeLeftAll("Winter's Chill") < 2 && TargetDebuffTimeLeftAll("Critical Mass") < 2 && TargetDebuffTimeLeftAll("Shadow and Flame") < 2),

already integrated...
but it does scorch twice because of the lag between hit and buff apply

Venus112 · Jan 13, 2012

You say trinkets are not fully integrated?

It just used mine

mahe4 · Jan 13, 2012

Venus112 said:
You say trinkets are not fully integrated?
It just used mine

as i say
not FULLY integrated xD
it should use trinkets on arcane burn phase
but it doesn't use trinkets as fire mage

Venus112 · Jan 13, 2012

Ah! Righto, gotcha.

Edit:
On a training dummy, is it supposed to just spam scorch instead of fireball?

Code:

CastSpell("Scorch", a => TargetDebuffTimeLeftAll("Winter's Chill") < 2 && TargetDebuffTimeLeftAll("Critical Mass") < 2 && TargetDebuffTimeLeftAll("Shadow and Flame") < 2)

Dont we want it to scorch, if the time left is under 2 seconds, no matter which one and not all

Dont we want this?

Code:

CastSpell("Scorch", a => TargetDebuffTimeLeftAll("Winter's Chill") < 2 || TargetDebuffTimeLeftAll("Critical Mass") < 2 || TargetDebuffTimeLeftAll("Shadow and Flame") < 2)

Edit:
Didn't do it.
The CC is spamming scorch like a mad man for me in fire spec.

mahe4 · Jan 13, 2012

Venus112 said:
Ah! Righto, gotcha.

Edit:
On a training dummy, is it supposed to just spam scorch instead of fireball?

Code:

CastSpell("Scorch", a => TargetDebuffTimeLeftAll("Winter's Chill") < 2 && TargetDebuffTimeLeftAll("Critical Mass") < 2 && TargetDebuffTimeLeftAll("Shadow and Flame") < 2)

Dont we want it to scorch, if the time left is under 2 seconds, no matter which one and not all

Dont we want this?

Code:

CastSpell("Scorch", a => TargetDebuffTimeLeftAll("Winter's Chill") < 2 || TargetDebuffTimeLeftAll("Critical Mass") < 2 || TargetDebuffTimeLeftAll("Shadow and Flame") < 2)

Edit:
Didn't do it.
The CC is spamming scorch like a mad man for me in fire spec.

it is right as it is...
only if all three are true it will cast THIS scorch
so if no debuff is up:
true true true
if one of the buffs is over 2 sec it's
false true true
true fale true or
true true false

can you please a log file?
and did you try it on a little dummy or a boss dummy?

Venus112 · Jan 13, 2012

Was just a normal dummy.
Can't find the log for ya right now.
Will do a test later

mahe4 · Jan 13, 2012

Venus112 said:
Was just a normal dummy.
Can't find the log for ya right now.
Will do a test later

then it works as intended
as long as you are not in a raid and the target is not a boss, the cc casts scorch instead of fireball
in my opinion it is better on 5man trash to use scorch for more impact proccs and mana conservation (and i imagine a bit more pyro procs)
if you are in a raid, it will use fireball on trash mobs

if you want me to change it, i will do that
bot for 5man trash i got a little mor dps this way

Venus112 · Jan 13, 2012

Ah!
Didn't think of it that way.
Smart. But you could associate the training dummies with bosses perhaps, so you would get a rotation going to check it out :

Added a text document when the changes (not gonna just plot it into the browser, as it tends to ruin how it looks imho)

Small and simple added code, to make sure that we treat dummies like bosses

Just added a bit to the Bool IsTargetBoss()

------

also, consider changing a line in DetectAdds

Code:

(unit.IsTargetingMyPartyMember || unit.IsTargetingMyRaidMember || unit.IsTargetingMeOrPet)

to

Code:

(unit.IsTargetingMyPartyMember || unit.IsTargetingMyRaidMember || unit.IsTargetingMeOrPet || unit.Name == "Risen Ghoul")

That's for the dungeon End Time. As the Risen Ghoul that spawns, is not targetting anyone so the CC wont attack it

mahe4 · Jan 13, 2012

Venus112 said:
Ah!
Didn't think of it that way.
Smart. But you could associate the training dummies with bosses perhaps, so you would get a rotation going to check it out :

Added a text document when the changes (not gonna just plot it into the browser, as it tends to ruin how it looks imho)

Small and simple added code, to make sure that we treat dummies like bosses

Just added a bit to the Bool IsTargetBoss()

why don't you just use the boss dummy?

Venus112 · Jan 13, 2012

I dont know, probably cause my gear is shite... :/
No harm in having it there?

Also noted that there's no reason to add the boss dummy, as it will return as a boss without adding it

I've also added a code for End Time Heroic, that makes sure we'll attack Risen Ghouls on "Echo of Sylvanas"

mahe4 · Jan 13, 2012

it doesn't attack risen ghouls if you target them?

Venus112 · Jan 13, 2012

from what i see in the coding, it shouldn't.

Haven't tested it, was just from what i saw in the coding. (my CC didn't do it, i've just added the code myself.. Should work, but not tested yet)
Just something to look out for

But then again, your CC did notice the normal dummy, just not as a boss.
So could be you have a code some place that i dont know, and in that case - i am very sorry, and i'll shut my mouth (still kinda new to programming)

mahe4 · Jan 13, 2012

Venus112 said:
from what i see in the coding, it shouldn't.

Haven't tested it, was just from what i saw in the coding. (my CC didn't do it, i've just added the code myself.. Should work, but not tested yet)
Just something to look out for

But then again, your CC did notice the normal dummy, just not as a boss.
So could be you have a code some place that i dont know, and in that case - i am very sorry, and i'll shut my mouth (still kinda new to programming)

better be safe than sorry

i won't at the normal target dummy to the boss section, cause i use the boss dummy for boss rotation tests. and i think most people will do that.
and i'm not sure, but i think i tested the cc on risen ghouls. so i won't add that either until someone reports a problem about that^^
hope it don't bothers you^^

do you have any suggestions about the rotation?
for example right now combustion will be used when every dot is on the target...
but it could be better if some dot's are more than x seconds remaining, to maximize the combustion damage... but i don't know...

Venus112 · Jan 13, 2012

Haven't played mage in a loong time, but isn't it just about what buffs that are on the target at that current moment you put up combustion?

Gonna try it now, but:
Wouldn't it be possible to add a polymorph on focus target?

Something like:
If target = polymorphed
And target is taking no damage, then keep polymorphing?

mahe4 · Jan 13, 2012

Venus112 said:
Haven't played mage in a loong time, but isn't it just about what buffs that are on the target at that current moment you put up combustion?

Gonna try it now, but:
Wouldn't it be possible to add a polymorph on focus target?

Something like:
If target = polymorphed
And target is taking no damage, then keep polymorphing?

good idea

i think about how to code that^^

Magomat (the casting machine that can't walk)

Member

New Member

Member

New Member

New Member

Member

New Member

Member

New Member

Member

New Member

Member

New Member

Attachments

Member

New Member

Member

New Member

Member

New Member

Member