Requesting: Shadow Power (true/false) for Shadow Mantle set

[The Red Terror]

I'd like to request a Shadow Mantle combat routine for trinity but I doubt it will happen. So I'd like to ask for just:

If Shadow Power is active
cast Shadow Power
else


Something like that. I noticed in the rift there is no point whatsoever that the bot uses Shadow Power. It's fine in normal rifts since the bot never dies and I activated Shadow Power ahead of time, but when I'm doing greater rifts shadow power is disabled (all buffs are removed) before entering and have to be reapplied.

I've tried editing the routines in the past but it never seemed to take as something would override it. Any help would be great.

 

[TwoCigars]

Provide a link to the build, you never know what might happen

 

[UnhallowedEssence]

I made a "workaround" that seems to work:

Edit "DemonHunterBase.cs" in Trinity\Routines\DemonHunter.

Original:

protected virtual bool ShouldShadowPower()
{
if (!Skills.DemonHunter.ShadowPower.CanCast())
return false;

if (Player.HasBuff(SNOPower.DemonHunter_ShadowPower))
return false;

if (Skills.DemonHunter.ShadowPower.TimeSinceUse < 4500)
return false;

if (TargetUtil.AnyElitesInRange(40f))
return true;

if (Player.CurrentHealthPct < 0.7f)
return true;

if (TargetUtil.NumMobsInRange() > 5)
return true;

return false;
}

workaround:

protected virtual bool ShouldShadowPower()
{
if (!Skills.DemonHunter.ShadowPower.CanCast())
return false;

if (Player.HasBuff(SNOPower.DemonHunter_ShadowPower))
return false;

if (Skills.DemonHunter.ShadowPower.TimeSinceUse < 4500)
return false;

if (Player.CurrentHealthPct < 1.1f)
return true;

return false;
}

 

[TwoCigars]

Fair warning here:

Any changes that you make to the DemonHunterBase could affect that skill in every build that the DH uses.

IE you might see an improvement in what you're trying to do, but might break everything else.

Its best to place an override in the actual routine that you're using rather than risking a break in the other DH routines.

I made a "workaround" that seems to work:

workaround:

[COLOR=#FF0000][I]if (Player.CurrentHealthPct < 1.1f)[/I][/COLOR]
[COLOR=#FF0000][I]return true;[/I][/COLOR]

Why are you trying to change the health for activation to more than 110%? Would make more sense to just not have that line there at all.

You are also removing the code to have it activate when elites are around or more than 5 enemies are nearby?


I repeat my original question to the OP. Is there a link that you can provide to the build that you want so that someone can actually make a routine for the build?

I just finished with 3 monk routines and the hammerdin routine, DH is not likely my next target. I am not promising that I am going to make it anytime soon. But if you just say "I want Shadow Mantle routine" that could mean anything.

 

[UnhallowedEssence]

Fair warning here:

Any changes that you make to the DemonHunterBase could affect that skill in every build that the DH uses.

IE you might see an improvement in what you're trying to do, but might break everything else.

Its best to place an override in the actual routine that you're using rather than risking a break in the other DH routines.

This workaround was intended for a fresh 4 pieces Shadow mantle set, given by Haedrig's Gift with early gear and a generic shadow mantle build, in which case base routine works pretty well except for this skill. Obviously you have to backup the original "base" file and restore it when using other specific set routines. I apologise for not specify that, but I thought it was obvious to OP.

Why are you trying to change the health for activation to more than 110%? Would make more sense to just not have that line there at all.

I tested it and didn't work, I thought that it needs a satisfied condition returning "true" in order to activate the skill. So I simply wrote that easy "always true" condition.

You are also removing the code to have it activate when elites are around or more than 5 enemies are nearby?

Man, shadow Power lasts forever with this set, so we just want it to be activated as soon as combat mode begins. In fact I supose it would be enough just "if (Player.HasBuff(SNOPower.DemonHunter_ShadowPower)) return false;"

I repeat my original question to the OP. Is there a link that you can provide to the build that you want so that someone can actually make a routine for the build?

I just finished with 3 monk routines and the hammerdin routine, DH is not likely my next target. I am not promising that I am going to make it anytime soon. But if you just say "I want Shadow Mantle routine" that could mean anything.

As I said before I think OP just wanted to bot more efficiently with a fresh shadow mantle set so he could quickly get gear for more "serious builds"