What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

[Plugin] AdvancedItemFilter RELOADED !

Status
Not open for further replies.
i get your answer...but i sold the shit boots/chests...so i must wait till next gets stashed
 
Hey toNyx,

it's the guy who doesn't want his Uniques Identified again xD
Just got a little update: ID'ing of Uniques HAS to be coded somewhere in your Plugin.

The reason I'm saying this is as following:
1) If AIF disabled completely: Uniques do not get identified.
2) If AIF enabled but "Custom Rules", "Jyam's filters for rare items" and "On-The-Fly identification" disabled: Uniques do get identified.

Therefore my rules can not be the reason for Uniques getting identified whatever I do but AIF has to be the reason.
I would realy appreciate it if you could take a closer look as to why Uniques get identified when AIF is running regardless of custom rules.

I also attached my latest log (AIF enabled, MISC stuff and Custom Rules disabled)
 

Attachments

Camuroi said:
Hey toNyx,

it's the guy who doesn't want his Uniques Identified again xD
Just got a little update: ID'ing of Uniques HAS to be coded somewhere in your Plugin.

The reason I'm saying this is as following:
1) If AIF disabled completely: Uniques do not get identified.
2) If AIF enabled but "Custom Rules", "Jyam's filters for rare items" and "On-The-Fly identification" disabled: Uniques do get identified.

Therefore my rules can not be the reason for Uniques getting identified whatever I do but AIF has to be the reason.
I would realy appreciate it if you could take a closer look as to why Uniques get identified when AIF is running regardless of custom rules.

I also attached my latest log (AIF enabled, MISC stuff and Custom Rules disabled)
Click to expand...

Nope, it's not coded anywhere. I checked last time you told me so.

Jaym's filters force the identification iirc. :)

Sebozz said:
View attachment 185946 8hours log several shit items stashed without fit a rule <.< mainly chests
Click to expand...

Disable Jyam's filters, fixed.
 
toNyx said:
Nope, it's not coded anywhere. I checked last time you told me so.

Jaym's filters force the identification iirc. :)
Click to expand...

Then why the hell are those items identified without custom rules and without Jyam's filter enabled? Just enabling the Plugin, even with everything diabled, results in identified Uniques. Disabling the Plugin results in unidentified Uniques. But I really like AIF. It's an awesome Plugin. So I really don't want to leave it disabled :(
Just realized: Bot just starts to ID EVERYTHING as soon as Plugin is enabled. Not just uniques and rares but also those unvaluable magic RGB-Items. Just everything in its Inventory gets identified. Maybe that helps in finding the reason for forced identification.

I'm sorry to be annoying about it.
 
Camuroi said:
Then why the hell are those items identified without custom rules and without Jyam's filter enabled? Just enabling the Plugin, even with everything diabled, results in identified Uniques. Disabling the Plugin results in unidentified Uniques. But I really like AIF. It's an awesome Plugin. So I really don't want to leave it disabled :(
Just realized: Bot just starts to ID EVERYTHING as soon as Plugin is enabled. Not just uniques and rares but also those unvaluable magic RGB-Items. Just everything in its Inventory gets identified. Maybe that helps in finding the reason for forced identification.

I'm sorry to be annoying about it.
Click to expand...

You're not annoying, you're just saying that there's something hardcoded for uniques in AIF. There's none. You could even verify yourself if you were not too busy blaming the plugin.

HERE IS THE ID PART OF THE CODE

There's security checks for 6S/Recipe items, else it's custom rules stuff. You'll need to dig into your rules, there might be a conflict somewhere.

I'll take a look at the log a bit deeper, but I can't say it's AIF.

// EDIT //

Funny thing, is that your log doesn't have any mention of AIF working at all. Can't find anything related to custom rules, so before I start to be aggro I suggest you to get a fucking log where AIF does anything.
 
Last edited:
toNyx said:
You're not annoying, you're just saying that there's something hardcoded for uniques in AIF. There's none. You could even verify yourself if you were not too busy blaming the plugin.

HERE IS THE ID PART OF THE CODE

There's security checks for 6S/Recipe items, else it's custom rules stuff. You'll need to dig into your rules, there might be a conflict somewhere.

I'll take a look at the log a bit deeper, but I can't say it's AIF.

// EDIT //

Funny thing, is that your log doesn't have any mention of AIF working at all. Can't find anything related to custom rules, so before I start to be aggro I suggest you to get a fucking log where AIF does anything.
Click to expand...


I did look into the code already for some hours. But me only being able to SOMEHOW understand the general meaning of the code does not help me finding anything. The only part I found a little strange is this(IdentifyItems.cs; 113-117):
Code: 
if (LokiPoe.Me.IsInHideout || LokiPoe.Me.IsInTown)
            {
                var unidItems = LokiPoe.InGameState.InventoryPanel.MainInventory.Items
                .Where(i => !i.IsIdentified && i.Rarity >= Rarity.Rare && !i.IsProtectedFromIdentification())
                .ToList();
But I guess this is concerning On-the-Fly handling.


Also: As I said I attached a log to this post in which custom rules are disabled.
Also: As i said my rules can not be at fault because Bot is still identifying when I disable custom rules.
Also: I've attached 4 different logs concerning this problem so you do have quite some logs to look into. (attached them in this post again so you don't have to search for them)
Also: I'm only blaming the plugin because: Plugin is enabled=bot ids EVERYTHING without difference. It does not matter if I have every option of the plugin disabled or any combination of options enabled. Plugin is disabled=nothing gets identified.
Also: You already took a look at my rules and did not find anything to cause this. So please stop telling me to look at my rules every time :)

Last question: Could I add something like this into the ID-Section to add ID-protection for uniques?
Code: 
if (cachedItemRarity = Unique)
                    return false;
 

Attachments

Camuroi said:
I did look into the code already for some hours. But me only being able to SOMEHOW understand the general meaning of the code does not help me finding anything. The only part I found a little strange is this(IdentifyItems.cs; 113-117):
Code: 
if (LokiPoe.Me.IsInHideout || LokiPoe.Me.IsInTown)
            {
                var unidItems = LokiPoe.InGameState.InventoryPanel.MainInventory.Items
                .Where(i => !i.IsIdentified && i.Rarity >= Rarity.Rare && !i.IsProtectedFromIdentification())
                .ToList();
But I guess this is concerning On-the-Fly handling.


Also: As I said I attached a log to this post in which custom rules are disabled.
Also: As i said my rules can not be at fault because Bot is still identifying when I disable custom rules.
Also: I've attached 4 different logs concerning this problem so you do have quite some logs to look into. (attached them in this post again so you don't have to search for them)
Also: I'm only blaming the plugin because: Plugin is enabled=bot ids EVERYTHING without difference. It does not matter if I have every option of the plugin disabled or any combination of options enabled. Plugin is disabled=nothing gets identified.
Also: You already took a look at my rules and did not find anything to cause this. So please stop telling me to look at my rules every time :)

Last question: Could I add something like this into the ID-Section to add ID-protection for uniques?
Code: 
if (cachedItemRarity = Unique)
                    return false;
Click to expand...

Also, have fun.

1) Why blame the plugin if you don't use the features.
2) AIF calls the default item evaluator if custom rules are disabled.
3) Won't even take the time to look at it.
4) I use AIF on every setup possible, and you're the one reporting this issue. the one.
5) I looked at it very fast, I hate digging into json files.
6) Yes.

Don't wonder why I don't answer your next posts.
 
Last edited:
toNyx said:
Also, have fun.

1) Why blame the plugin if you don't use the features.
2) AIF calls the default item evaluator if custom rules are disabled.
3) Won't even take the time to look at it.
4) I use AIF on every setup possible, and you're the one reporting this issue. the one.
5) I looked at it very fast, I hate digging into json files.
6) Yes.

Don't wonder why I don't answer your next posts.
Click to expand...
Vouch for tony, I haven't had issues and I have a large sample size. (That's what she said huehhueh)
When more and more users report problems, I suggest tony dig into it otherwise, a small sample size from one person isn't sufficient criteria to spend hours on. That's my 2 cents.

Edit, typos.
 
darkbluefirefly said:
Vouch for tony, I haven't had issues and I have a large sample size. (That's what she said huehhueh)
When more and more users report problems, I suggest tony dig into it otherwise, a small sample size from one person isn't sufficient criteria to spend hours on. That's my 2 cents.

Edit, typos.
Click to expand...


I can understand that. I'm only disappointed toNyx didn't really read my posts (obvious in his answers) and always told me my rules are at fault even though it happens regardless of enabled or disabled rules AND he looked them over (thanks again for doing so btw).
And I'm disappointed in getting aggressive answers after doing everything to provide every imaginable information about when and how this happens to narrow it down as much as possible.
In no way was it ever my intention to insult him OR his work. I just wanted to help find the reason for a bug I experience. I even spent hours on looking through the code myself, spending another set of hours to learn enough of the coding language to at least understand the code somwhat.
So it's really disappointing to receive such an aggressive and dismissive answer.
 
Ya dude, I'll help tony trouble shoot this, mind pming me your rules?
I'm really good at pissing tony off so it's ok.
 
honestly I've noticed it IDs everything once it passes the "save items for recipe" threshold. It IDs then checks vs keep rules then it defaults to the "else" statement (i know SQL so else is all i understand :P) which defaults to sell. I thought about lookin at it to fix IDing everything... then I realized I dont care about items I dont know I lost :P

I would rather put that time in to set up another bot and be efficient with my time.
 
OneStopMMO said:
honestly I've noticed it IDs everything once it passes the "save items for recipe" threshold. It IDs then checks vs keep rules then it defaults to the "else" statement (i know SQL so else is all i understand :P) which defaults to sell. I thought about lookin at it to fix IDing everything... then I realized I dont care about items I dont know I lost :P

I would rather put that time in to set up another bot and be efficient with my time.
Click to expand...
Ok Another person. I have access to tony's SVN so I can screw around and blame him.
@Camuroi, I'm almost done Quest Plugin, so I'll dig into it today or tomorrow after I watch some Dragon Ball Z.
 
Hello friends,

Talking about AIF IDing things without we tell it to do so, I can also confirm that.
I'm using my custom rules and, as example, bot picks up magic 6s / magic qual flasks / magic RBG and all of them get IDed with no command to ID magic items in the filter...
For me it's not a big problem since I usually ID all rares and uniques it gets. I just lose some scrolls :D

Hey toNyx, any progress on the GCP feature issue fix? I'm waiting anxious for that...
Thanks.
 
fabcard said:
Hello friends,

Talking about AIF IDing things without we tell it to do so, I can also confirm that.
I'm using my custom rules and, as example, bot picks up magic 6s / magic qual flasks / magic RBG and all of them get IDed with no command to ID magic items in the filter...
For me it's not a big problem since I usually ID all rares and uniques it gets. I just lose some scrolls :D

Hey toNyx, any progress on the GCP feature issue fix? I'm waiting anxious for that...
Thanks.
Click to expand...

You mean the null error? I think I fixed it, I'm running flawlessly with that checked for now. I'm investigating a weird issue with item types reported by a user.

For the ID thing, think I found a fix. Testing it atm. (I was wondering why AIF's item eval was not sending Ids logs correctly)
 
Last edited:
Code: 
 [LatencyTracker] LowestLatency: 18
[LatencyTracker] HighestLatency: 34
[LatencyTracker] HighestLatency: 40
[LatencyTracker] LowestLatency: 17
[LatencyTracker] AverageLatency: 21
[LatencyTracker] HighestLatency: 21
[LatencyTracker] HighestLatency: 23
[LatencyTracker] HighestLatency: 28
[LatencyTracker] LowestLatency: 23
[LatencyTracker] HighestLatency: 23
[LatencyTracker] HighestLatency: 24
[LatencyTracker] LowestLatency: 19
[LatencyTracker] HighestLatency: 21
[LatencyTracker] LowestLatency: 17
[LatencyTracker] HighestLatency: 22
[LatencyTracker] AverageLatency: 20
[LatencyTracker] HighestLatency: 20
[LatencyTracker] HighestLatency: 21
[LatencyTracker] HighestLatency: 22
[LatencyTracker] HighestLatency: 24
[LatencyTracker] HighestLatency: 25
[LatencyTracker] LowestLatency: 18
[LatencyTracker] HighestLatency: 18
[LatencyTracker] HighestLatency: 21
[LatencyTracker] LowestLatency: 16
[LatencyTracker] HighestLatency: 23
[LatencyTracker] HighestLatency: 22
[LatencyTracker] HighestLatency: 24
[LatencyTracker] AverageLatency: 21
[LatencyTracker] LowestLatency: 23
[LatencyTracker] HighestLatency: 23
[WaitForStashTabContents] Waiting for the page control to change.
[WaitForStashTabContents] The page control did not change.
[WithdrawItemsCoroutine] NextTab failed.
[RecipeWithdrawTask] Seems like we had a problem withdrawing (Helmet : True) We're gonna count if all items are in inventory already
[RecipeWithdrawTask] We're missing a piece of gear, reloading task execution

Loop of doom. Tried deleting logs in EB folder / logs but still persisting. Dont know how to fix this for long term, however the bot that doesn't die has no issues. Perhaps a code to dump any saved info on sets and reevaluate after a certain amount of loops.

I also remember reading somewhere that Tony said it's due to something about specifying tabs to protect or stash into, since fresh install I have no put anything but protected tabs, no specific stash into or get from. However another suggestion is take recipe items from first X tabs where we fill in 1 or 4 or w.e and it only tells it how many tabs to check from full left. No need to remember names or check them.
 
Last edited:
Status
Not open for further replies.
Back
Top