Trinity 2.9.1 and QuestTools 3.4.19

beardi · May 16, 2015

BottyBoi said:
Still goes for Gogok of Swiftness, which is at its maxlevel and just creates a loop until gold inactivity is tripped. I've literally put it on bottom and that's still the one it chooses.

If you have Gogok Equipped then of course it's going to choose it..

It chooses the highest % chance to upgrade gem which is equipped i.e the Gogok because it's only R50, so take Equipped gems down to the bottom and Gogok there too.

BottyBoi · May 16, 2015

beardi said:
If you have Gogok Equipped then of course it's going to choose it..

It chooses the highest % chance to upgrade gem which is equipped i.e the Gogok because it's only R50, so take Equipped gems down to the bottom and Gogok there too.

I've said which gems I have equipped. Gogok is not one of them. Thanks for your input though.

I have bane of the trapped at the very top, doesn't matter. Goes for other ones anyway.

austin909 · May 16, 2015

In profile zerg mode(like <CombatSetting combat="false" />)
The bot can't attack corrupt growth in A4.
And then stucked...

TarasBulba · May 16, 2015

Trinity fork handles the WW barb much better, it would be nice if the devs implemented these changes in the original.

infinity · May 16, 2015

TarasBulba said:
Trinity fork handles the WW barb much better, it would be nice if the devs implemented these changes in the original.

Telling us Fork works with the new Beta ? That's new.... Thought it dint.

TarasBulba · May 16, 2015

infinity said:
Telling us Fork works with the new Beta ? That's new.... Thought it dint.

What I meant is the fork with DB#404 worked better barb.

Benevolene · May 16, 2015

My WW barb keeps getting stuck on corners and at walls with enemies behind them.

TarasBulba · May 16, 2015

Also, I wonder would it be better if the radius for the zigzag was much smaller, I've done some testing and boss dps increased considerably.

jubisman · May 16, 2015

fabcard said:
Yes friend, same problem here.
DB Beta 519, latest QT/Trinity from assembla.
This issue started on assembla jubisman change named "Fixed Bash - Punish acting wonky", and other changes after that. On his previous change "Added CanCast check for Ignore Pain" there's not that kind of problem.
Due that, Trinity doesn't show up on DB plugins tab.
Thanks in advance.

My bad, I was running low on caffeine at the time. Fixed now.

TarasBulba said:
Also, I wonder would it be better if the radius for the zigzag was much smaller, I've done some testing and boss dps increased considerably.

This is a TVar IIRC, so you can change that on your own. Just go to the variables tab and mess around with Barbarian.Whirlwind distance values, check what best suits you.

beardi · May 16, 2015

I wonder if someone could implement Fujiyama's Dashing strike code into this or a future version of Trinity? It is much more effective at dashing than this release due to the fact that it dashes past a mob instead of directly underneath it.

Code:

// Dashing Strike            if (CanCastDashingStrike)
            {
                
                if (Legendary.Jawbreaker.IsEquipped &&
                    (
                        (Hotbar.Contains(SNOPower.Monk_FistsofThunder) && SpellHistory.TimeSinceUse(SNOPower.Monk_FistsofThunder) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_DeadlyReach) && SpellHistory.TimeSinceUse(SNOPower.Monk_DeadlyReach) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_WayOfTheHundredFists) && SpellHistory.TimeSinceUse(SNOPower.Monk_WayOfTheHundredFists) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_CripplingWave) && SpellHistory.TimeSinceUse(SNOPower.Monk_CripplingWave) < TimeSpan.FromMilliseconds(4900))
                    )
                )
                {
                    return JawBreakerDashingStrike();
                }


                // Raiment set, dash costs 75 spirit and refunds a charge when it's used
                
                
                if (Sets.ThousandStorms.IsSecondBonusActive && 
                    (
                        (Skills.Monk.DashingStrike.Charges > 1 && (Skills.Monk.DashingStrike.TimeSinceUse > 200 || CacheData.Buffs.HasCastingShrine)) || 
                        (Player.PrimaryResource > 250 && Skills.Monk.DashingStrike.Charges > 0 && (Skills.Monk.DashingStrike.TimeSinceUse > 200 || CacheData.Buffs.HasCastingShrine)) ||
                        (Player.PrimaryResource > 150 && Skills.Monk.DashingStrike.Charges > 0 && (Skills.Monk.DashingStrike.TimeSinceUse > 500|| CacheData.Buffs.HasCastingShrine)) || 
                        (Player.PrimaryResource > 75 && Skills.Monk.DashingStrike.Charges > 0 && (Skills.Monk.DashingStrike.TimeSinceUse > 1000 || CacheData.Buffs.HasCastingShrine)) || 
                        (CacheData.Buffs.HasCastingShrine && Skills.Monk.DashingStrike.Charges > 0)
                    ) &&
                    (
                        (Hotbar.Contains(SNOPower.Monk_FistsofThunder) && SpellHistory.TimeSinceUse(SNOPower.Monk_FistsofThunder) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_DeadlyReach) && SpellHistory.TimeSinceUse(SNOPower.Monk_DeadlyReach) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_WayOfTheHundredFists) && SpellHistory.TimeSinceUse(SNOPower.Monk_WayOfTheHundredFists) < TimeSpan.FromMilliseconds(4900)) ||
                        (Hotbar.Contains(SNOPower.Monk_CripplingWave) && SpellHistory.TimeSinceUse(SNOPower.Monk_CripplingWave) < TimeSpan.FromMilliseconds(4900))
                    )
                
                )
                {
                    bool ignoreUnitsInAOE = false;
                    if (Player.CurrentHealthPct < 0.4) {ignoreUnitsInAOE = true;}
                    
                    RefreshSweepingWind(true);
                    
                    if (CurrentTarget.IsBossOrEliteRareUnique)
                    {
                        
                        TrinityCacheObject dashtarget = TargetUtil.GetFarthestEliteWithinRange(50f, ignoreUnitsInAOE);
                        float direction = (float)MathUtil.FindDirectionRadian(Player.Position, dashtarget.Position);
                        dashtarget.Position = MathEx.GetPointAt(Player.Position, dashtarget.RadiusDistance + 5f, (float)direction);
                        
                        
                        //SpellHistory.RecordSpell(SNOPower.X1_Monk_DashingStrike);
                        return new TrinityPower(SNOPower.X1_Monk_DashingStrike, MaxDashingStrikeRange, dashtarget.Position);
                    }
                    else
                    {
                        TrinityCacheObject dashtarget = TargetUtil.GetBestPierceTarget(50f, ignoreUnitsInAOE);
                        float direction = (float)MathUtil.FindDirectionRadian(Player.Position, dashtarget.Position);
                        dashtarget.Position = MathEx.GetPointAt(Player.Position, dashtarget.RadiusDistance + 5f, (float)direction);
                        
                        //SpellHistory.RecordSpell(SNOPower.X1_Monk_DashingStrike);
                        return new TrinityPower(SNOPower.X1_Monk_DashingStrike, MaxDashingStrikeRange, dashtarget.Position);
                    }


                }


                if (!Sets.ThousandStorms.IsSecondBonusActive)
                {
                    // We get a charge every 8 seconds. If we have 2 charges, be dashing
                    if (Skills.Monk.DashingStrike.Charges > 1 && (Skills.Monk.DashingStrike.TimeSinceUse > 200 || CacheData.Buffs.HasCastingShrine) )
                    {
                        Logger.Log("SecondBonusActive = False");
                        return new TrinityPower(SNOPower.X1_Monk_DashingStrike, MaxDashingStrikeRange, CurrentTarget.Position);
                    }


                    if ((Skills.Monk.DashingStrike.TimeSinceUse > 200 || CacheData.Buffs.HasCastingShrine) && Skills.Monk.DashingStrike.Charges > 1 && CurrentTarget.IsEliteRareUnique || TargetUtil.ClusterExists(15f, 3) &&
                        TargetUtil.IsUnitWithDebuffInRangeOfPosition(15f, TargetUtil.GetBestClusterPoint(), SNOPower.Monk_ExplodingPalm) ||
                        TargetUtil.AnyMobsInRangeOfPosition(CurrentTarget.Position, 20f, 3) && Skills.Monk.ExplodingPalm.IsTrackedOnUnit(CurrentTarget) ||
                        _hasSwk && TargetUtil.AnyMobsInRange(50f))
                    {
                        Logger.Log("SecondBonusActive = False");
                        RefreshSweepingWind(true);
                        //SpellHistory.RecordSpell(SNOPower.X1_Monk_DashingStrike);
                        return new TrinityPower(SNOPower.X1_Monk_DashingStrike, MaxDashingStrikeRange, CurrentTarget.Position, Trinity.CurrentWorldDynamicId, -1, 2, 2);
                    }
                }
            }

Had trouble adding the various variables myself so the source is here if anyone fancies a go

https://www.assembla.com/code/fujiyama-unifiedtrinity-fork/git/nodes/master/Trinity

losingstreak1 · May 16, 2015

dont want to hate on the hard work put into updates and stuff, but whats with the lack of love for Demon hunter trinities. the combat is always so bad. and usually its just simple avoidance and not facetanking bosses.

SGgags · May 16, 2015

Thx rrrix and the rest. It's awesome.

losingstreak1 · May 17, 2015

anyone know how to set fan of knives and smokescreen to just keep spamming off cooldown with no other stipulations? so even when out of combat

austin909 · May 17, 2015

About DemonHunter.
It looks like Player.SecondaryResourceMax is always 30, even passive skills or equipment to increase the maximum value of Discipline.
This problem will make Player.SecondaryResourcePct and Player.SecondaryResourceMissing cannot work well.

Through debug code, I found the problem seems to be in _me.MaxSecondaryResource.It always return 30.
_me is DiaActivePlayer,so it looks like a DB issue.

Update: DiaActivePlayer.MaxPrimaryResource have same issue.It is always return 125.

Bulleye1234 · May 17, 2015

Benevolene said:
My WW barb keeps getting stuck on corners and at walls with enemies behind them.

Edit HandleTarget.cs:

Original(remove red line):

Code:

if (Player.ActorClass == ActorClass.Barbarian)
                        {
                            bool wwToItem = (CurrentTarget.Type != TrinityObjectType.Item || (CurrentTarget.Type == TrinityObjectType.Item && CurrentTarget.Distance > 10f [COLOR="#FF0000"]&& NavHelper.CanRayCast(CurrentTarget.Position)[/COLOR]));
                            // Whirlwind against everything within range
                            if (Player.PrimaryResource >= 10 && CombatBase.CanCast(SNOPower.Barbarian_Whirlwind) && wwToItem &&
                                (TargetUtil.AnyMobsInRange(20, false) || Sets.BulKathossOath.IsFullyEquipped) && !IsWaitingForSpecial)
                            {
                                Skills.Barbarian.Whirlwind.Cast(CurrentDestination);
                                LastMoveToTarget = CurrentDestination;
                                return GetRunStatus(RunStatus.Running, "Whirlwind");
                            }
                        }

Edited (add red line):

Code:

if (Player.ActorClass == ActorClass.Barbarian)
                        {
                            bool wwToItem = (CurrentTarget.Type != TrinityObjectType.Item || (CurrentTarget.Type == TrinityObjectType.Item && CurrentTarget.Distance > 10f));
                            // Whirlwind against everything within range
                            if (Player.PrimaryResource >= 10 && CombatBase.CanCast(SNOPower.Barbarian_Whirlwind) [COLOR="#FF0000"]&& NavHelper.CanRayCast(CurrentTarget.Position)[/COLOR] && wwToItem &&
                                (TargetUtil.AnyMobsInRange(20, false) || Sets.BulKathossOath.IsFullyEquipped) && !IsWaitingForSpecial)
                            {
                                Skills.Barbarian.Whirlwind.Cast(CurrentDestination);
                                LastMoveToTarget = CurrentDestination;
                                return GetRunStatus(RunStatus.Running, "Whirlwind");
                            }
                        }

xzjv · May 17, 2015

austin909 said:
About DemonHunter.
It looks like Player.SecondaryResourceMax is always 30, even passive skills or equipment to increase the maximum value of Discipline.
This problem will make Player.SecondaryResourcePct and Player.SecondaryResourceMissing cannot work well.

Through debug code, I found the problem seems to be in _me.MaxSecondaryResource.It always return 30.
_me is DiaActivePlayer,so it looks like a DB issue.

Update: DiaActivePlayer.MaxPrimaryResource have same issue.It is always return 125.

yes this has not worked for a very long time; i reported it to nesox about a year ago, not fixed.

xzjv · May 17, 2015

xzjv said:
yes this has not worked for a very long time; i reported it to nesox about a year ago, not fixed.

i spent some time on this and found a way to get the real max for primary/secondary.

https://www.assembla.com/code/unifiedtrinity/git/commit/dd138b266bde0ddb75685b31e0319bd4cb0ec290

munkafan · May 17, 2015

Anyone else having trouble with the new updates in Rifts that it sometimes just ignores elites and rift boss to kill trash or exploring the map instead?

Arotished · May 17, 2015

Why does the WD need to be close to the mobs even if you set 10, 15, 20 or even 30 kite range?

austin909 · May 17, 2015

xzjv said:
i spent some time on this and found a way to get the real max for primary/secondary.

https://www.assembla.com/code/unifiedtrinity/git/commit/dd138b266bde0ddb75685b31e0319bd4cb0ec290

Thanks!

Trinity 2.9.1 and QuestTools 3.4.19

Member

New Member

Member

Community Developer

Member

Community Developer

Member

Community Developer

New Member

Member

New Member

New Member

New Member

Member

New Member

Community Developer

Community Developer

Member

New Member

Member