I usually try to abide by the DRY principle. And a lot of spells do have mechanics that require e.g. a poisoned status, which is provided by a lot of debuffs. If there was a way to check them through a single condition, we would only have to change it inside that condition if another poisonous ability were to be added to the game. Your cannotSwap argument for isStunned does not seem to have much merit either, unless there is a way to force a swap inside a tactic. But we don't seem to have a functionality like that, or am I wrong? I can't think of another situation where I would need different definitions of a status change, but that certainly doesn't mean there is any. You are the experienced one here, when it comes to pet battles.
your famEnemy() check needs to rather look like this:
Code:
new AandC( "Rot", () => (famEnemy ("critter") || famEnemy("aquatic")) && ! debuff("Undead") ), // Slot 3, Rot = 476 Debuff Undead = ???
But is there really a debuff "Undead", wouldn't you have to check for the debuff("Rot")?
You make a good point with having a easy to use function call for pet states and weather, it would be easier to embed or remember that way.
It doesn't really change too much, because each combat variable could just scan through a case structure of the aura numbers and set up the appropriate state.
Ie. Case (debufflist) : {822:498: return "stunned" ; 435: return "chilled" ; etc. } ;
sic. Case loops tend to be easier to read vertically than if/else, and requires integers, or it really doesn't work.
Thinking about it, it could be justified, it could also act as the translation matrix for ru/gb/ch users, ie instead of reading the real name of the pet, aura or ability name, it would force a translation to English for the logic and logging. So, a long, long list of about 700 pets, 541 abilities and auras, and, it doesn't change the existing code library too much by rewriting all of the pet names.
Case structures also allow recording of failures for debugging if there's unknown auras or pets or abilities. So that makes it easier to record to a separate log file ( to trigger a logging exception debug, ie printing out the LUA, pet names, abilities, etc. When something inevitably screws up. )
As for rot, it changes the "pet armour", ie the family passive ability for each family, to undead.
Sometimes, when a pet is attacked by a direct spell, it will pick up the family ability, ie aquatic, critter, mechanical, etc. that it belongs to. And sometimes it can discard the ability /aura. Because of the strong /weak family balance, some talents hit harder or heal for more, etc.
It's one of the unique abilities because it changes that aura. Essentially, if you have a pet that can block 50% or do 125% more damage when hitting back, rot will cause your primary attack to do regular damage instead of nerfed damage. It could be chained to achieve something awesome in the case of fable pets or breaking the strength of certain OP trainers, it's usually not.
.
