Is there a better wait to control how much CPU is being used?

[JoeBobJr]

When I use a while loop to check buffs its using a lot of cpu with this while loop. Is there something I am doing wrong or a better way to do this so my cpu isn't getting maxed out?

public void PluginRun()
       {         
           while (true)
           {
               if (isAlive() && !isMounted())
               {
                if (skillCooldown("Refreshment") == 0 && buffTime("Refreshment (Rank 4)") <= 2)
                // Casting "Refreshment"
                {
                    UseSkill("Refreshment", true);
                    Log("Used: Refreshment");
                }
                if  (skillCooldown("Toughen") == 0 && buffTime("Toughened (Rank 3)") <= 2)
                // Casting "Toughen"
                {
                    UseSkill("Toughen", true);
                    Log("Used: Toughen");
                }
                if (buffTime("Magic Defense Boost") <= 2)
                // Casting "Purge"
                {
                    UseSkill("Purge", true);
                    Log("Used: Purge");
               }
           }

       }

 

[Iso]

How about delay in the loop?

 

[JoeBobJr]

How about delay in the loop?

I've tried to add Thread.Sleep(1000) to the end of the code before it loops again still uses a lot of cpu didn't make any difference.

 

[Mordark]

you're missing:

while (me.isCasting || me.isGlobalCooldown)
{
Thread.Sleep(50);
}

 

[Mordark]

Rewritten it should look similar to this:

        public void UseSkillAndWait(string skillName, bool selfTarget = false)
        {
            while (me.isCasting || me.isGlobalCooldown)
            {
                Thread.Sleep(50);
            }   
            
            if (!UseSkill(skillName, false, selfTarget))
            {
                while (me.isCasting || me.isGlobalCooldown)
                {
                    Thread.Sleep(50);
                }
            }
        }


public void PluginRun()
       {         
           while (true)
           {
               if (isAlive() && !isMounted())
               {
                if (skillCooldown("Refreshment") == 0 && buffTime("Refreshment (Rank 4)") <= 2)
                // Casting "Refreshment"
                {
                    UseSkillAndWait("Refreshment", true);
                    Log("Used: Refreshment");
                }
                if  (skillCooldown("Toughen") == 0 && buffTime("Toughened (Rank 3)") <= 2)
                // Casting "Toughen"
                {
                    UseSkillAndWait("Toughen", true);
                    Log("Used: Toughen");
                }
                if (buffTime("Magic Defense Boost") <= 2)
                // Casting "Purge"
                {
                    UseSkillAndWait("Purge", true);
                    Log("Used: Purge");
               }
           }

       }

Alternative:

public void PluginRun()
       {         
           while (true)
           {
               if (isAlive() && !isMounted())
               {
                if(buffTime("Refreshment (Rank 4)") <= 2 || buffTime("Toughened (Rank 3)") <= 2 || buffTime("Magic Defense Boost") <= 2)
                 {
                 if (skillCooldown("Refreshment") == 0 && buffTime("Refreshment (Rank 4)") <= 2)
                 // Casting "Refreshment"
                 {
                     UseSkill("Refreshment", true);
                     Log("Used: Refreshment");
                 }
                 if  (skillCooldown("Toughen") == 0 && buffTime("Toughened (Rank 3)") <= 2)
                 // Casting "Toughen"
                 {
                     UseSkill("Toughen", true);
                     Log("Used: Toughen");
                 }
                 if (buffTime("Magic Defense Boost") <= 2)
                 // Casting "Purge"
                 {
                     UseSkill("Purge", true);
                     Log("Used: Purge");
                 }
               }
               else
                 Thread.Sleep(50);
          }
        }

 

[JoeBobJr]

Rewritten it should look similar to this:

        public void UseSkillAndWait(string skillName, bool selfTarget = false)
        {
            while (me.isCasting || me.isGlobalCooldown)
            {
                Thread.Sleep(50);
            }   
            
            if (!UseSkill(skillName, false, selfTarget))
            {
                while (me.isCasting || me.isGlobalCooldown)
                {
                    Thread.Sleep(50);
                }
            }
        }


public void PluginRun()
       {         
           while (true)
           {
               if (isAlive() && !isMounted())
               {
                if (skillCooldown("Refreshment") == 0 && buffTime("Refreshment (Rank 4)") <= 2)
                // Casting "Refreshment"
                {
                    UseSkillAndWait("Refreshment", true);
                    Log("Used: Refreshment");
                }
                if  (skillCooldown("Toughen") == 0 && buffTime("Toughened (Rank 3)") <= 2)
                // Casting "Toughen"
                {
                    UseSkillAndWait("Toughen", true);
                    Log("Used: Toughen");
                }
                if (buffTime("Magic Defense Boost") <= 2)
                // Casting "Purge"
                {
                    UseSkillAndWait("Purge", true);
                    Log("Used: Purge");
               }
           }

       }

Alternative:

public void PluginRun()
       {         
           while (true)
           {
               if (isAlive() && !isMounted())
               {
                if(buffTime("Refreshment (Rank 4)") <= 2 || buffTime("Toughened (Rank 3)") <= 2 || buffTime("Magic Defense Boost") <= 2)
                 {
                 if (skillCooldown("Refreshment") == 0 && buffTime("Refreshment (Rank 4)") <= 2)
                 // Casting "Refreshment"
                 {
                     UseSkill("Refreshment", true);
                     Log("Used: Refreshment");
                 }
                 if  (skillCooldown("Toughen") == 0 && buffTime("Toughened (Rank 3)") <= 2)
                 // Casting "Toughen"
                 {
                     UseSkill("Toughen", true);
                     Log("Used: Toughen");
                 }
                 if (buffTime("Magic Defense Boost") <= 2)
                 // Casting "Purge"
                 {
                     UseSkill("Purge", true);
                     Log("Used: Purge");
                 }
               }
               else
                 Thread.Sleep(50);
          }
        }

Both of those seem to be doing about the same thing. When I have two clients running my 4 cores stay around 60% cpu useage even while running Questing plugin. As soon as I start the Buff plugin all cpus go up to 100% and bounce between 95% and 100% cpu. As soon as I stop the plugin back down to 60% so for some reason this tiny plugin is using 40% cpu from all 4 cores that's way too much. It makes the clients have a lot of cpu lag and sometimes they crash out.

 

[Iso]

You are not the only one then. My plugins are doing the same. And they have buffs in loop too, with reasonable delays...
https://www.thebuddyforum.com/archebuddy-forum/archebuddy-support/186863-ab-cpu-usage.html

We need help here.