Performance fix for HandleTarget

[xrinity]

TL;DR: If you want don't want diablo freezing up when item drop and have red lines in your log about performance, disable Log Dropped Items in Trinity Settings -> Advanced

This is for the people who are experiencing lag when items drop and have something like this in their log:

[Trinity][Performance] Execution of the block RefreshDiaObject.MainObjectType took 1172.63ms.
[Trinity][Performance] Execution of the block CacheManagement.RefreshCacheMainLoop took 1178.38ms.
[Trinity][Performance] Execution of the block RefreshDiaObjectCache.UpdateBlock took 1182.94ms.
[Trinity][Performance] Execution of the block RefreshDiaObjectCache took 1184.73ms.
[Trinity][Performance] Execution of the block HandleTarget.CheckForNewTarget took 1189.44ms.
[Trinity][Performance] Execution of the block HandleTarget took 1238.55ms.
[Trinity][Performance] Execution of the block RefreshDiaObject.MainObjectType took 1170.63ms.
[Trinity][Performance] Execution of the block CacheManagement.RefreshCacheMainLoop took 1310.47ms.
[Trinity][Performance] Execution of the block RefreshDiaObjectCache.UpdateBlock took 1314.88ms.
[Trinity][Performance] Execution of the block RefreshDiaObjectCache took 2061.36ms.
[Trinity][Performance] Execution of the block HandleTarget.CheckForNewTarget took 2061.85ms.
[Trinity][Performance] Execution of the block HandleTarget took 2438.94ms.

After profiling and narrowing down what is causing this, the culprit was found to be LogDroppedItem. It opens and writes to the file each time when an item drops and performance deteriorates as your log file gets larger.

A work around for this is to disable Log Dropped Items in Trinity -> Settings -> Advanced, under TrinityLogs Directory.
After this, there should be no lag spikes freezing up diablo when items drop

If you really want to log the items that are dropped, I can release code to write asynchronously to the log in a separate thread

 

[rrrix]

Good idea on the async log code.

You must have a huge file or very slow I/O

 

[xrinity]

Good idea on the async log code.

You must have a huge file or very slow I/O

2.5MB file? My friend had the same problem too, so that's why I decided to look into it. I should get a SSD soon

 

[jiznadj]

I have that logging disabled and I still get those red errors. Must be something else.

 

[xrinity]

Depends what the red errors say