What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

[Item Rules] ShutteR's Updated Item Rules for RoS

What's the point exactly of adding the specific name plan after CraftingPlan?

Why not just use
[Type] == "CraftingPlan"

Instead of let's say
[Type] == "CraftingPlan" && [NAME] == "Plan: Wall of Man"
 
What's the point exactly of adding the specific name plan after CraftingPlan?

Why not just use
[Type] == "CraftingPlan"

Instead of let's say
[Type] == "CraftingPlan" && [NAME] == "Plan: Wall of Man"
Because better safe than sorry. And people can simply comment the top one then choose any plans they want to pick up or not. Any more questions? :P
 
Last edited:
I get the occasional rare, but I'll look into this man. Is anyone else having this problem?

Would a syntax error cause the whole item rules file to not work?

Nevermind, i found the problem. I added my custom rules at the end, which wouldnt work cause of the TRASH tags before.
Still getting very few rares, but i guess its just bad luck.

And i think syntax errors only affect the line they are in, not sure though.
 
I tried this loot rules on clean DB Beta with latest trinity, but doesn't work.

[Trinity] Exception in ReloadScriptRulesCommand: System.ArgumentException: Delegate to an instance method cannot have null 'this'.
at System.MulticastDelegate.CtorClosed(Object target, IntPtr methodPtr)
at Trinity.UIComponents.ConfigViewModel.<InitializeResetCommand>b__26(Object parameter) in d:\Games\Diablo III DB CLEAN\Plugins\Trinity\UI\UIComponents\ConfigViewModel.cs:line 779
 
Because better safe than sorry. And people can simply comment the top one then choose any plans they want to pick up or not. Any more questions? :P

More like a comment to that really, I'm aiming for the cleanest ruleset possible so I'm just asking questions to learn. Anyway once you learn a plan it wont drop anymore so again there wouldn't be any point to have specifics. I haven't found a new plan yet but I'm going to try if it picks up plans using only "[Type] == "CraftingPlan""

And sebflex, I know. I'm not attacking the man or anything. Again, I'm here to learn and maybe even be of use at some point in the near future.
 
How can I make it pick up Arcane Dust? That's the only problem I have with it.
 
Anyone else constantly stashing 1-handed crossbows? I've tried everything to just sell them, but haven't been able to figure it out.
 
Trinity is really messing this up for a lot of people :/ Luckily my bot isn't stashing bad rares, but it hasn't gotten one in a while. I'd really like to know if the chances of these near-perfect rares are that rare, or if it's a bug in the rule-matching.
 
Under Rare.dis does Two-handed cover all two-handed weapons like bows?
 
EDIT: Derp. I think I solved my problem. The salvagesell.dis is blank so it just stashes everything instead. You have to add rules in salvagesell.dis to sell/salvage rares that don't match the keep rules.
 
Last edited:
what rule i sell and salvage all my rare without touch the file you talking about
but since last update buddy pick up and sell all blue :p
 
what rule i sell and salvage all my rare without touch the file you talking about
but since last update buddy pick up and sell all blue :p

Well then there's still something wrong.

I am getting a lot of IR2 bugs on every rare.

Code:
.Hero;LOG;NULL;

That is basically it, it says NULL for every single rare item..

EDIT: well after some digging in the forums, NULL apparently means there is no item rule for the item in question. Which is wrong, because a lot of the items clearly match a rule in the item rules. For some reason it is ignoring that!
 
Last edited:
Well then there's still something wrong.

I am getting a lot of IR2 bugs on every rare.

Code:
.Hero;LOG;NULL;

That is basically it, it says NULL for every single rare item..

EDIT: well after some digging in the forums, NULL apparently means there is no item rule for the item in question. Which is wrong, because a lot of the items clearly match a rule in the item rules. For some reason it is ignoring that!
Well this is pretty damn annoying :/ guess we just need to wait for an update...
 
It sure looks like it's a Trinity item rules bug. I get NULL for every single item that doesn't match a KEEP rule.

Can anyone else confirm the NULL bug? Check your Demonbuddy\TrinityLogs folder and open IR2Bugs.log. You should see .Hero;LOG;NULL; for every item.

EDIT1: if you don't have an IR2Bugs.log:

Go to Plugins -> Trinity -> Click the config button
Go to Advanced tab -> Check ItemRules logs box
Also go to Items tab -> ItemRules tab -> Check Debug ItemRules box

This should create an IR2Bugs.log in your TrinityLogs folder for any item rule bugs.

EDIT2: after a bit more testing, it seems that Trinity will apply the keep rules just fine. It is the TRASH rules that are being ignored. I even tested this with Trinity's OWN item rules, soft/hard. And it does not recognize any of the TRASH rules.

EDIT3: Yep, definitely something messed up between Trinity .15 and Trinity .17. I just downloaded Trinity .15 and I no longer get the NULL error. It correctly trashes all rares that don't match the item rules.
 
Last edited:
I got couple of rares.
It works but as I said earlier, the rules are kind of strict.
If you've done math in grade 9, then you can edit the xml easily per your needs.

As for the trinity, stay with .15

You can control whether to salvage or to sell within trinity (not code) salvage option.

If you tick salvage rares, then it will salvage rares that do not satisfy the rules set by the OP.
If it does, it will be stashed.

If you don't tick salvage rares, then it will sell rares that do not satisfy the rules set by the op.
If it does, it will be stashed.

same goes for blues.
 
Getting this error when loading these rules

DEBUG [Trinity] Exception in ReloadScriptRulesCommand: System.ArgumentException: Delegate to an instance method cannot have null 'this'.
at System.MulticastDelegate.CtorClosed(Object target, IntPtr methodPtr)
at Trinity.UIComponents.ConfigViewModel.<InitializeResetCommand>b__26(Object parameter) in c:\Demonbuddy\Plugins\Trinity\UI\UIComponents\ConfigViewModel.cs:line 779
Anyone else constantly stashing 1-handed crossbows? I've tried everything to just sell them, but haven't been able to figure it out.
Yes me to, but i also have problem with follower tokens and 2h stafs. :(
 
Back
Top