While InCombat | WithinFate, Alwayssucceeds, and Disable

[newb23]

Okay, so for added compatibility with other plugins/bot bases/etc, I am attempting to add lines to my code that check for FATE participation and combat status.

I have figured out how to verify that I am in fact in fates/combat, but I do not know how to generate a list of current mobs in my enmity list to target and kill for just incombat, nor do I know what I would use to set fatemanager to complete the FATE we are currently in before running my plugin.

Also, I've run into an issue with the plugin AutoFateLeveler. As it stands, that plugin will try to move me back to it's map area before RetBot is able to complete it's routine. Would alwayssucceeds in my code be able to quell that? And if so, would that potentially break anything so long as I give control back to the other plugins/botbase at the end of my routine, as it currently does?

Finally, I do not believe that I have properly disabled the plugin once someone un-checks the plugin from the selection list, and/or presses the stop button. Is there anything glaringly obvious that I missed to completely stop/disable when people try to stop/disable it?

Thank you once again for your help!

I have attached my plugin as it stands, with the portions in question being lines 115 - 134 in RetBot, and lines 112 - 126 in Movement. (for FATE participation and combat status).

 

[Neverdyne]

As far as checks go, this is what Agil checks to know if it can do its thing or not. So far it has worked for me. I'm guessing what your plugin does is similar to Agil's mender repair run. You don't have to "force" FateBot to finish the fate, you just have to let it finish, and THEN do your thing.

EDIT: So from what I saw in your code, you know you need to do your thing whenever you receive the appropriate message. A quick fix would be to make that message always set your RetBotLoop flag to 1 regardless of the circumstances. Then on the RetarinerMove() method's check you also include the check I posted below. So if either RetBotLoop is 0 or !CanStartRepair then exit, otherwise do the thing. You should not try to "force" the bot to finish something, rather just wait patiently until it's free, like in between fates, in between gathering nodes, in between mobs, etc.

 

[mastahg]

As far as checks go, this is what Agil checks to know if it can do its thing or not. So far it has worked for me. I'm guessing what your plugin does is similar to Agil's mender repair run. You don't have to "force" FateBot to finish the fate, you just have to let it finish, and THEN do your thing.

EDIT: So from what I saw in your code, you know you need to do your thing whenever you receive the appropriate message. A quick fix would be to make that message always set your RetBotLoop flag to 1 regardless of the circumstances. Then on the RetarinerMove() method's check you also include the check I posted below. So if either RetBotLoop is 0 or !CanStartRepair then exit, otherwise do the thing. You should not try to "force" the bot to finish something, rather just wait patiently until it's free, like in between fates, in between gathering nodes, in between mobs, etc.

Please use botbase englishname

 

[Neverdyne]

Didn't even think about that, thanks.

 

[newb23]

Thank you for the replies. I'll look in to how to get my plugin to hold off, rather than just tell it to finish. My only concern over that, is I don't know how RB holds information in cache, so, when the message received executes and cannot complete right away, how I can make sure that it does later on, which is what I assume you suggested adding the retbotloop for.

I'll take a looksee after work.

 

[newb23]

Okay, I was able to get everything added and it looks to be working as intended. So, the only other issue that I am running into currently is the FateAutoLeveler plugin.

Am I correct in thinking that there is a way to out my hook at a priority without having to change FAL's code, much like it takes control from FATE/Order bot? Or is there really any way to run both plugins without completely re-writing one or the other?

 

[mastahg]

pretty sure fal just runs it code in the onpulse so theres nothing you can do except check if the plugin is enabled, then disable it while your doing stuff then renable it.

 

[newb23]

Yeah, that's what I was afraid of. Thank you for the insight. I don't like the idea of straight up disabling someone elses plugin, but, I'll look into my options this weekend. Thank you!