Vendor Bug Solution

[jnp]

Hey,

So you know how a lot of people are complaining they get hung up on ForceVendor. I think I've located the issue.

public static RunStatus SellAllItems()
{
    TorPlayer me = BuddyTor.Me;
    TorContainer<TorItem> inventoryEquipment = me.InventoryEquipment;
    IEnumerator<TorItem> enumerator = inventoryEquipment.GetEnumerator();
    using (enumerator)
    {
        while (V_1.MoveNext())
        {
            TorItem current = V_1.Current;
            if (GlobalSettings.Instance.Protected.Items.Contains(current.Name) || current.Quality > CharacterSettings.Instance.SellItemAtLeastQuality)
            {
                continue;
            }
            current.Use();
        }
    }
    BrainBehavior.ForcedVendor = false;
    GameEvents.u0001();
    return RunStatus.Success;
}

From what I can tell, we are getting stuck in the vendor loop selling items. The issue is there are items in the game that are of low enough quality to be sold, not in the protected.xml list but yet the vendor will not allow you to sell.

I think some examples of this are like the rep items. There are green level rep items and the vendor won't accept them. There are probably other examples.

We have 2 solutions:
1) Comb SWTOR for a list of all items that can't be sold to the vendor and include them in the Protected.xml
2) Beg the dev to put a time out in the logic so that if it can't sell an item in a few seconds it will still continue the while loop.

 

[Jests]

Nice find, but I'm not positive that's the whole story. I get stuck sometimes without items that I would think would be questionable. I'll definitely watch for this closer now, though. I haven't run into this problem as much lately, but if I find it again I'll post my findings. Thanks for this!