UseOnce counts not being reset on <LeaveGame> any more

[cfong]

TrinityUseOnce doesn't seem to get reset on LeaveGame any more... any idea what is going on?

edit: weird.

cleared out a bunch of stuff, now it works again.

 

[Pkt]

Yep, I'm using a profile with a lot of useonces (~80 or so), and I can confirm it's been failing randomly for weeks.

 

[cfong]

It looks like db stops calling GilesTrinityOnJoinGame() when it starts a new game.

 

[cfong]

You can see here trinity is never called for anything:

[23:08:11.040 D] [GilesTrinity] We still run smoothly
[23:08:11.047 D] Parsing parent type table: 167097204
[23:08:11.108 D] Replaced hook [ProfileOrderBehavior_Hook] d3c26f3d-a89e-45d9-a86e-85820d9400b0
[23:08:11.213 D] Replaced hook [ProfileOrderBehavior_Hook] 53a38788-32f7-462e-a091-f20f6476fbf7
[23:08:11.217 N] Done. Leaving game.
[23:08:11.256 D] Replaced hook [ProfileOrderBehavior_Hook] e41017f4-15c4-4906-a547-7dd0f4906c24
[23:08:11.259 N] Leaving game, reason: Profile completed
[23:08:11.259 D] Navigator.Clear
[23:08:11.259 N] Profile completed
[23:08:11.259 N] Number of games completed:6
[23:08:11.269 N] Last run acquired 0 gold.
[23:08:16.304 N] Waiting 6.3 seconds before next game...
[23:08:22.644 N] Creating new game, Params: <Act:A3 Difficulty:Inferno Quest:101758 QuestStep:29 ResumeFromSave:False IsPrivate:True Handicap:5>
[23:08:26.913 N] GameChanged. Clearing actors
[23:08:27.023 D] Joined a game!
[23:08:27.026 N] ========== Grid segmentation resetting!!! ============
[23:08:27.026 N] ProfileOrderManager.OnGameJoined, Reloading profile.
[23:08:27.357 N] Loaded profile A3 v2.1
[23:08:27.411 N] ToggleTargeting, new values: Looting:True LootRadius:80 Combat:True KillRadius:50
[23:08:27.412 D] Replaced hook [ProfileOrderBehavior_Hook] 22e6bff9-0cb8-4c62-b280-0551b71f31b9
[23:08:27.419 D] Parsing parent type table: 167097204
[23:08:27.477 D] Replaced hook [ProfileOrderBehavior_Hook] 4bb07b0d-910f-4e15-b341-2165bff16f8a
[23:08:27.584 D] Replaced hook [ProfileOrderBehavior_Hook] 72d0e262-826e-4ae9-8c6a-1ba2b4c2fc0d
[23:08:27.587 N] Done. Leaving game.
[23:08:27.628 D] Replaced hook [ProfileOrderBehavior_Hook] 98a68816-90e1-47a3-b39e-d44ce1aa82d0
[23:08:27.629 N] Leaving game, reason: Profile completed
[23:08:27.629 D] Navigator.Clear
[23:08:27.629 N] Profile completed
[23:08:27.629 N] Number of games completed:7
[23:08:27.638 N] Last run acquired 0 gold.
[23:08:32.672 N] Waiting 8.1 seconds before next game...
[23:08:40.790 N] Creating new game, Params: <Act:A3 Difficulty:Inferno Quest:101758 QuestStep:29 ResumeFromSave:False IsPrivate:True Handicap:5>
[23:08:44.858 N] GameChanged. Clearing actors
[23:08:44.968 D] Joined a game!

 

[cfong]

Also, jubisman: can you PLEASE leave your tab stops set to 8, not 4.

Formatting is getting out of control; you have a mix of spaces and tabs, and depending on how you have your editor set up, you see different things.

 

[cfong]

this is bad too: the constructor for healthlevels[] doesn't always generate a healthlevel that has the right amount of items. this is partly giles's fault for not doing a very good job with array size bounds checking.

[00:01:07.755 D] Trinity Initialization, settings location=C:\Games\Demonbuddy\Settings\GilesTrinity.cfg
[00:01:08.185 D] Exception while enabling plugin GilesTrinity: System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at GilesTrinity.GilesTrinity.LoadConfiguration()
   at GilesTrinity.GilesTrinity.OnEnabled()
   at Zeta.Common.Plugins.PluginContainer.set_Enabled(Boolean value)

so if you have an old config file, you're screwed. The array isn't big enough and you get a fault while trying to access the non-existent index *and a large proportion of giles' initialization code is NEVER CALLED*

again, this isn't your fault; giles did a terrible job here.

fix:

http://www.thebuddyforum.com/demonb...ns-unnoficial-updates-file-52.html#post875922