[Suggestion] Cap "Always kill when combined rift value" at missing progress

[Karls]

I don't know if it's even possible, when I had a quick look at DB API, I couldn't seem to find anything related to rift progress % but I also don't have much experience with that one so I could have easily missed it.

I "often" see the bot at 98-99% completion and skipping through small trash pack because of general settings while one of these could have bumped it to 100%. I haven't seen it fail a rift because of this yet, so it's certainly not more than a minor issue, but if it's possible to do it it would be a nice optimisation of rift logic.

 

[jubisman]

I like this idea. I'll add to our feature request list and talk to xzjv about this. Thanks .

 

[xzjv]

I went and found/wrapped the memory for current rift % for this. How would the feature work? kill everything when greater than x%?

 

[misosozi]

Maybe another slider in trinity for this condition, like "minimum trash pack size when x% of progress bar is reached"?

 

[Karls]

I went and found/wrapped the memory for current rift % for this. How would the feature work? kill everything when greater than x%?

I think so, and still ignore elites/high HP mobs (for counting when to start killing smaller than usual packs) if they're ignored in settings.

The only downside I can think of is that killing a bigger pack could be faster than a smaller one, but the bot isn't grouping mobs (or pushing the top of the leaderboard when trash HP becomes that much of an issue) so maybe nothing to miss there?