ScriptManager.GetCondition is hanging

[iyake]

Tried this in reborn console (also hanging in a compiled botbase):

ScriptManager.GetCondition("False");

 

[Cloud30000]

You are checking a string; does GetCondition allow a bool?

 

[mastahg]

Not sure what your trying to do but the ScriptManager.GetCondition returns a func<bool> so calling it like that will do nothing. Also I get the feeling that that class should probally be internal as it was something from our bot toolkit.

 

[iyake]

The update today seems to have resolved it. Here's what I was trying to do:

var condition = "Core.Player.CurrentGPPercent > 90.0";
if (ScriptManager.GetCondition(condition))()) {
    ...
}

where condition would be user supplied.

If GetCondition isn't supposed to be exposed, is there another way short of parsing the string to do it?

 

[mastahg]

What are you doing that requires you to parse a string?

 

[iyake]

a fish tag that uses patience when a condition is true, specifically

IsTimeBetween(8,12) and Core.Player.CurrentGPPercent > 90.0

but it's different for each fish -- some might have weather instead of a time frame for example.

 

[mastahg]

Yea that's probably one of the better ways to handle that. I was thinking about adding something similar for gatheringskills.

If you want to test it in the console you'll need to start+stop orderbot at least once so that itll initialize the scriptmananger otherwise you'll get the lockup as its waiting for initialization.

I had recently started on my own version of a fishing tag for orderbot as I was displeased with how predictable fishbot's behavior is. I've only got the movement logic completed as I wanted to make it much more random in its behavior ie randomized facing angles within a given range, and not standing in the exact same spot each time. Since im working on opensourcing all the included orderbot tags ill hold off on doing anymore work on my version since it seems your a good bit further ahead then we can see about including yours with the distribution of rb.

 

[iyake]

Oh, that explains why it was locking up in a botbase too. Is there a way to manually initialize it for use in a botbase? I see an exposed init method.

 

[mastahg]

ConditionParser.Initalize();

 

[y2krazy]

Not sure if having 4+ people (mastahg, iyake, ExMatt, oruna) working on a Fish tag is the most efficient way of getting things done, but here's ExMatt's latest Fish tag if either or both of you want to reach out to him for collaboration (download link found in the link to his post below):

Cleaned up code to make it more maintainable/readable.

It will use patience at GP >= 600 or GPPercent == 100. This will allow you to use it if you have more than 470 but less than 600 GP.

Added mooch condition since Warmwater Bichir seems to be the only fish you can mooch from Blueclaw Shrimp and it is only available for catch between 21:00-3:00 or so.

Waiting to see if Mastahg will add the collectable item name to the SelectYesNo window like he did for the collectable value.

Reference: https://www.thebuddyforum.com/rebornbuddy-forum/rebornbuddy-profiles/207271-fishing-ultimate-fishing-profiles-leveling-farming-grinding-15.html#post2007254