Questtools fix for "No valid gem found--Leaving game" problem

[mccrimson]

This is happening because questools will leave game as long as grift lvl-gem lvl <=-7, while actually it should be <=-15.
Change the following code in \Plugins\QuestTools\ProfileTags\CompleteGreaterRiftTag.cs

public static Func<ACDItem, float> GetUpgradeChance = gem =>
{
var lootRunLevel = ZetaDia.Actors.Me.InTieredLootRunLevel;
var delta = lootRunLevel - gem.JewelRank;

if (delta >= 10) return 1f;
if (delta <= -7) return 0f; //Diablo3 disables upgrades for -15 levels difference
//if (gem.JewelRank >= 25 && delta < 0) // Gems over 25 cannot be upgraded if the gem level is less than the rift level
// return 0f;

switch (delta)
{
case 9: return 0.9f;
case 8: return 0.8f;
case 7: return 0.7f;
case 6: return 0.6f;
case 5: return 0.6f;
case 4: return 0.6f;
case 3: return 0.6f;
case 2: return 0.6f;
case 1: return 0.6f;
case 0: return 0.6f;
case -1: return 0.3f;
case -2: return 0.15f;
case -3: return 0.08f;
case -4: return 0.04f;
case -5: return 0.02f;
case -6: return 0.01f;
default: return 0f;
}
};

to the following:

public static Func<ACDItem, float> GetUpgradeChance = gem =>
{
var lootRunLevel = ZetaDia.Actors.Me.InTieredLootRunLevel;
var delta = lootRunLevel - gem.JewelRank;

if (delta >= 10) return 1f;
if (delta <= -15) return 0f; //Diablo3 disables upgrades for -15 levels difference
//if (gem.JewelRank >= 25 && delta < 0) // Gems over 25 cannot be upgraded if the gem level is less than the rift level
// return 0f;

switch (delta)
{
case 9: return 0.9f;
case 8: return 0.8f;
case 7: return 0.7f;
case 6: return 0.6f;
case 5: return 0.6f;
case 4: return 0.6f;
case 3: return 0.6f;
case 2: return 0.6f;
case 1: return 0.6f;
case 0: return 0.6f;
case -1: return 0.3f;
case -2: return 0.15f;
case -3: return 0.08f;
case -4: return 0.04f;
case -5: return 0.02f;
case -6: return 0.01f;
case -7: return 0.01f;
case -8: return 0.01f;
case -9: return 0.01f;
case -10: return 0.01f;
case -11: return 0.01f;
case -12: return 0.01f;
case -13: return 0.01f;
case -14: return 0.01f;
default: return 0f;
}
};

Restart DB. Tested and confirmed working (DB 510, Trinity 2.4.2 & QT 3.3.2).

 

[Iop]

OMG dude! Thanks a lot! U just made my day.

 

[rrrix]

Do you have a reference of where this should be 15?

All the documentation I can find says 7.

Diablo 3 - Gem Upgrade Chance

Legendary Gems - Diablo Wiki

Legendary Gem Upgrade Odds: Interactive Tables | Diablo: IncGamers

 

[Iop]

Just play the game, yes it should be 15!

 

[mccrimson]

Do you have a reference of where this should be 15?

All the documentation I can find says 7.

Diablo 3 - Gem Upgrade Chance

Legendary Gems - Diablo Wiki

Legendary Gem Upgrade Odds: Interactive Tables | Diablo: IncGamers

Thanks for the reply, rrrix! I really appreciate your work!

Regarding your question, my guess is that in the previous patches it was 7 (and thus all info about it says 7), but in patch 2.1.2, you can easily verify in game it should be 15.

 

[elfire00]

Thank you, it works much better now.
BTW, you should add one more line "case -15: return 0.01f;" at the end. Because you can upgrade your gems with 15 levels difference. It means at rift 35, you can still upgrade your rank 50 gem to 51.

 

[dobry]

i edited it like in this thread that my bot is able to update 1%gems too but after g-rift like i was 37 and my main equipped gems are 46 he comes with error and leaves game and dont restart.

[Trinity] >> Warning - One or more of your equipped items is recorded incorrectly in Trinity; please report:
[Trinity] >> Unique_Gem_006_x1-174 Pain Enhancer ActorSNO=405794 BaseType=Misc ItemType=LegendaryGem
[Trinity] >> Unique_Gem_005_x1-179 Gem of Efficacious Toxin ActorSNO=405793 BaseType=Misc ItemType=LegendaryGem
[Trinity] >> Unique_Gem_002_x1-181 Bane of the Trapped ActorSNO=405781 BaseType=Misc ItemType=LegendaryGem
Loaded profile R-RIFT