Querying Placeables: List of Invalid Objects

[JoeBrewski]

Just renewed my keys.

Sample Code (to query for all placeables within 120 meters) - If Aevitas could take a look at it, that'd be great.

...
foreach (TorPlaceable obj in ObjectManager.GetObjects<Buddy.Swtor.Objects.TorPlaceable>().OrderBy(t => t.Distance).Where(t => t.Distance <= 12.0f))
try
{...}
...

Returns a list of objects, but each and every one is invalid ("Object reference not set to an instance of an object.") - not sure if a bad DomDef or what.

Joe

 

[aquintus]

wooooooow it's really great to see you back here joe ;-)

 

[walter]

Just renewed my keys.

Sample Code (to query for all placeables within 120 meters) - If Aevitas could take a look at it, that'd be great.

...
foreach (TorPlaceable obj in ObjectManager.GetObjects<Buddy.Swtor.Objects.TorPlaceable>().OrderBy(t => t.Distance).Where(t => t.Distance <= 12.0f))
try
{...}
...

Returns a list of objects, but each and every one is invalid ("Object reference not set to an instance of an object.") - not sure if a bad DomDef or what.

Joe

Yea myself and jnp found this out a while back. Aevitas has known this for some time. Why we wrote are own targeting provider to over come it. Last buddywing update has messed it up a bit but my current routine seems to run rather well. I talk to Aevitas on skype quite often and this issue is something that's not a simple fix. We are framelocking most of the code and it seems to help this issue. How isboxer works a lot better now. Just like we found out the getcheckhealth function is 100% related to stealthing in the game. Making the bot look for health of some one that now not around.



P.S. Nice to see you post on the forums again Joe! Welcome Back!

 

[JoeBrewski]

Thanks!

Ok, will download yours now and see how goes. Appreciate it.

Joe

 

[Aevitas]

When enumerating collections like this, lock the frame. Consider what you're actually doing there takes a bit of time, stuff could go invalid. Having said that it shouldn't be returning actual null objects though..

Got a stack trace by chance? If the ObjectManager is simply returning "null" every single time then that's bad.

 

[Giwin]

You don't have a null check inside your LINQ, i.e t => t != null

which is equal to if (t != null)

 

[JoeBrewski]

Thanks - very much appreciate it - added a framelock and now it seems alot faster and more reliable. Stack trace, I don't even have a clue on how to generate it - but will read-up on it. And Walter had mentioned framelocks as well, mybad on that and thank you Walter as well

Thanks again

Joe