What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal
RebornBuddy Forums

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

... probably some bugs in the silverfish impl.

darkfriend77

Member
Joined
Jun 14, 2011
Messages
467
... okay I refactored silverfish a little so I could debug it ...

and I found some mistakes ... maybee im wrong ... but however after those fix some strange bugs disapeared ... :-)


ex. this line should qualify ... all minions in play instead it logs at the position in the zone ... :-) should use GAME_TAG.ZONE ...
Code:
                int zp = entiti.GetTag(GAME_TAG.ZONE_POSITION);

                if (entiti.IsMinion && zp >= 1)
                {

ex. this line only works if above ... has been fixed ... otherwise ... cards in hand will be true here ... and guesss what happens when u got a charge minion in hand ^^^:-)
Code:
m.playedThisTurn = (temp == 0) ? true : false;

these are just some small stuff i found when playing with silverfish a little ...
 

Attachments

  • 2016-03-08 (2).png
    2016-03-08 (2).png
    194.7 KB · Views: 181
Thanks.
But you pay your attention to only a small part of the code.
I will write a little bit more - maybe it will help you to understand how it works.
This block of code has to identify the minions on the Battlefield.
It makes no sense to use GAME_TAG.ZONE, because:
Code:
List<HSCard> list = TritonHs.GetCards([U][COLOR="#FF0000"]CardZone.Battlefield[/COLOR][/U], bool);
foreach (HSCard entiti in list)
{
    int zp = entiti.GetTag(GAME_TAG.ZONE_POSITION);


I do not know what you're doing with the SF on your PC, but I would recommend you pay attention to the line:
Code:
Problem is detected: undefined Secret class ...
This means that you get a distorted information from the core.
This can cause a "strange" behavior of the cards and minions.

ps: you can find all information about the state of the field in a file UILogg_***.txt
 
yep .. thx ... i probably missed the TritonHs.GetCards(CardZone.Battlefield, bool); ... when moving away from TritonHs for populating silverfish ...

and then later when I fixed it ... I thought it was wrong in the hearthbuddy source ...

the secret stuff you mentioned ... is because I changed some stuff in the secret recognition ... and will be fixed as soon as a implement the new system :-)
 
Back
Top