Orderbot Gather tag ItemNames element issue

[mistahmikey]

The algorithm used by RB to match the names provided in the ItemNames element is not taking the length of the item name into account when matching. This may be the intended behavior, but it prevents the reliable collection of names that happen to be a prefix of a longer name. For example, in the Dravanian Forelands, the Level 55 Mature Tree nodes have a hidden item, Dark Chestnut. However, the nodes also routinely contain Dark Chestnut Log and Dark Chestnut Branch items. If you list the item names as follows:

			<ItemNames>
				<ItemName>Dark Chestnut</ItemName>
				<ItemName>Dark Chestnut Log</ItemName>
			</ItemNames>

what happens is when the Dark Chestnut is in the last slot displayed in the logging window, it gets gathered. If it appears anywhere else, the Dark Chestnut Log gets gathered.

If folks are relying on the current matching behavior, then it would be nice if you could add an attribute to ItemNames that would force exact length matching, e.g., <ItemNames ExactLength=true>. Seems like something that would be very easy to do.

 

[mastahg]

Thanks for the report. Current logic was incorrect ported over from the gatherbot. The first itemname should always be gathered if it is found. We do strict matching so it has nothing to do with it contains the string but rather was due to a fault linq query.