OldGrindBot Bug with Settings

[Tormiasz]

Hello. I was playing with my plugin and noticed a bug

if (item.LocationTopLeft.X == OldGrindBotSettings.Instance.IdScrollsCell.X && item.LocationTopLeft.Y == OldGrindBotSettings.Instance.IdScrollsCell.Y)

OldGrindBotSettings.Instance.IdScrollsCell.Y in the settings is set to 5, but item.LocationTopLeft.Y returns 4 and it's still the same item.
Same goes for X

TL;DR:
- OldGrindBotSettings.Instance.IdScrollsCell.X counts from 1 to 12,
- item.LocationTopLeft.X from 0 to 11,
- OldGrindBotSettings.Instance.IdScrollsCell.Y from 1 to 5,
- item.LocationTopLeft.Y from 0 to 4,


Maybe it's indended for average user, IDK. Confused me.






To not create second thread I'll write here. I'm seeing my bots running around Shrines very often. They want to move too close and never reaching the destination causing the Stuck Detection to trigger, wasting the map or dying if there are mobs around. Example of Shrine sent to pushedx via PM. The logs says only
"Now moving towards the Shrine ID"
"Moving towards {X, Y}. [Cansee: false | InDistance: true]

 

[pushedx]

Hello. I was playing with my plugin and noticed a bug

if (item.LocationTopLeft.X == OldGrindBotSettings.Instance.IdScrollsCell.X && item.LocationTopLeft.Y == OldGrindBotSettings.Instance.IdScrollsCell.Y)

OldGrindBotSettings.Instance.IdScrollsCell.Y in the settings is set to 5, but item.LocationTopLeft.Y returns 4 and it's still the same item.
Same goes for X

TL;DR:
- OldGrindBotSettings.Instance.IdScrollsCell.X counts from 1 to 12,
- item.LocationTopLeft.X from 0 to 11,
- OldGrindBotSettings.Instance.IdScrollsCell.Y from 1 to 5,
- item.LocationTopLeft.Y from 0 to 4,


Maybe it's indended for average user, IDK. Confused me.

It's just how the game works, so it's working as intended. OldGrindBot's code will subtract 1 where needed, and uses LocationBottomRight for 1x1 objects when working with the option itself. Non-dev users are typically used to 1 based index systems, not 0, so that's why the settings work that way.

To not create second thread I'll write here. I'm seeing my bots running around Shrines very often. They want to move too close and never reaching the destination causing the Stuck Detection to trigger, wasting the map or dying if there are mobs around. Example of Shrine sent to pushedx via PM. The logs says only
"Now moving towards the Shrine ID"
"Moving towards {X, Y}. [Cansee: false | InDistance: true]

You can try tweaking the routine's logic that you're using (either ignore more targets closer to the shrine, or ignore the skeletons themselves), but it's one of those highly situational issues that depends on your build and other logic. The default logic works most of the time in normal areas (which is what the logic was written for), so if you're running maps, you'll want to make adjustments to StuckDetection and the routine for the best results. There's no adjustments to the default code that I can make for your issue though; skeleton shrines have always been one of the tricky things to get working generically. You can find the default shrine handling logic in OldRoutine in the HandleShrines function to get started.