What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

NoobRage - Resto Shaman

Ama

Ama

New Member
Joined
Jun 6, 2011
Messages
1,171
Reaction score
33
NoobRage - Resto Shaman​

Overview
Custom Class for level 85 Restoration Shamans using LazyRaider/RaidBot.

Credits
HazzDruid
Stormchasing
HB0916H38
Singular (CanCast method)

Features
Healing

Notes
-Set focus to tank
-If you are not in group, you are tank and earth shield is on you. Don't flip out.
-Attached is compatible version of RaidBot
-CC will show up as "NoobRage - HealingCow!"
-I'm awesome

Future Plans
-Fixing Stuff

Updates
N/A

Download
NoobRage SVN

Installation
install to Custom Classes/NoobRage


I always use Lazy Raider for healing. These work with Raidbot also, but I prefer Lazy Raider for healing.

I want to improve, so please give suggestions. No flaming please.

-Ama
 

Attachments

Last edited:
I am currently trying this out in Looking for Raid on my server. Although I dont have the best gear. I will get back to this thread in about an hour once I have finished both part 1 and part 2 of LFR.


Edit ::Not sure about your settings or just becaise there are 6 healers. But Im only healing for 6k HPS on the shaman and hes in full Firelands Gear.
 
Last edited:
Those are the same settings I used. Post a log if you can.
 
Nevermind. Is it possible to remove Healing Rain and Spirit Link??

For when I do heroic Yor I need to be able to control those and such. So I need to be able to do them myself on que instead of LazyRaider doing it
 
Last edited:
They both have settings, just turn the HP to zero.
 
If you are having issue with crashes, post log.
 
Sadly each time i try using the profile it only keeps spamming my totems and depleting my mana bar that way.

I'll try to get hold of an log of it.
 
Have to ask, how come you prefer using this CC with LazyRaider over RaidBot?
 
Hiliru said:
Sadly each time i try using the profile it only keeps spamming my totems and depleting my mana bar that way.

I'll try to get hold of an log of it.
Click to expand...

Hi,

New to honorbuddy and was checking out this CC and noticed that it always drops totems as well. This is due to line 40-42 in NoobRage/Classes/Shamcow.cs :

Code: 
                if (!Me.IsMoving && Me.Combat && !(Me.HasAura("Elemental Resistance") || Me.HasAura("Mana Tide") || Me.HasAura("Sprit Link Totem"))
                    && Cast.Buff("Call of the Elements"))
                    return true;
As you can see this will continuously drop totems over and over again since it's continuously pulsing and drops anytime you're in combat and not moving(without totem cooldowns down). So basically almost the entire time you're in combat it will continue to redrop totems and waste your mana.

For now I added in a check for Wrath of Air Totem to mine to test it out since I'm always dropping this totem, but that solution won't be complete since in a raid other shamans might drop it to give me aura. I can help come up with a more complete fix when I get back from work tonight if you want. For now you can replace lines 40-42 lines with the following lines if you just want to test out the CC to see how it heals and save/close/reopen honorbuddy to check for wrath of air as well if you drop that, or just delete them to not have the bot drop your call totems:
Code: 
                if (!Me.IsMoving && Me.Combat && !(Me.HasAura("Wrath of Air Totem") || Me.HasAura("Elemental Resistance") || Me.HasAura("Mana Tide") || Me.HasAura("Sprit Link Totem"))
                    && Cast.Buff("Call of the Elements"))
                    return true;

For OP:
The CastBuff behavior in NoobRage/Helpers/CastHelpers.cs covers checking to see if the aura you're buffing is already on you, but since Call of the Elements drops 4 totems all with different auras and none called Call of the Elements, it isn't picking this up, so might be a possible place to put a check for totems behavior to use in the CC.
 
Last edited:
If they have any off those buffs, then "Cast.Buff("Call of the Elements")" should never get called. If it is, then I don't get that. I can just throw that part in brackets and it will stop that from happening. But the idea on this is check for the auras and then do Cast.Buff("Call of the Elements"), knowing that is Cast.Buff("Call of the Elements") is called it will be casted.

When I tested the current code, it did not spam. Apart from putting that part in brackets, there isn't much I can do.

No one bothered to post logs, so I dont really know what behaviour is actually happening.
 
Ama said:
If they have any off those buffs, then "Cast.Buff("Call of the Elements")" should never get called. If it is, then I don't get that. I can just throw that part in brackets and it will stop that from happening. But the idea on this is check for the auras and then do Cast.Buff("Call of the Elements"), knowing that is Cast.Buff("Call of the Elements") is called it will be casted.

When I tested the current code, it did not spam. Apart from putting that part in brackets, there isn't much I can do.

No one bothered to post logs, so I dont really know what behaviour is actually happening.
Click to expand...


If they have any of those buffs then it shouldn't be cast, yes this is true and exactly what I stated in my post. In combat, however, like I said, we only have the buffs you're checking for maybe a few seconds, the rest of the time we're in combat we shouldn't have the buffs you're checking for since they're cooldowns and not the totem auras. Hence, it will continuously drop the totems since it isn't checking to see if we have totem buffs just checking to see if we have elemental resistance, mana tide, or spirit link totem down. You have to actually check if we have a totem aura or if the totems are down.

When you checked the current code did you perhaps not test it in combat or while you were moving for most of the combat, or perhaps you had the resistance totem down? That might explain why it didn't spam for you.

Here's an example of a log from the first few seconds in combat in a 5 man when I'm not moving in combat and don't have resistance, mana tide, or spirit link totems down. Though I don't see why it's necessary when it's clearly obvious that this CC will spam totems by just looking at the code, and I've pointed out the exact line and reasoning for why, as well as a temporary fix that works and was tested:
Code: 
[7:02:05 PM:514] Spell_C::CastSpell(73680, 0, 0x6000000054BE5F2, 0) [55]
[7:02:07 PM:860] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [56]
[7:02:11 PM:293] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [57]
[7:02:12 PM:643] Spell_C::CastSpell(61295, 0, 0x6800000054CF157, 0) [58]
[7:02:14 PM:593] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [59]
[7:02:15 PM:943] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [60]
[7:02:17 PM:293] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [61]
[7:02:19 PM:461] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [62]
[7:02:19 PM:661] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [63]
[7:02:19 PM:865] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [64]
[7:02:20 PM:128] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [65]
[7:02:20 PM:403] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [66]
[7:02:20 PM:650] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [67]
[7:02:20 PM:911] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [68]
[7:02:21 PM:178] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [69]
[7:02:21 PM:436] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [70]
[7:02:21 PM:700] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [71]
[7:02:21 PM:963] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [72]
[7:02:22 PM:223] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [73]
[7:02:22 PM:482] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [74]
[7:02:22 PM:743] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [75]
[7:02:23 PM:002] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [76]
[7:02:28 PM:556] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [77]
[7:02:28 PM:806] Spell_C::CastSpell(66842, 0, 0x6800000054CF157, 0) [78]

Notice how it just keeps dropping totems exactly like the code says it will.
 
Last edited:
It isn't obvious that the CC will spam. When I throw my totems down, I get Flametongue, Stoneskin, Elemental Resistance, and Wrath of Air. When I enter combat they are all staying there.

now for the if statement...

!Me.IsMoving
If im moving, exit statement.

Me.Combat
If im not in combat, exit statement.

!(Me.HasAura("Elemental Resistance") || Me.HasAura("Mana Tide") || Me.HasAura("Sprit Link Totem"))
if I have any of these auras, exit statement.

Cast.Buff("Call of the Elements"))
All conditions were met, cast buff.

When I throw out, Mana Tide and Spirit Link are the cooldowns. Unless you throw Mana Tide out, Elemential Resistance is pretty much always there. Since Elemental Resistance is one of the checks, there should be no spamming.

Is there some sort of glyph or talent that could be affecting this?
 
Elemental Resistance isn't pretty much always there is the thing, it's only always there if you have the Healing Stream Totem Glyphed, and you have that glyphed Healing Stream Totem down. Which, in a raid would normally always be true, but not necessarily in 5 mans where you might not always have a paladin, or the shamans doing 5 mans might not even have it glyphed.
 
Okay, yes this makes sense. Thanks, change that.
 
Ama said:
Okay, yes this makes sense. Thanks, change that.
Click to expand...

Hi, I'm still at work for another hour and a half and kinda bored, so I wanted to try to figure out a way to check for totems before I got home so that I would be able to test it when I get back. Since other shamans can drop totems that give us auras too, I imagine there might be a few scenarios where this bot won't cast totems when it should, so I was looking for a way to check the totem objects not the auras.

Looking through API looks like my totems can be accessed in LocalPlayer, I'm thinking of using it like this:

Code: 
        public bool CastTotems()
        {
            return Me.Totems.Where(t => t.Unit != null).Count(t => Me.Location.Distance(t.Unit.Location) < 30f) == 0 ? true : false;
        }

That way it filters out only totems that are dropped first, and then counts how many of them are in 30 yards, which is the max range on most totems, and then returns true if totems need to be dropped and false if they don't. Then I will add CastTotems() after the mounted, combat, elemental resistance, mana tide, and spirit link checks in ShamCow.cs but before totems get dropped, just to make sure they aren't already down.

Hoping it works. I'm still pretty new here and just dl'd VS/set it up with the references to HB/tools yesterday and am not very familiar with HB's API, maybe someone else has a good idea.
 
Last edited:
You must log in or register to reply here.
Back
Top