Making SqPackArchive public instead of internal

[RedWine82]

Good morning.

The current implementation of IconImage is a rather limited implementation of Lumina. There is no way to get the HQ version of an item image and there's no way to get icons for anything else than an item. Since RB already has all the Lumina code backend, would it be possible to make SqPackArchive public instead of internal so that we can use the existing code to access the image dat files directly?

Thank you very much.

 

[mastahg]

The current implementation of IconImage is a rather limited implementation of Lumina.

This is correct

There is no way to get the HQ version of an item image and there's no way to get icons for anything else than an item.

I was unaware that HQ items weren't working, and would consider that a bug. Spell Icons are also supported (on the spelldata object), is there a particular other kind of icon that is missing?

Since RB already has all the Lumina code backend

This is incorrect, I pulled the very minimum stuff required to extract images and nothing else.

 

[RedWine82]

This is incorrect, I pulled the very minimum stuff required to extract images and nothing else.

What I meant is "has all the code to extract the images". Sorry about the confusion.

I was unaware that HQ items weren't working, and would consider that a bug.

Check the thumbnail attached. You will see that the code you have ported from GetIcon is only using the iconId.

is there a particular other kind of icon that is missing?

Being able to access either SqPackArchive or GetIcon directly would be awesome in order to load any icon in the game to use in my UI. Would sure as hell be more convinient than having to download the icons from https://xivapi.com/docs/Icons, save them as png in my project and load those are resources. If I can pull the icons from the game files, I can cache them locally (both in memory for this session and on the file system for quick access after) and it makes for a much better experience for the end user.

Thank you for your consideration.

 

[mastahg]

Both spell ids and icon ids are gathered via the same function.

I'll look at making it either public or just removing the obfuscation from it so you can grab it via reflection.

 

[RedWine82]

Either solutions works for me. Thank you very much.

 

[mastahg]

This is coming in the new build now.

 

[RedWine82]

Please let me know if SqPackArchive is now public or if it needs to be accessed via reflection.

Also, will this be done in CN as well?

 

[mastahg]

Please let me know if SqPackArchive is now public or if it needs to be accessed via reflection.

Also, will this be done in CN as well?

It's via reflection as it's not something I really want to expose, but I did flag it has donotobfuscate so you can grab it now instead of it being random.

And it also live on cn now too.

 

[RedWine82]

It's via reflection as it's not something I really want to expose, but I did flag it has donotobfuscate so you can grab it now instead of it being random.

And it also live on cn now too.

You are the best. Thank you so much!