What's new
By:
  • Visit Rebornbuddy
  • Visit Resources
  • Visit API Documentation
  • Visit Downloads
  • Visit Portal
  • Visit Panda Profiles
  • Visit LLamamMagic

Little Fix for Pickuping Infernal Key and stacking them

K

ksmaze

Member
Joined
Sep 4, 2012
Messages
239
Reaction score
1
First I have to say sorry to Giles.
I don't have much time to check my fix is work or not. which cost him too energy while he should have some good rest at home.

now this is the version that can really pickup keys, stash them and stack them up.
tested on A3 only, if you got problems on picking up keys, please post here and give Giles some time to recover.

Update:
fix-fix for 1.6.3.1
fix any bug about the infernal key
add stats report about the infernal key

1.6.3.1 had some minor bug and cannot stack keys up.


Update Again:
fix for 1.6.3.3
fix bug about the infernal key

Giles did some good job on avoiding ignoring keys, but he also leads to some troubles.
I recovered some patches that i did in 1.6.1.1 and added some dirty trick for identifying keys.
hope this one can truly fix this problem.
test is needed.
sadly my barb is too weak to run this test fast, and i have to sleep for my tomorrow's job.
good luck.
 

Attachments

Last edited:
So Giles 1.6.3.1 isn't actually taking keys, even though the .1 was supposed to fix exactly that? And now you edited that latest version? Working? :-)
 
testing... I'll reply if I get anything (using with ciggarc's profiles btw)
 
Barba said:
testing... I'll reply if I get anything (using with ciggarc's profiles btw)
Click to expand...

and yes, it does work. Nice job ksmaze.


EDIT: Well, I don't know if it happened to you, but mine grabbed but did not stash the key.
I switched the code "infernal key" to "autokeep key" on the bool ShouldWeStashThis part of the .cs... might work.

}
if (TrueItemType == GilesItemType.InfernalKey)
{
if (bOutputItemScores) Log(thisitem.ThisRealName + " [" + thisitem.ThisInternalName + "] [" + TrueItemType.ToString() + "] = (autokeep key)");
return false;
 
Last edited:
Barba said:
and yes, it does work. Nice job ksmaze.


EDIT: Well, I don't know if it happened to you, but mine grabbed but did not stash the key.
I switched the code "infernal key" to "autokeep key" on the bool ShouldWeStashThis part of the .cs... might work

}
if (TrueItemType == GilesItemType.InfernalKey)
{
if (bOutputItemScores) Log(thisitem.ThisRealName + " [" + thisitem.ThisInternalName + "] [" + TrueItemType.ToString() + "] = (autokeep key)");
return false;
Click to expand...
mine is working on stashing and stacking. but yes, your point is right, you actually should replace "return false" to "return true"
I'm working on it right now, implementing some stats, after that I will upload the right version.
 
this one only added a itemtype in the code. to help DB recognize the infernalkey, and pick it up, stash it, stack it.
no more.
 
Update:
fix-fix for 1.6.3.1
fix any bug about the infernal key
add stats report about the infernal key

1.6.3.1 had some minor bug that may cause bot cannot stash them. and it cannot stack keys up.
 
Giles 1.6.3.1 picks up keys fine. No need for this. Running that version and had 3 keys total for the bots stashed this morning.
 
next time it missed it, please use Dump RActors, and send the log here please.
i don't have time for checking right now, but it works on A1 and A3 in my computer at least.
 
ksmaze said:
next time it missed it, please use Dump RActors, and send the log here please.
i don't have time for checking right now, but it works on A1 and A3 in my computer at least.
Click to expand...

Working for me in Act1 & 3 also, havent tested 2
 
Missed key in Act 1
[16:52:17.320 N] [1E816B00] Type: Item Name: DemonTrebuchetKey-11687 ActorSNO: 166943

edit: this is GilesTrinity 1.6.3.3
 
Last edited:
You must log in or register to reply here.
Back
Top