Items auto upgrade rules fix

[plsfixbugs]

There is pretty nice feature (Items -> Item List -> Misc -> Enable Auto-Upgrade) where bot auto upgrades item list rules when better item found.

But there is a bug if u are using sockets/ancient rules it changes it to 0/false, maybe more, but i had problems only with those.

So if u are using this like me, u can fix it by changing this lines in Trinity/items/ItemList.cs

From

        private static void UpgradeRules(Dictionary<LRule, float> ruleUpgrades)
        {
            if (!TrinityPlugin.Settings.Loot.ItemList.UpgradeRules)
                return;

            foreach (var pair in ruleUpgrades)
            {
                Logger.Log($"Upgraded Rule {pair.Key.Name} from {pair.Key.Value} to {pair.Value}");
                pair.Key.Value = pair.Value;
            }
        }

To

        private static void UpgradeRules(Dictionary<LRule, float> ruleUpgrades)
        {
            if (!TrinityPlugin.Settings.Loot.ItemList.UpgradeRules)
                return;

            foreach (var pair in ruleUpgrades.Where(x => x.Key.Name != "Sockets" && x.Key.Name != "Ancient"))
            {
                Logger.Log($"Upgraded Rule {pair.Key.Name} from {pair.Key.Value} to {pair.Value}");
                pair.Key.Value = pair.Value;
            }
        }

 

[xzjv]

Thanks!

 

[plsfixbugs]

So, one if this checks if (itemSetting.Type != LItem.ILType.Slot) or maybe both of them in ItemList.cs broke this feature and now its now working at all.

 

[xzjv]

Are you wanting it to work for Item Type?

 

[plsfixbugs]

Are you wanting it to work for Item Type?

Im not using item types, its not working for single items.