Help my barbarian to stop spamming battlerage

[pachlerm]

Hey guys

im using my barb to smash ghoms face and i want to use brawler. Sadly he continous to dump rage with battlerage.
can anyone please help me to fix this? im using trinity v1.8.22

kind regards

 

[pachlerm]

just some little check that if hes allready buffed he shouldnt use it :/ but i have no clue how to implement it

 

[Yohaiw]

same problem here

 

[pachlerm]

still need some help :/

 

[Mojoguy01]

The code for Trinity .23 is as follows for BattleRage checks:

public static bool CanCastBattleRage
{
   get
   {
       return !UseOOCBuff && !Player.IsIncapacitated && CanCast(SNOPower.Barbarian_BattleRage, CanCastFlags.NoTimer) &&
       (
         !GetHasBuff(SNOPower.Barbarian_BattleRage) ||
         (Settings.Combat.Barbarian.FuryDumpWOTB && Player.PrimaryResourcePct >= V.F("Barbarian.WOTB.FuryDumpMin") && GetHasBuff(SNOPower.Barbarian_WrathOfTheBerserker)) ||
         Settings.Combat.Barbarian.FuryDumpAlways && Player.PrimaryResourcePct >= V.F("Barbarian.WOTB.FuryDumpMin")
      ) &&Player.PrimaryResource >= V.F("Barbarian.BattleRage.MinFury");
   }
}

Look at line 7 (aka: !GetHasBuff()) line. There is an OR after it (||). What you can do is just change where that check is done instead of being an "OR'ed" case simply make it a primary case.


ie: this should work, again however I'm not at home on my Barb to check this, but the thought process is the correct.

public static bool CanCastBattleRage
{
   get
   {
       return !UseOOCBuff && !Player.IsIncapacitated && CanCast(SNOPower.Barbarian_BattleRage, CanCastFlags.NoTimer) && !GetHasBuff(SNOPower.Barbarian_BattleRage) &&
       (
         (Settings.Combat.Barbarian.FuryDumpWOTB && Player.PrimaryResourcePct >= V.F("Barbarian.WOTB.FuryDumpMin") && GetHasBuff(SNOPower.Barbarian_WrathOfTheBerserker)) ||
         Settings.Combat.Barbarian.FuryDumpAlways && Player.PrimaryResourcePct >= V.F("Barbarian.WOTB.FuryDumpMin")
      ) &&Player.PrimaryResource >= V.F("Barbarian.BattleRage.MinFury");
   }
}

----------------------------OR----------------------------

At line 80 you could simply do this:

                        // Battle Rage
                        if (IsNull(power) && CanCastBattleRage)
			{
				int timeSinceUse = SpellHistory.TimeSinceUse(SNOPower.Barbarian_BattleRage).Milliseconds;
				if (timeSinceUse >= 115000)
				{
					power = PowerBattleRage;
				}
			}

 

[pachlerm]

yes thank you i allready found that one. An important thing to mention is that you have to turn of dump fury with SPRINT<-- even sprint is no battlecry but unchecking it will fix this battlercry thing dunno why^^.
thank you for your post