What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

Gorm's Trinity Fixes

G

Gorm

Member
Joined
Jun 11, 2012
Messages
234
Reaction score
2
Summary

This is my own copy of Trinity with bugs I have noticed and fixed.

https://www.assembla.com/code/gorm-unifiedtrinity-fork/git/nodes/master/Trinity

I don't intend to compete with the official version because I don't have the time and I'm not getting paid for it, but since these fixes aren't getting merged, I think the DB community deserves to know about them, and no one pays attention to my posts in the Trinity threads. I try to keep it synced with the newest official version so it may come with some new Trinity bugs. But I am usually able to fix them faster than the next Trinity update.

Here are some of the examples of bugs that have been fixed. Some of them have been merged into the official Trinity.


  • Fixed bot getting stuck trying to pick up items. Credits to BlAchPT.
  • Fixed getting stuck on destructibles.
  • Fixed bot moving to destructibles even when not stuck.
  • Set earthquake to proper range.
  • Fixed SpellHistory.TimeSinceUse.
  • Fixed 3 sources of null pointer errors in TrinityExploreDungeon that can cause Demonbuddy to freeze.
  • Reduced lag when finding safezones.
  • Smart frenzy stack renewal. This improved my barbarian ghom times by 33% when using a fury spender.
  • Fix to attack corrupt growths.
  • Proper hydra and disintegrate range.
  • Ability to add booleans in ItemRules. Allows rules for easy enchanting like this
    [TYPE] == "Ring" && ([CRIT%] >= 5) + ([CRITDMG%] >= 40) + ([MAXSTAT] >= 400) >= 2
  • For more see https://www.assembla.com/code/gorm-unifiedtrinity-fork/git/commits

I also have questtools fixes/improvements.

https://www.assembla.com/code/gorm-questtools-fork/git/nodes

Please read this before replying


  • I do not take requests unless I am personally affected by the bug, or the bug is caused by my modifications.
  • I am not helping people modify Trinity. I just don't have the time.
  • Unless the bot is not working properly, please do not complain about error messages.
 
Last edited:
Thanks, I'll give it a try as soon as servers are back up !
 
Merged with 1.9. Fixed SpellHistory.TimeSinceUse.
 
are we suppose to use the combat route for this?? The folder name TrinityRoutine and place in routnies?
 
Doesn't work for me, but I'm a little stupid so I'm likely doing the simplest thing wrong.

Deleted the contents of my /Plugins/Trinity and replaced with yours

Upon loading trinity on DB I get the error:

[Trinity] Error while CopyTo Setting NotificationSetting : Exception has been thrown by the target of an invocation. Property: PushbulletKey


once I load a profile & start i'm spammed with crazy lag and a lot of red text reading:


System.Exception: Element TrinityExploreDungeon is not supported. Please check your XML and try again. (<TrinityExploreDungeon questId="93595" stepId="8" until="ObjectFound" actorId="176002" boxTolerance="0.10" boxSize="15" />) Line 218
at ‚..(PropertyInfo , XElement , Object )
at Zeta.XmlEngine.XmlEngine.Load(Object obj, XElement element)
at ‚..(XElement , Type )
at ‚...(XElement )
at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
at ‚..(XElement , PropertyInfo )
at ‚..(PropertyInfo , XElement , Object )
at Zeta.XmlEngine.XmlEngine.Load(Object obj, XElement element)
at Zeta.Bot.Profile.Profile.Load(XElement element, String path)
at Zeta.Bot.Profile.Profile.Load(String path)
at Zeta.Bot.ProfileManager.Load(String profilePath, Boolean rememberPath)

Nvm figured it out, noticed xml error & realized my questtools had somehow backdated itself to v. 1.5.3 or something..updated to newest questtools and it works xd
 
Last edited:
My barb seems to think her rend radius is slightly larger than it is, not sure if you want to adjust it!
 
JoshE said:
My barb seems to think her rend radius is slightly larger than it is, not sure if you want to adjust it!
Click to expand...

I am not taking any requests unless it personally affects my usage, or the bug is my fault and not rrix's.
 
JoshE said:
[Trinity] Error while CopyTo Setting NotificationSetting : Exception has been thrown by the target of an invocation. Property: PushbulletKey
Click to expand...
Same problem here. Updating QuestTools did not fix it. Any ideas, Gorm?
 
No idea but the bot still works for me.

Unless the bot is broken you should ignore all error messages.
 
You're right, with the error everything still appears to run just fine. Thanks very much for your swift response and work on the project.
 
[Logger] TrinityMoveTo is depreciated. Use MoveTo or SafeMoveTo instead.
 
Imodorox said:
[Logger] TrinityMoveTo is depreciated. Use MoveTo or SafeMoveTo instead.
Click to expand...

Also got this - so tried with fresh beta install/quest tools 2.0 and still got this message.

EDIT: Duh, it's a profile issue. Changed it to the proper syntax and all is well.
 
Last edited:
I merged some of your changes into 1.9.1

I didn't see:

  • Fixed 3 sources of null pointer errors in TrinityExploreDungeon that can cause Demonbuddy to freeze.
  • Smart frenzy stack renewal. This improved my barbarian ghom times by 33% when using a fury spender.
  • Fix to attack corrupt growths.
  • Proper hydra and disintegrate range.

Were these previously merged or lost somewhere?
 
  • Fixed 3 sources of null pointer errors in TrinityExploreDungeon that can cause Demonbuddy to freeze.
    alternate actors null check
    PriorityScenes null check
    Fixed TrinityExploreDungeon throwing null exception errors.
  • Smart frenzy stack renewal. This improved my barbarian ghom times by 33% when using a fury spender.
    Try to refresh frenzy stack before it expires.
  • Fix to attack corrupt growths.
    Fix for corrupt growths - reverted because you said you fixed this
  • Proper hydra and disintegrate range.
    This was a very old commit. Probably got overwritten when I merged. Proper range is around 45-50.
 
rrrix said:
I merged some of your changes into 1.9.1

I didn't see:

  • Fixed 3 sources of null pointer errors in TrinityExploreDungeon that can cause Demonbuddy to freeze.
  • Smart frenzy stack renewal. This improved my barbarian ghom times by 33% when using a fury spender.
  • Fix to attack corrupt growths.
  • Proper hydra and disintegrate range.

Were these previously merged or lost somewhere?
Click to expand...

Also I exposed maxResets on ExploreDungeon. If you set it to -1 it will end the tag if the area was fully explored. It is useful for searching for monsters that don't have a guaranteed spawn rate. This was being duplicated as another plugin for this profile here.

http://www.thebuddyforum.com/demonb...ain-set-soep-aughild-set-iwd-asheara-set.html

https://www.assembla.com/code/gorm-questtools-fork/git/nodes
 
You must log in or register to reply here.
Back
Top