Demon Hunter settings initialization bug

[Pelisse102]

DH potion, kiting and globe health issues solved

Sorry, I don't know where I should post this. Forgive me if this is not where it should be.

As many might have noticed, the demon hunter has been acting quite strangely since the last release.
I identified one important error in the file CombatBase.cs in Plugins\Trinity\Combat\Abilities
These lines are missing in the initialization of the localSettings (after line 87 for those who would like to correct it before a new realease)

case ActorClass.DemonHunter:
	EmergencyHealthPotionLimit = Settings.Combat.DemonHunter.PotionLevel;
        EmergencyHealthGlobeLimit = Settings.Combat.DemonHunter.HealthGlobeLevel;
        HealthGlobeResource = Settings.Combat.Barbarian.HealthGlobeLevelResource;
        KiteDistance = Settings.Combat.DemonHunter.KiteLimit;
        KiteMode = KiteMode.Always;
	break;

Basically, all classes but the dh get their settings.
It solved the potion issue, and might solve some other kite issues too.

 

[Pelisse102]

My bad, the actual lines should be these if you want to be able to change the kite mode in the settings panel.

case ActorClass.DemonHunter:
	EmergencyHealthPotionLimit = Settings.Combat.DemonHunter.PotionLevel;
        EmergencyHealthGlobeLimit = Settings.Combat.DemonHunter.HealthGlobeLevel;
        HealthGlobeResource = Settings.Combat.Barbarian.HealthGlobeLevelResource;
        KiteDistance = Settings.Combat.DemonHunter.KiteLimit;
        KiteMode = Settings.Combat.DemonHunter.KiteMode;
	break;

This point might have been already pointed out in another thread, I couldn't find it. My apologies if it's the case.

 

[Soulsociety]

My bad, the actual lines should be these if you want to be able to change the kite mode in the settings panel.

case ActorClass.DemonHunter:
	EmergencyHealthPotionLimit = Settings.Combat.DemonHunter.PotionLevel;
        EmergencyHealthGlobeLimit = Settings.Combat.DemonHunter.HealthGlobeLevel;
        HealthGlobeResource = Settings.Combat.Barbarian.HealthGlobeLevelResource;
        KiteDistance = Settings.Combat.DemonHunter.KiteLimit;
        KiteMode = Settings.Combat.DemonHunter.KiteMode;
	break;

This point might have been already pointed out in another thread, I couldn't find it. My apologies if it's the case.

Demonhunter is still acting wonky with theese changes

 

[Pelisse102]

After testing for some time, I can say it solved pretty much everything for me.

Now if you look into the kiting, you'll realize it can be pretty complicated and tricky, depending on what method you're relying. It's really all about playing with the parameters but no matter what some things will be impossible to obtain.