Check for a buff based on its spellID?

[ski]

I'm having an issue with this code:

        if (Me.Buffs.ContainsKey("Backlash")) {
            slog("Destruction: Backlash, casting Incinerate");
            Incinerate();
        }

Unfortunately, this always returns true, even if I do or don't have the temporary backlash buff. I'm wondering if its picking up the passive Backlash buff from the talent (its not shown in the buffs, but I assume there is a hidden one).

Is there a way to do that buff check on the temporary version's spellID instead?

 

[popwar]

the buff: http://www.wowhead.com/?spell=47260, the spell that causes it: http://www.wowhead.com/?spell=17962, like that?

 

[ski]

the buff: http://www.wowhead.com/?spell=47260, the spell that causes it: http://www.wowhead.com/?spell=17962, like that?

In this case, the Talent is http://www.wowhead.com/?spell=34939 and the buff you get from the talent proccing is http://www.wowhead.com/?spell=34936. They both have the same name though, so unless I can figure out some way to differentiate between the two, I can't add in a condition for Backlash.

 

[fpsware]

Some talents put an invisible buff or aura on you. So checking for a buff name will always return true. In cases like that I use the following. It uses LUA and it works like a charm!

publicbool IsBuffOnMeLUA(string BuffName)
{
Lua.DoString("buffName,_,_,stackCount,_,_,_,_,_=UnitBuff(\"player\",\"" + BuffName + "\")");
string buffName = Lua.GetLocalizedText("buffName", Me.BaseAddress);
 
if (buffName == BuffName)
{
returntrue;
}
else
returnfalse;
}

 

[fpsware]

Excuse the copy and paste. I'm in a rush but I'm sure you can sort it out

 

[ski]

Excuse the copy and paste. I'm in a rush but I'm sure you can sort it out

Lol, that will do the trick. Thanks. Do you use that for every buff instead of Buffs.ContainsKey("SpellName");? Or just for ones with invisible auras?

 

[fpsware]

By default I use Me.Buffs.ContainsKey("buff name here") and if I have problems with it I use the LUA code. But I'll always use the LUA buff check when I'm working with talent procs as I've found these to use invisible buffs / auras more frequently.

 

[laria]

Why are you guys all using the buffsname? we can get the spellid in lua nowadays which clearly seperates buffs with the same name but different levels /effects from each other. This would also make sure that you can use non.english clients as well.

 

[LiquidAtoR]

No need as the Lua.GetLocalizedText is called upon. It should return the Local String in the current game language (correct me if I'm wrong here).

I'm using similar code in my demonlock CC project.
This is coming from Bobby's Shaman CC (Credit to him for the code).

Only difference I'm on the Public Void instead of Public Bool department.

 

[ski]

Why are you guys all using the buffsname? we can get the spellid in lua nowadays which clearly seperates buffs with the same name but different levels /effects from each other. This would also make sure that you can use non.english clients as well.

You're welcome to rewrite all my buffchecks for me