[Beta] Quest step progress issue?

[y2krazy]

Since I know you prefer full logs, while I don't have any characters who have run my profiles outside of self-checking current step during profile writing, I will ask anyone in my quest profile topic (found in my signature) to post here if they can provide full logs after experiencing this issue. The profile(s) used were a variety from my patch 2.1 profile to the latest Heavensward one found in my quest profile topic.

EDIT: This was posted on accident in my death topic, so it has been moved to its own topic.

---

I don't have any logs, as I don't have any characters to test some of my questing profiles to confirm myself, but I have gotten multiple reports of people having issues with quest step progress. Some examples provided to me:

Getting this nonstop on MSQ: "IF Wishes Were Horsebirds":

[05:00:29.832 D] Targeting Chocobo 0x4687DA 0x12D0C800
[05:00:41.633 D] Finished checking gear in 00:00:00.0021417
[05:00:41.971 D] Targeting Chocobo 0x4687DA 0x12D0C800
[05:00:56.672 D] Finished checking gear in 00:00:00.0014186
[05:01:00.201 D] Targeting Chocobo 0x4687DA 0x12D0C800
[05:01:11.705 D] Finished checking gear in 00:00:00.0014453
[05:01:12.369 D] Targeting Chocobo 0x4687DA 0x12D0C800
[05:01:26.732 D] Finished checking gear in 00:00:00.0014382

stop/start and see if it works?

that did it

http://ffxiv.gamerescape.com/wiki/If_Wishes_Were_Horsebirds

In the above example, the person using the profile was on the step after sniffing the Chocobo, but it was still trying to interact with the Chocobo until RB was Stopped/Started again. Upon starting the profile again, it properly detected that it was on the next step and continued properly.

---

Another Stop/Start that fixed a quest issue:

MSQ: "Scouts in Distress"

[07:34:23.111 D] Requesting path on 138 from <-212.289, -39.72311, -109.8864> to <-208.4536, -38.99379, -113.2983>
[07:34:23.138 N] [UseItemTag] Target set to
[07:34:23.225 D] Generated path to <-208.4536, -38.99379, -113.2983> in 00:00:00.1135573 ms
[07:34:23.239 N] [UseItemTag] Target set to
[07:34:30.844 D] Finished checking gear in 00:00:00.0014406
[07:34:30.844 N] [UseItemTag] Target set to

bot keeps going back and forth

reset fixed it

---

Another Stop/Start that fixed a quest issue:

MSQ: A Hard Habit to Break (blah blah blah use /huh while targeting Struggling Adventurer)

restarting fixes it

---

Another Stop/Start that fixed a quest issue:

ah its stuck again
interacting with alphinaud

[05:37:03.048 D] Interacting with Alphinaud 0x3DA79D00
[05:37:12.730 D] Finished checking gear in 00:00:00.0023802
[05:37:12.879 D] Interacting with Alphinaud 0x3DA79D00
[05:37:27.742 D] Finished checking gear in 00:00:00.0018580
[05:37:27.812 D] Interacting with Alphinaud 0x3DA79D00
[05:37:42.755 D] Finished checking gear in 00:00:00.0017708
[05:37:42.826 D] Interacting with Alphinaud 0x3DA79D00
[05:37:57.783 D] Finished checking gear in 00:00:00.0021783
[05:37:57.954 D] Interacting with Alphinaud 0x3DA79D00

want me to try restarting or you wanna take a look?

stop/start and see
it might be an issue with Order Bot

fixed
restarting fixes those issues

---

It appears that for a large number of quest steps, a Stop/Start of RB is needed to get it to properly recognize the current quest step, as RB doesn't seem to handle it properly when a quest step is progressed, for example, from step 2 to 3. It tries to jump around the profile due to either checking for the next quest step too quickly, or something else. A temporary fix on my end could be to add a 5 second wait timer at the end of every quest step, but that just feels unnecessary.

I have also received reports that Order Bot (or RB) will think a quest step is either complete (when it's not), or progress too quickly and skip over the next quest step. When this happens, it appears to skip hundreds or more lines and go through dozens of teleport loops, attempting to pick up subsequent quests that it shouldn't be trying to obtain yet.

 

[mastahg]

It's probably an improper use of tag attributes as the api hasn't changed at all internally on their side. But without any logs and without atleast the tags in question i cant do anything.

 

[y2krazy]

It's probably an improper use of tag attributes as the api hasn't changed at all internally on their side. But without any logs and without atleast the tags in question i cant do anything.

First example, above, where the user had progressed to step 4 (RB completed step 3 properly), but for some reason, RB was still trying to run the tags for step 3 instead of moving on to the tags in step 4:

				<If Condition="GetQuestStep(66887) == 3">
					<If Condition="not IsOnMap(140)">
						<If Condition="Managers.WorldManager.HasAetheryteId(17)">
							<TeleportTo Name="Horizon" AetheryteId="17" />
						</If>
						<If Condition="not Managers.WorldManager.HasAetheryteId(17)">
							<Travel To="140" />
						</If>
					</If>
					<TalkTo InteractDistance="3.0" NpcId="1008611" XYZ="-386.4042, 23, -350.1183" />
				</If>
				<If Condition="GetQuestStep(66887) == 4">
					<If Condition="not IsOnMap(140)">
						<If Condition="Managers.WorldManager.HasAetheryteId(17)">
							<TeleportTo Name="Horizon" AetheryteId="17" />
						</If>
						<If Condition="not Managers.WorldManager.HasAetheryteId(17)">
							<Travel To="140" />
						</If>
					</If>
					<TalkTo InteractDistance="3.0" NpcId="1008632" XYZ="-388.6931, 23, -350.9423" />
				</If>

^ The user clicked Stop, then Start, and it then put the user on the step 4 tags, where it should have automatically gone without requiring a Stop, then Start, to correct the issue.

---

Second example, above, where the user had progressed to step 2 (RB completed step 1 properly), but for some reason, RB was still trying to run the tags for step 1 instead of moving on to the tags in step 2:

				<If Condition="GetQuestStep(66894) == 1">
					<If Condition="not IsOnMap(138)">
						<If Condition="Managers.WorldManager.HasAetheryteId(14)">
							<TeleportTo Name="Aleport" AetheryteId="14" />
						</If>
						<If Condition="not Managers.WorldManager.HasAetheryteId(14)">
							<Travel To="138" />
						</If>
					</If>
					<NoCombatMoveTo Name="Scouts" XYZ="-208.4536, -38.99379, -113.2983" />
					<UseItem NpcId="1008683" ItemId="2001214" XYZ="-208.4536, -38.99379, -113.2983" Radius="10" />
				</If>
				<If Condition="GetQuestStep(66894) == 2">
					<If Condition="not IsOnMap(138)">
						<If Condition="Managers.WorldManager.HasAetheryteId(14)">
							<TeleportTo Name="Aleport" AetheryteId="14" />
						</If>
						<If Condition="not Managers.WorldManager.HasAetheryteId(14)">
							<Travel To="138" />
						</If>
					</If>
					<Grind grindRef="Scouts_in_Distress" while="HasQuest(66894) and GetQuestStep(66894) == 2" />
				</If>

^ The user clicked Stop, then Start, and it then put the user on the step 2 tags, where it should have automatically gone without requiring a Stop, then Start, to correct the issue.

---

... and so on. Again, I'll try to get some people to bring over full logs who ran into this issue.

 

[mastahg]

Yep, you should be providing QuestId="654321" and Step="3" or whatever step its on so that the tag will know to exit.

ie:
<TalkTo QuestId="66887" Step="3" InteractDistance="3.0" NpcId="1008611" XYZ="-386.4042, 23, -350.1183" />

and

<UseItem QuestId="66894" Step="1" NpcId="1008683" ItemId="2001214" XYZ="-208.4536, -38.99379, -113.2983" Radius="10" />

TalkTo has default logic that should have triggered but im not 100% what the default logic is for UseItem but either way you should really be using QuestId and Step to control tag completion for like 95% of the time.

 

[mastahg]

Also, you should extract

					<If Condition="not IsOnMap(138)">
						<If Condition="Managers.WorldManager.HasAetheryteId(14)">
							<TeleportTo Name="Aleport" AetheryteId="14" />
						</If>
						<If Condition="not Managers.WorldManager.HasAetheryteId(14)">
							<Travel To="138" />
						</If>
					</If>

and do something like using HasAtLeastOneQuest and checking all the ones that are relavent to that map, and if thats true then running that code that way you don't have a ton of duplicate code throughout the profile.

 

[mastahg]

Just checked on the UseItem behavior, without providing a conditional or questid+step or usetimes the tag will never exit. QuestId+Step is the best way to go followed by a conditonal and for a last resort UseTimes. (UseTimes logic is kinda bad and id like to rewrite it but doing so would probably break a few things)

 

[y2krazy]

Will make adequate adjustments as you have suggested and let you know if that resolves the issues that have been reported to me. Thanks!