2 +Trinity bugs to report

[ksmaze]

Found 2 bugs to report for 3, 0, 6, 24
1. BastiansSpenderBuff didn't work, CombatManager line#386:

return SpellHistory.TimeSinceGeneratorCast >= 4750;

should be changed to:

return SpellHistory.TimeSinceSpenderCast >= 4750;

2. Blacklist is not working properly, it sometimes pick templar. Not sure if it is intended...
Logs:

12:37:33.837 DEBUG TreeHooks Replaced hook [ProfileOrderBehavior_Hook] 6b4f2efd-b700-4006-9771-4645c3d2ac77
12:37:33.840 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=4 SinceFirstTargettedSecs=3 UniqueHash=159003 X=382.1389 Y=384.633
12:37:34.047 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=5 SinceFirstTargettedSecs=3 UniqueHash=159003 X=382.1389 Y=384.633
12:37:34.262 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=6 SinceFirstTargettedSecs=3 UniqueHash=159003 X=382.1389 Y=384.633
12:37:34.496 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=7 SinceFirstTargettedSecs=3 UniqueHash=159003 X=382.1389 Y=384.633
12:37:34.647 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=8 SinceFirstTargettedSecs=4 UniqueHash=159003 X=382.1389 Y=384.633
12:37:34.848 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=9 SinceFirstTargettedSecs=4 UniqueHash=159003 X=382.1389 Y=384.633
12:37:35.031 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=10 SinceFirstTargettedSecs=4 UniqueHash=159003 X=382.1389 Y=384.633
12:37:35.231 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=11 SinceFirstTargettedSecs=4 UniqueHash=159003 X=382.1389 Y=384.633
12:37:35.425 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=12 SinceFirstTargettedSecs=4 UniqueHash=159003 X=382.1389 Y=384.633
12:37:35.600 WARN  PerformanceLogger [Trinity][Performance] Execution of OnPulse took 54.00920ms.
12:37:35.683 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=13 SinceFirstTargettedSecs=5 UniqueHash=159003 X=382.1389 Y=384.633
12:37:36.467 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=14 SinceFirstTargettedSecs=5 UniqueHash=159003 X=382.1389 Y=384.633
12:37:36.643 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=15 SinceFirstTargettedSecs=6 UniqueHash=159003 X=382.1389 Y=384.633
12:37:36.799 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=16 SinceFirstTargettedSecs=6 UniqueHash=159003 X=382.1389 Y=384.633
12:37:36.982 DEBUG TreeHooks Replaced hook [ProfileOrderBehavior_Hook] d6c3e618-8c7a-4041-b049-bdfaf582f685
12:37:37.010 INFO  Logger [Trinity][Targetting] Target Selected: Hireling_Templar-161 (52693), Weight=5000 Distance=8.979352 TargettedTimes=17 SinceFirstTargettedSecs=6 UniqueHash=159003 X=382.1389 Y=384.633
12:37:37.048 INFO  LeaveGameTag Leaving game, reason: Done

In TargetManager line#164

if (Blacklist.Contains(u.UniqueHash))
                return false;

Add following

if (u.IsBlacklisted)
return false;

 

[ksmaze]

also a bug for CrusaderCombat which set CrusaderDefaultConditions as private at #49. Makes it difficult to write custom build for crusader.

 

[xzjv]

Thanks, ill get these fixed.