Unified Trinity Community Edition

[fr0stebyte]

i tried creating a simple pickup validation class, but i don't seem to be able to implement it successfuly in itemhandling.cs

 

[fr0stebyte]

Here's my code:

PickupValidation.cs

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Collections;
using System.IO;
using GilesTrinity.Technicals;
using System.Windows.Documents;

namespace GilesTrinity
{
class PickupValidation
{
String fileRule = @"Plugins\GilesTrinity\ItemRules\pickup_rule.dis";
List<Boolean> pickupFlag = new List<Boolean>();
List<string> nameItem = new List<string>();
Boolean pickItUp = false;

private void readFile()
{
if (File.Exists(fileRule))
{
StreamReader reader = new StreamReader(fileRule);
string input = null;
while ((input = reader.ReadLine()) != null)
{

nameItem.Add(input.Split(',')[0].ToString());
pickupFlag.Add(Boolean.Parse(input.Split(',')[1]));
}
}
}
public Boolean validatePickup(GItemType itemType)
{
for (int i = 0; i < pickupFlag.Count; i++)
{
if (nameItem.Equals(itemType.ToString()) && pickupFlag.Equals(true))
{
pickItUp = true;
}
else
{
pickItUp = false;
}
}
return pickItUp;
}

public void init()
{
try
{
readFile();
}
catch (Exception ex)
{
DbHelper.Log(TrinityLogLevel.Error, LogCategory.ScriptRule, "PickupValidation File Reading failed: {0}", ex);
}
}


}
}

Here's the pickup_rule.dis

GItemType.Axe,true
GItemType.CeremonialKnife,true
GItemType.HandCrossbow,true
GItemType.Dagger,true
GItemType.FistWeapon,true
GItemType.Mace,true
GItemType.MightyWeapon,true
GItemType.Spear,true
GItemType.Sword,true
GItemType.Wand,true
GItemType.TwoHandAxe,false
GItemType.TwoHandBow,false
GItemType.TwoHandDaibo,false
GItemType.TwoHandCrossbow,false
GItemType.TwoHandMace,false
GItemType.TwoHandMighty,false
GItemType.TwoHandPolearm,false
GItemType.TwoHandStaff,false
GItemType.TwoHandSword,false
GItemType.Mojo,false
GItemType.Orb,false
GItemType.Quiver,false
GItemType.Shield,false
GItemType.Amulet,true
GItemType.Ring,true
GItemType.Boots,true
GItemType.Bracer,true
GItemType.Cloak,false
GItemType.Gloves,true
GItemType.Legs,true
GItemType.MightyBelt,true
GItemType.Shoulder,true
GItemType.SpiritStone,false
GItemType.VoodooMask,false
GItemType.WizardHat,false

 

[hti]

You want it? You got it!
It'll be nice to have a drop-down menu with these options:

• Keep UNID
• Stash
• Sell
• Salvage

In my opinion it'll resolve all problems with any rules.
In addition, these settings will be saved between plugin updates so it will set us free from having to modify files manually every time.

Lol and time passed to read again and again and again same request, I can pass it to develop flexible pickup system.
Not in next release, I don't have time

 

[addiktion]

While using Giles Trinity, I noticed in the basic Alkizer run profile, the bot for me gets stuck in Tower of the Cursed 1. What happens is the profile checks around for an elite in that area and happens to run past a shrine that Giles seems to recognize and want to click on (because I have it enabled to do so in Giles). When it fails to click on the shrine due to being up on higher ground, it tries to leave to the next level, but fails to do so because it gets stuck in a loop on the stairs of trying to fetch the shrine or move on. If there is no shrine, it works fine.

I tried searching for a solution to potentially blacklisting shrines in Giles Trinity but found nothing specific on the forums on how to do this. Any suggestions or solutions to fixing this?

Maybe its not even related to Giles and more so the inability for DB to get close enough to click on this shrine. Either way, I should be able to black list this, right?

Temp Solution: Disabled Shrines.

 

[hti]

I activated the caching debugging and reproduced the stuttering issue, but the Logs folder in Trinity only contains a debug file that shows the item rules being loaded and a log file that shows the item rules that were matched during the stashing routine. Am I missing something to log the problem correctly?

Same problem as comment #378.

Log file of Demonbuddy.

 

[hti]

While using Giles Trinity, I noticed in the basic Alkizer run profile, the bot for me gets stuck in Tower of the Cursed 1. What happens is the profile checks around for an elite in that area and happens to run past a shrine that Giles seems to recognize and want to click on (because I have it enabled to do so in Giles). When it fails to click on the shrine due to being up on higher ground, it tries to leave to the next level, but fails to do so because it gets stuck in a loop on the stairs of trying to fetch the shrine or move on. If there is no shrine, it works fine.

I tried searching for a solution to potentially blacklisting shrines in Giles Trinity but found nothing specific on the forums on how to do this. Any suggestions or solutions to fixing this?

Maybe its not even related to Giles and more so the inability for DB to get close enough to click on this shrine. Either way, I should be able to black list this, right?

Giles now manage correctly Blacklist info from profile (Same tag with or without Giles)

 

[FrenchBot]

Anyone knows how to solve the gold stack limit issue ?

 

[addiktion]

Giles now manage correctly Blacklist info from profile (Same tag with or without Giles)

Thank you for the quick response hti.

Quick Q for you if you got a moment. Are shrines considered RActors or Map Markers? I'm going to see if I can find how to detect what the shrine is and blacklist target it.

 

[SHJordan]

When you use Wall of Zombies with Creepers rune WD will keep trying to kill the creepers spawn, but they are from the rune... you need to blacklist them!

 

[fif]

This file includes the stutter issue.

What happened while logging:

- force town run
- bot TPs to town for routine
- bot identifies items
- bot runs to stash
- bot runs to vendor
- bot vendors trash items
- STUTTERING HERE
- bot runs back to TP with heavy stuttering
- bot runs fine after jumping back through TP

View attachment 6156 2012-11-30 20.59.txt

 

[ungo666]

Hey rrrix, here's the log of a nearly full run with only DB 101 Beta and Trinity Version 1.7.1.3

[ATTACH]71044.vB[/ATTACH]

Hope you find the stuttering signs in there , i can say that everything is working very very good if it wasnt for that.

My system in case you want to know it's :
i7 920
6GB ram cas7dd3 Ocz
2xAti4860HD
2xHDD Raid 0 Stripe

Never had a single problem related to stuttering before community edition.

Edit : I have seen once in this test my toon going nort of town (after a teleport to town) for like 2 seconds, then it changed his mind and went to take next waypoint. This is not profile related (always same profile and never seen it myself before), and as i only used trinity in this test i think depends on it. Maybe it's this the situation where atom then break something or idk cause many people reported similar town stuck but i never did before not using atom and with trinity 044. Saying it so u can have a check maybe at it too.

 

[TAM-TAM]

I can pass it to develop flexible pickup system.
Not in next release, I don't have time

It's ok and will be great! Thanks a lot =)
I am new here but I have a programming experience, so if you show me direction I can help to develop of this system =)

P.S. Btw it's not about picking up but mostly about handling.

 

[addiktion]

This file includes the stutter issue.

What happened while logging:

- force town run
- bot TPs to town for routine
- bot identifies items
- bot runs to stash
- bot runs to vendor
- bot vendors trash items
- STUTTERING HERE
- bot runs back to TP with heavy stuttering
- bot runs fine after jumping back through TP

View attachment 71045

I have the same issue. If I click pause on the bot it instantly stops stuttering.

 

[Tinnvec]

Just wanted to note that 1.7.1.3 still ignores enchantress chickens even though it was noted in changelog that it "hungers for them once more" (lol!)

 

[finni]

Hi ungo!

In the latest version, 1.7.1.3, I've added some special diagnostics for troubleshooting this particular problem.

Here's what I'd like you to do and it will help me nail this down for good:

* Go to trinity config > Advanced tab
* Enable "Debug Cache System"
* Reproduce the stuttering/freezing/performance problem
* ZIP your log file and attach to this thread.
* You don't need to set your Demonbuddy log settings to 'Diagnostic' - all diagnostic logs are already logged in the log file (just not always shown in the log window).

Just a little warning, Debugging the cache system will generate a HUGE log file, so you will need to zip it before attaching.

Thanks for your help!

i did make a log only from a townrun, the lag only happens from the way back to the portal after selling

i always have this lags while townrun, and as said, everything works ok with 50fps, identify, stashing, go to the npc...but the way back is the hell

so the lags are only in the last few seconds in the logs, hope this helps

i did it with 1.2 and 1.3 - my fps was set to 50, with 2 i have 7 fps with 3 i have 20 fps on the way back

i had activated debug chache in both versions but in 3 it doesnt seems to work?


would be so nice if u all could join the ciggarc irc channel

 

[Icaros]

Attached log with "could not read bytes from 00000008 [299]!"

I also had a suggestion that might clear up confusion on the loot options.
When switching to scripted rules or loot rules, grey out any options that no longer apply. Visual feedback will clear up a ton of misunderstandings.

 

[addiktion]

Giles now manage correctly Blacklist info from profile (Same tag with or without Giles)

hti,

Maybe I'm not blacklisting right but I keep getting the error in DB when slapped directly into the profile file: "Failed to load profile: Element TargetBlacklists is not supported. Please check your XML and try again."

I guess this tag was implemented around .204 but this is the command I'm using in the profile on the latest beta version:

<TargetBlacklists>
<TargetBlacklist actorId="138989" name="Blacklisting Health Well" />
</TargetBlacklists>

You indicated that Giles should manage Blacklist info from profiles, but it doesn't appear to be so. I wonder if this tag was removed at some point in DB. Where does Giles store its blacklisted actorIds?

 

[swiftdan]

still ignoring all voids but faster skill smashing then prev version

 

[mind163]

It works, but periodically there are lags.
and errors:

[01:41:10.971 Q] [Trinity][CacheManagement]System.AccessViolationException: Could not read bytes from 00000008 [299]!
   в Zeta.MemoryManagement.ExternalProcessReader.ReadBytes(IntPtr address, Int32 count, Boolean isRelative)
   в Zeta.MemoryManagement.ExternalProcessReader.Read[T](IntPtr address, Boolean isRelative)
   в Zeta.Internals.Actors.ACD.
[
](ACD , Int32 )
   в Zeta.Internals.Actors.ACD.GetAttribute[T](Int32 attribute)
   в Zeta.Internals.Actors.ACD.GetAttribute[T](ActorAttributeType attributeType)
   в Zeta.Internals.Actors.DiaUnit.get_IsBurrowed()
   в GilesTrinity.GilesTrinity.RefreshGilesUnit(Boolean AddToCache)
   в GilesTrinity.GilesTrinity.RefreshStepMainObjectType(Boolean& AddToCache)
   в GilesTrinity.GilesTrinity.CacheDiaObject(DiaObject freshObject)
   в GilesTrinity.GilesTrinity.RefreshCacheMainLoop()
[01:42:53.027 Q] [Trinity][CacheManagement]System.NullReferenceException: Object reference not set to an instance of the object.
   в Zeta.Internals.Actors.DiaUnit.get_IsBurrowed()
   в GilesTrinity.GilesTrinity.RefreshGilesUnit(Boolean AddToCache)
   в GilesTrinity.GilesTrinity.RefreshStepMainObjectType(Boolean& AddToCache)
   в GilesTrinity.GilesTrinity.CacheDiaObject(DiaObject freshObject)
   в GilesTrinity.GilesTrinity.RefreshCacheMainLoop()

 

[fif]

Suggestion for using Rend on elites only:

// Rend, elites close-range only
if (!bOOCBuff && !bCurrentlyAvoiding && hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Rend) && !playerStatus.IsIncapacitated &&
  (iElitesWithinRange[RANGE_12] > 0 || (CurrentTarget.IsBossOrEliteRareUnique && CurrentTarget.RadiusDistance <= 6f))
  {
    if (playerStatus.CurrentEnergy >= 20)
        return new GilesPower(SNOPower.Barbarian_Rend, 0f, playerStatus.CurrentPosition, iCurrentWorldID, -1, 5, 5, USE_SLOWLY);
    bWaitingForSpecial = true;
  }

Comments?