[Plugin Addon] "Item Rules" with a file based scripting language

theatristformallyknownasG · Nov 2, 2012

Yep, both folders too.

11/03/2012 08:24 AM <DIR> .
11/03/2012 08:24 AM <DIR> ..
11/03/2012 08:24 AM <DIR> Functions
11/03/2012 08:29 AM 1,064,570 GilesTrinity.cs
10/19/2012 08:56 AM 124,878 GilesTrinity.xaml
11/03/2012 08:24 AM <DIR> Specification

G

hti · Nov 2, 2012

theatristformallyknownasG said:
Yep, both folders too.

11/03/2012 08:24 AM <DIR> .
11/03/2012 08:24 AM <DIR> ..
11/03/2012 08:24 AM <DIR> Functions
11/03/2012 08:29 AM 1,064,570 GilesTrinity.cs
10/19/2012 08:56 AM 124,878 GilesTrinity.xaml
11/03/2012 08:24 AM <DIR> Specification

G

Put this line at top of GilesTrinity.cs :

Code:

using GilesTrinity.Functions;

Josiah · Nov 2, 2012

hti said:
Put this line at top of GilesTrinity.cs :

Code:

using GilesTrinity.Functions;

That worked, thanks!

Tinnvec · Nov 2, 2012

DavidKDean said:
I'm not having issues atm with Legendary items (yet). What rules are you using to test the item?

Here's the section I made, just commented out the keep all legendaries line (I have giles set to 1+ so it'll grab the rest or could just move that line after my rules). I also know the AS% rule doesn't work currently, just hope that's not the part. Also (if anyone decides they are going to use this) it is very very basic, there are just so many parts to a legendary, I'll get around to it all eventually

Code:

// +--------------------------+
// | Legen wait for it daries |
// +--------------------------+
// Checks iLvl 58+ Legendary Weapons, those that can drop in Inferno
// Trashes if any min and max weapon damage is in the bottom 50% of capability

// Axes - 1H

// The Butcher's Sickle - iLvl 60
[QUALITY] == Legendary && [TYPE] == Axe && [ONEHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 370 && [WEAPMAXDMG] < 702 # [TRASH]
// The Burning Axe of Sankis - iLvl 62
[QUALITY] == Legendary && [TYPE] == Axe && [ONEHAND] == true && [LEVEL] == 62 # [WEAPMINDMG] < 382 && [WEAPMAXDMG] < 802 # [TRASH]
// Sky Splitter - iLvl 63
[QUALITY] == Legendary && [TYPE] == Axe && [ONEHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 431 && [WEAPMAXDMG] < 901 # [TRASH]

// Daggers

// Wizardspike - iLvl 63
[QUALITY] == Legendary && [TYPE] == Dagger && [LEVEL] == 63 # [WEAPMINDMG] < 285 && [WEAPMAXDMG] < 733 # [TRASH]

// Maces - 1H

// Nailbiter - iLvl 60
[QUALITY] == Legendary && [TYPE] == Mace && [ONEHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 392 && [WEAPMAXDMG] < 733 # [TRASH]
// Echoing Fury - iLvl 62
[QUALITY] == Legendary && [TYPE] == Mace && [ONEHAND] == true && [LEVEL] == 62 # [WEAPMINDMG] < 504 && [WEAPMAXDMG] < 896 # [TRASH]
// Sun Keeper - iLvl 63
[QUALITY] == Legendary && [TYPE] == Mace && [ONEHAND] == true && [LEVEL] == 61 # [WEAPMINDMG] < 485 && [WEAPMAXDMG] < 1001 # [TRASH]

// Spears

// The Tree Hundredth Spear - iLvl 60
[QUALITY] == Legendary && [TYPE] == Spear && [LEVEL] == 60 # [WEAPMINDMG] < 477 && [WEAPMAXDMG] < 813 # [TRASH]
// Empyrean Messenger - iLvl 63
[QUALITY] == Legendary && [TYPE] == Spear && [LEVEL] == 63 # [WEAPMINDMG] < 519 && [WEAPMAXDMG] < 951 # [TRASH]

// Swords - 1H

// Doombringer - iLvl 60
[QUALITY] == Legendary && [TYPE] == Sword && [ONEHAND] == true && [LEVEL] == 60 && [BLOCK%] == 7 # [WEAPMINDMG] < 274 && [WEAPMAXDMG] < 633 # [TRASH]
// Skycutter - iLvl 60
[QUALITY] == Legendary && [TYPE] == Sword && [ONEHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 274 && [WEAPMAXDMG] < 633 # [TRASH]
// Sever - iLvl 62
[QUALITY] == Legendary && [TYPE] == Sword && [ONEHAND] == true && [LEVEL] == 62 # [WEAPMINDMG] < 407 && [WEAPMAXDMG] < 788 # [TRASH]
// Azurewrath - iLvl 63
[QUALITY] == Legendary && [TYPE] == Sword && [ONEHAND] == true && [LEVEL] == 63 && [AS%] > 14 # [WEAPMINDMG] < 280 && [WEAPMAXDMG] < 651 # [TRASH]
// Devil Tongue = iLvl 63
[QUALITY] == Legendary && [TYPE] == Sword && [ONEHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 366 && [WEAPMAXDMG] < 852 # [TRASH]

// Ceremonial Knives

// The Gidbin - iLvl 61
[QUALITY] == Legendary && [TYPE] == CeremonialDagger && [LEVEL] == 61 # [WEAPMINDMG] < 268 && [WEAPMAXDMG] < 745 # [TRASH]
// Manajuma's Carving Knife (Set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == CeremonialDagger && [LEVEL] == 63 && [CRITDMG%] > 65 # [WEAPMINDMG] < 318 && [WEAPMAXDMG] < 919 # [TRASH]
// Last Breath - iLvl 63
[QUALITY] == Legendary && [TYPE] == CeremonialDagger && [LEVEL] == 63 # [WEAPMINDMG] < 318 && [WEAPMAXDMG] < 919 # [TRASH]

// Fist Weapons

// Won Khim Lau - iLvl 62
[QUALITY] == Legendary && [TYPE] == FistWeapon && [LEVEL] == 62 # [WEAPMINDMG] < 328 && [WEAPMAXDMG] < 764 # [TRASH]
// The Fist of Az'Turrasq - iLvl 63
[QUALITY] == Legendary && [TYPE] == FistWeapon && [LEVEL] == 63 && [AS%] > 9 && [SPIRITREG] > 0 # [WEAPMINDMG] < 466 && [WEAPMAXDMG] < 888 # [TRASH]
// Shenlong's Relentless Assault (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == FistWeapon && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 366 && [WEAPMAXDMG] < 852 # [TRASH]
// Shenlong's Fist of Legend (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == FistWeapon && [LEVEL] == 63 && [CRITDMG%] > 65 # [WEAPMINDMG] < 366 && [WEAPMAXDMG] < 852 # [TRASH]
// Crystal Fist - iLvl 63
[QUALITY] == Legendary && [TYPE] == FistWeapon && [LEVEL] == 63 # [WEAPMINDMG] < 366 && [WEAPMAXDMG] < 852 # [TRASH]

// Mighty Weapons - 1H

// Bul-Kathos's Solemn Vow (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [LEVEL] == 63 && [AS%] > 9 && [LOH] > 657 # [WEAPMINDMG] < 433 && [WEAPMAXDMG] < 904 # [TRASH]
// Blade of the Warlord - iLvl 63
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 433 && [WEAPMAXDMG] < 904 # [TRASH]
// Bul-Kathos's Warrior Blood (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [LEVEL] == 63 # [WEAPMINDMG] < 433 && [WEAPMAXDMG] < 904 # [TRASH]

// Axes - 2H

// Messerschmidt's Reaver - iLvl 60
[QUALITY] == Legendary && [TYPE] == Axe && [TWOHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 723 && [WEAPMAXDMG] < 1294) # [TRASH]
// Skorn - iLvl 63
[QUALITY] == Legendary && [TYPE] == Axe && [TWOHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 1053 && [WEAPMAXDMG] < 1475) # [TRASH]

// Maces - 2H

// Sledge of Athskeleng - iLvl 62
[QUALITY] == Legendary && [TYPE] == Mace && [TWOHAND] == true && [LEVEL] == 62 # [WEAPMINDMG] < 1044 && [WEAPMAXDMG] < 1420 # [TRASH]
// Schaefers's Hammer - iLvl 63
[QUALITY] == Legendary && [TYPE] == Mace && [TWOHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 865 && [WEAPMAXDMG] < 1212 # [TRASH]

// Polearms

// Heart Slaughter - iLvl 60
[QUALITY] == Legendary && [TYPE] == Polearm && [LEVEL] == 62 # [WEAPMINDMG] < 682 && [WEAPMAXDMG] < 1007 # [TRASH]
// Vigilance - iLvl 63
[QUALITY] == Legendary && [TYPE] == Polearm && [LEVEL] == 63 # [WEAPMINDMG] < 1032 && [WEAPMAXDMG] < 1490 # [TRASH]

// Staves

// Wormwood - iLvl 60
[QUALITY] == Legendary && [TYPE] == Staff && [LEVEL] == 60 # [WEAPMINDMG] < 521 && [WEAPMAXDMG] < 929 # [TRASH]
// The Tormentor - iLvl 61
[QUALITY] == Legendary && [TYPE] == Staff && [LEVEL] == 61 # [WEAPMINDMG] < 634 && [WEAPMAXDMG] < 1105 # [TRASH]
// The Grand Vizier - iLvl 63
[QUALITY] == Legendary && [TYPE] == Staff && [LEVEL] == 63 # [WEAPMINDMG] < 884 && [WEAPMAXDMG] < 1497 # [TRASH]

// Axes - 2H

// The Sultan of Blinding Sand - iLvl 60
[QUALITY] == Legendary && [TYPE] == Sword && [TWOHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 535 && [WEAPMAXDMG] < 951 # [TRASH]
// Warmonger - iLvl 62
[QUALITY] == Legendary && [TYPE] == Sword && [TWOHAND] == true && [LEVEL] == 62 # [WEAPMINDMG] < 720 && [WEAPMAXDMG] < 1125 # [TRASH]
// The Grandfather - iLvl 63
[QUALITY] == Legendary && [TYPE] == Sword && [TWOHAND] == true && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 859 && [WEAPMAXDMG] < 1308 # [TRASH]
// Maximus - iLvl 63
[QUALITY] == Legendary && [TYPE] == Sword && [TWOHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 758 && [WEAPMAXDMG] < 1309 # [TRASH]

// Diabos

// Inna's Reach (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == Diabo && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 800 && [WEAPMAXDMG] < 1320 # [TRASH]
// Flying Dragon - iLvl 63
[QUALITY] == Legendary && [TYPE] == Daibo && [LEVEL] == 63 # [WEAPMINDMG] < 800 && [WEAPMAXDMG] < 132 # [TRASH]

// Mighty Weapons - 2H

// The Gavel of Judgement - iLvl 60
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [TWOHAND] == true && [LEVEL] == 60 # [WEAPMINDMG] < 678 && [WEAPMAXDMG] < 970 # [TRASH]
// Immortal King's Boulder Breaker (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [TWOHAND] == true && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 1088 && [WEAPMAXDMG] < 1510 # [TRASH]
// Fury of the Vanished Peak - iLvl 63
[QUALITY] == Legendary && [TYPE] == MightyWeapon && [TWOHAND] == true && [LEVEL] == 63 # [WEAPMINDMG] < 987 && [WEAPMAXDMG] < 1343 # [TRASH]

// Bows

// Windforce - iLvl 63
[QUALITY] == Legendary && [TYPE] == Bow && [LEVEL] == 63 # [WEAPMINDMG] < 431 && [WEAPMAXDMG] < 1087 # [TRASH]

// Crossbows

// Pus Spitter - iLvl 60
[QUALITY] == Legendary && [TYPE] == Crossbow && [LEVEL] == 60 # [WEAPMINDMG] < 424 && [WEAPMAXDMG] < 718 # [TRASH]
// Hellrack - iLvl 61
[QUALITY] == Legendary && [TYPE] == Crossbow && [LEVEL] == 61 # [WEAPMINDMG] < 590 && [WEAPMAXDMG] < 927 # [TRASH]
// Manticore - iLvl 63
[QUALITY] == Legendary && [TYPE] == Crossbow && [LEVEL] == 63 # [WEAPMINDMG] < 627 && [WEAPMAXDMG] < 998 # [TRASH]

// Hand Crossbows

// Balefire Caster - iLvl 60
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 60 # [WEAPMINDMG] < 202 && [WEAPMAXDMG] < 613 # [TRASH]
// Dawn - iLvl 62
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 62 # [WEAPMINDMG] < 234 && [WEAPMAXDMG] < 744 # [TRASH]
// Calamity - iLvl 63
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 63 && [AS%] > 9 && [CRITDMG%] > 65 # [WEAPMINDMG] < 70 && [WEAPMAXDMG] < 400 # [TRASH]
// Natalya's Slayer (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 177 && [WEAPMAXDMG] < 651 # [TRASH]
// Danetta's Spite (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 63 && [CRITDMG%] > 65 # [WEAPMINDMG] < 345 && [WEAPMAXDMG] < 785 # [TRASH]
// Danetta's Revenge (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == HandCrossbow && [LEVEL] == 63 # [WEAPMINDMG] < 345 && [WEAPMAXDMG] < 785 # [TRASH]

// Wands

// Fragment of Destiny - iLvl 60
[QUALITY] == Legendary && [TYPE] == Wand && [LEVEL] == 60 # [WEAPMINDMG] < 289 && [WEAPMAXDMG] < 622 # [TRASH]
// Slorak's Madness - iLvl 63
[QUALITY] == Legendary && [TYPE] == Wand && [LEVEL] == 63 && [AS%] > 9 # [WEAPMINDMG] < 332 && [WEAPMAXDMG] < 718 # [TRASH]
// Chantodo's Will (set) - iLvl 63
[QUALITY] == Legendary && [TYPE] == Wand && [LEVEL] == 63 # [WEAPMINDMG] < 386 && [WEAPMAXDMG] < 817 # [TRASH]

EDIT: D'oh, seems I had a couple typos in there, continuing to test, not crashing anymore, but still not selling

barblol · Nov 2, 2012

hti said:
Put this line at top of GilesTrinity.cs :

Code:

using GilesTrinity.Functions;

This guy.

theatristformallyknownasG · Nov 3, 2012

Josiah said:
That worked, thanks!

not for me

, can you just Pm me the fixed file based on the fixed Monk thanks ?

[14:20:37.359 N] Compiler Error: g:\DemonBuddy\farming\Plugins\GilesTrinity\GilesTrinity.cs(2944,41) : warning CS0162: Unreachable code detected
[14:20:37.359 N] Compiler Error: g:\DemonBuddy\farming\Plugins\GilesTrinity\GilesTrinity.cs(10062,83) : error CS1061: 'GilesTrinity.GilesTrinity.GilesCachedACDItem' does not contain a definition for 'DBItem' and no extension method 'DBItem' accepting a first argument of type

G

barblol · Nov 3, 2012

theatristformallyknownasG said:
not for me , can you just Pm me the fixed file based on the fixed Monk thanks ?

[14:20:37.359 N] Compiler Error: g:\DemonBuddy\farming\Plugins\GilesTrinity\GilesTrinity.cs(2944,41) : warning CS0162: Unreachable code detected
[14:20:37.359 N] Compiler Error: g:\DemonBuddy\farming\Plugins\GilesTrinity\GilesTrinity.cs(10062,83) : error CS1061: 'GilesTrinity.GilesTrinity.GilesCachedACDItem' does not contain a definition for 'DBItem' and no extension method 'DBItem' accepting a first argument of type

G

TL;DR: go to bottom of this post.

I'm not sure when ACDItem was added for the parameters in the GilesCachedACDItem class, but your version(monk fixed one) doesn't have it...

See here in GilesCachedACDItem class...

Code:

  ...
            public float ArcaneOnCrit { get; set; }
            public float ManaRegen { get; set; }
            public float GlobeBonus { get; set; }

          [COLOR="#FF0000"]  public ACDItem DBItem { get; set; }[/COLOR]

            public GilesCachedACDItem(string internalname, ...  ItemStats thesestats, [COLOR="#FF0000"]ACDItem item[/COLOR])
            {
                ThisInternalName = internalname;
                 ...
                ManaRegen = thesestats.ManaRegen;
                GlobeBonus = thesestats.HealthGlobeBonus;
                [COLOR="#FF0000"]DBItem = item;[/COLOR]
            }

Which means you have to fix all the calls for the class, like so...

Code:

GilesCachedACDItem thiscacheditem = new GilesCachedACDItem(thisitem.InternalName, ... thisitem.ItemStackQuantity, thisitem.Stats, [COLOR="#FF0000"]thisitem[/COLOR]);

Might be better to just download the guilestrinity provided by darkfiend in the front page and edit it with the monk fix.

I have it here for download.

With the following fix:

Code:

  // Wave of light
                    if (!bOOCBuff && !bCurrentlyAvoiding && !playerStatus.bIsIncapacitated &&
                        (iElitesWithinRange[RANGE_25] > 0 || ((targetCurrent.bThisEliteRareUnique || targetCurrent.bThisBoss) && targetCurrent.fRadiusDistance <= 14f) || iAnythingWithinRange[RANGE_15] > 2) &&
                        hashPowerHotbarAbilities.Contains(SNOPower.Monk_WaveOfLight) &&
                        GilesUseTimer(SNOPower.Monk_WaveOfLight) &&
                        (playerStatus.dCurrentEnergy >=[COLOR="#FF0000"] 90[/COLOR] || playerStatus.dCurrentEnergyPct >= 0.85) && [COLOR="#FF0000"]GilesHasBuff(SNOPower.Monk_MantraOfConviction)[/COLOR])
                    {
                        return new GilesPower(SNOPower.Monk_WaveOfLight, 16f, vNullLocation, -1, targetCurrent.iThisACDGUID, 1, 1, USE_SLOWLY);
                    }

theatristformallyknownasG · Nov 3, 2012

thanks heaps barblol, working like a charm, off to add the legendary filtering now.

G

ekki · Nov 3, 2012

I would like to use bombastics version of trinity, how to implement? Or can u make it?
Thanks

darkfriend77 · Nov 3, 2012

.-) done ... check first post

ekki · Nov 3, 2012

great! ty

Crazymanxox · Nov 3, 2012

// known bug
// ---------
// - [AS%] not working

So it doesnt work with Attack speed at all ?

zippysticks · Nov 3, 2012

isn't this the same as creating a custom loot rule? Or does this plugin do something that the custom loot rule feature from db core can't do? can anyone clarify? to me, it seems like just a custom loot table, but in plugin form.

Lipie · Nov 3, 2012

Seems like in the bombastic version, your item selection doesn't work or do anything when he does a town run.
Is this correct ?

Archone88 · Nov 3, 2012

After I put the plugin in my plugins folder, DB crashes a few seconds after start. Before I can press the "Start button".

jnew00 · Nov 3, 2012

Archone88 said:
After I put the plugin in my plugins folder, DB crashes a few seconds after start. Before I can press the "Start button".

This is also happening to me, but only when I runas another windows user. I have three D3 clients running as different users, I also run the different DBs as the respective D3 windows users (but pointing to the same DB install directory).

I have been using multiple plugins (including Trinity of course, and Radsatom which also has multiple folders within the plugins folder) that all work fine with this setup for months, this is the first time I've encountered this. When I just take out the "runas" piece in the shortcut or use the my "main" logged in user...it works fine. Meaning it does not immediately crash as mentioned by Archone88.

barblol · Nov 3, 2012

Archone88 said:
After I put the plugin in my plugins folder, DB crashes a few seconds after start. Before I can press the "Start button".

Need logs.

darkfriend77 · Nov 3, 2012

Lipie said:
Seems like in the bombastic version, your item selection doesn't work or do anything when he does a town run.
Is this correct ?

i removed some GUI loging ... so no more msgs except item is keept by ruleset ... it should also write all stuff into the log file ...check this ....

darkfriend77 · Nov 3, 2012

zippysticks said:
isn't this the same as creating a custom loot rule? Or does this plugin do something that the custom loot rule feature from db core can't do? can anyone clarify? to me, it seems like just a custom loot table, but in plugin form.

u might be right .... but ... if so ... show me the xml rule for ...

Code:

[TYPE] == Shield # [MAXSTATVIT] >= 150 && [CRIT%] >= 8 && [ALLRES] >= 60 && ( [MAXONERES] >= 40 ||  [LIFE%] >= 8 ) # [KEEP]

jiznadj · Nov 4, 2012

So what do you set your item scores to in the town-run section? you just move them all the way up to the right side?

[Plugin Addon] "Item Rules" with a file based scripting language

Active Member

New Member

New Member

Member

New Member

Active Member

New Member

Active Member

New Member

Member

New Member

New Member

New Member

Member

New Member

New Member

New Member

Member

Member

New Member