What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

[Plugin] Giles Trinity

Status
Not open for further replies.
Are demon hunters still unsupported? I could not find any info regarding this.

Dantronix
 
Any chance you could make the use of Mantra's more 'liberal' (Monks) ? ..

It hardly ever uses them ( At least not Conviction ) , some times it uses it on elite packs, and sometimes it doesn't. It would make sense to at least make it spam it when you're on full or almost full Spirit, regardless of what it is killing.

Any chance you will change this, or atleast show what to edit to get this effect :) ?


EDIT: To Clarify; it will always keep the base aura up, no problem there, it's the use effect I refer to.
 
If that does it then it's exactly as I mentioned in my post above;

Yes, it does. Now the bot chases goblins untill they are dead. And doesn't lost focus when fighting elites.

GilesSmith said:
It's the force-close-range flag. Commenting out those lines might seem like a sensible quick-fix, but you're going to cause issues where your bot can get stuck trying to target something far off but is trapped/body-blocked in a corner and will just stay stuck and die. That code is there as a safety - I obviously just need to find a better balancing point for that safety.

Yes, I've suspected of that. But I prefer my toon to die than lose so many goblins. And is a temporary fix, I know. Just while I wait for a perma solution :)
 
Worked! - just saw my follower proc a goblin from the Puzzle Ring while fighting an elite pack and he immediately ran over and destroyed the goblin!

Edit: my guy just totally stucked, a few monsters were body blocking him from reaching a goblin so be careful with this change, I'll try tweak it and test even further

does your barb use leap? it should leap to the goblin if its being blocked after dropping to a low enough hp, i set mines to spam leap all the time.
 
Wizard is amazing but you need to fix buffs, sometimes run around without energy armor or Magic weapon
 
Worked! - just saw my follower proc a goblin from the Puzzle Ring while fighting an elite pack and he immediately ran over and destroyed the goblin!

Edit: my guy just totally stucked, a few monsters were body blocking him from reaching a goblin so be careful with this change, I'll try tweak it and test even further

Could you point out wich line exactly we have to edit and how to do it please ?
 
Any chance you could make the use of Mantra's more 'liberal' (Monks) ? ..

It hardly ever uses them ( At least not Conviction ) , some times it uses it on elite packs, and sometimes it doesn't. It would make sense to at least make it spam it when you're on full or almost full Spirit, regardless of what it is killing.

Any chance you will change this, or atleast show what to edit to get this effect :) ?


EDIT: To Clarify; it will always keep the base aura up, no problem there, it's the use effect I refer to.

Nvm, I found out how..

Changed: "iElitesWithinRange[RANGE_30] > 0"

To: "iAnythingWithinRange[RANGE_15] >= 2"

In Line: 4960 (v1.4.3)
 
Temporary fix for those with Wrath of the Berserker not being cast most of the times:

change:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && iElitesWithinRange[RANGE_30] > 0)) &&

to:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && (iElitesWithinRange[RANGE_30] > 0 || iElitesWithinRange[RANGE_9] > 0))) &&

I need some feedback on this :)
 
Temporary fix for those with Wrath of the Berserker not being cast most of the times:
change:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && iElitesWithinRange[RANGE_30] > 0)) &&
to:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && (iElitesWithinRange[RANGE_30] > 0 || iElitesWithinRange[RANGE_9] > 0))) &&
I need some feedback on this :)

Hehe, you've found one of those annoying obvious errors, well done! The actual error is higher up, if you search for where it assigns those values (look for the string "Total up monsters at various ranges" - the 20 or so lines below that) - you can see that if a monster is at 9f range - it adds it to the "monsters within 9 foot" variable.... BUT doesn't also total that up to monsters within 15, 20, 25, 30 - which it SHOULD (because a monster within 9 foot range is *ALSO* within 30 foot!). The "else" is just need removing from the 5 or so if checks in sequential order, so they are straight out if's, not else if's.

It's already fixed in prep for next release - and will fix a lot of skill uses throughout. Even better news is - early tests indicate I have also fixed priority selection by quite a large degree, a random error that could sometimes make your bot "stop dead and do nothing" for a few seconds (or at least one cause of this), and also potentially the issue with sometimes ignoring elites (though still running tests on this as may just be that have got lucky with not ignoring any so far).
 
Last edited:
Nvm, I found out how..

Changed: "iElitesWithinRange[RANGE_30] > 0"

To: "iAnythingWithinRange[RANGE_15] >= 2"

In Line: 4960 (v1.4.3)


changed this for mantra of evasion for me and works great thx
 
Nvm, I found out how..

Changed: "iElitesWithinRange[RANGE_30] > 0"

To: "((iAnythingWithinRange[RANGE_30] >= 2) || (iElitesWithinRange[RANGE_30] > 0))"

In Line: 4960 (v1.4.3)

EDIT: Changed the line abit, seems to work better, and takes Elites into account.

EDITEDIT: Ups wrong button, was supposed to edit the post, not quote it :S
 
v1.4.4 uploaded:
- Fixed errors in recognizing and calculating ranges for monsters (elites and greys), which was having a huge negative impact on the intelligence of skill selection and skill use.
- Fixed one of the issues with cached data sometimes caching data that was not retrieved successfully from D3 memory, which could cause you to ignore occassional elite monsters.
- Fixed an error which could sometimes crash the plugin, causing a couple of seconds of the bot doing nothing at all while DemonBuddy restarted it.
- Priority/target weighting is now a little less sensitive to being "stuck" for brief moments when moving, which would cause you to focus on the closest-ranged monsters only constantly.
- Elites given slightly more weight during standard combat targeting.

IMPORTANT: Updating Plugin Versions:
To minimize or fix problems (random slowdowns, oddities with avoidance settings ignoring certain avoidance types), you should do the following things every time you update Giles Trinity or if you get any problems after updating;
1: Make sure DemonBuddy is closed
2: Go into the DemonBuddy folder, and DELETE the entire "CompiledAssemblies" folder from within the DB folder (this is completely fine and safe to do - DemonBuddy will rebuild this folder!).
3: Go into the /settings/ folder within DemonBuddy - in this folder, delete "GilesTrinity.cfg".
4: Load DB and configure the plugin again
Following these quick, simple instructions will fix a lot of random issues that can crop up between upgrades. The reason for these requirements is largely down to the size and complexity of Giles Trinity.
 
testing now

thx again for superfast updates

you rock
 
EDIT: Changed the line abit, seems to work better, and takes Elites into account.
EDITEDIT: Ups wrong button, was supposed to edit the post, not quote it :S
changed this for mantra of evasion for me and works great thx
Temporary fix for those with Wrath of the Berserker not being cast most of the times:
change:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && iElitesWithinRange[RANGE_30] > 0)) &&
to:
Code:
(!targetCurrent.bThisBoss && iBossesWithinRange[RANGE_30] == 0 && (iElitesWithinRange[RANGE_30] > 0 || iElitesWithinRange[RANGE_9] > 0))) &&
I need some feedback on this :)
Nvm, I found out how..
Changed: "iElitesWithinRange[RANGE_30] > 0"
To: "iAnythingWithinRange[RANGE_15] >= 2"
In Line: 4960 (v1.4.3)

^^ Just to sum up anybody reading the thread and seeing these posts. Please do not make these changes in v.1.4.4 unless anyone posts that they are still needed. 1.4.4 should fix all of the issues with these at the root (without needing to change any individual skill checks).
 
Huge improvement on the monster range thing! Very noticeable
 
Just chased and killed a treasure goblin past 30+ trash mobs. Ran past the ones that weren't blocking, stopped for a second to kill those that were and kept chasing. New version looks awesome so far.
 
Lot of deaths running 1.4.3 overnight (barb act3). normally average 2-6, woke up this morning to find 14 (not just a sudden thing - scrolled up the chat window and saw way more deaths than usual). ah well.

eager to try out 1.4.4, will post an update tonight :) thanks as always Giles.
 
Status
Not open for further replies.
Back
Top