[Plugin] Giles Trinity

[devious21]

Anyone noticing less loot getting stashed with Trinity? or are my settings just f*cked up?

Just luck.
One of my bots has stashed far more than usual, the other hasn't stashed an item in the past two hours.
I've been watching both, they're both picking up the loot, one is simply finding better items

 

[la7eralus]

Not sure if this is related to Trinity or a DemonBuddy issue itself, but in act 2 in the sewers following the escape from caldeum (starts with a royal audience quest 4.1), the debris in the sewer cause the bot to get stuck. It appears it is not detecting the debris, although it only appears when the debris is intersecting a pillar on the wall.

Aka: Wall-----debris-----[pillar|wall

Under these circumstances the bot lodges itself between the pillar and debris and proceeds to "stuck" (this is without any unstuck'ing plugin).

EDIT (pic):

 

[kobru]

Reporting some issues with monks:

Avoidance priority on AoE is so high that it won't even use serenity (damage immunity) before it dies. I've seen it run around trying to avoid things and dying without even using serenity.

Also, is there a way to make it use mantra when lower HP? I see that it's set to use mantra only when spirit is full. Although this can be good, for those using transcendence (heal on spirit usage), it can be very helpful to use mantra when HP is low.

thanks!

i changed this

// Serenity if health is low
if ((playerStatus.dCurrentHealthPct <= 0.60 || (playerStatus.bIsIncapacitated && playerStatus.dCurrentHealthPct <= 0.65)) && hashPowerHotbarAbilities.Contains(SNOPower.Monk_Serenity) &&
GilesUseTimer(SNOPower.Monk_Serenity, true) &&
playerStatus.dCurrentEnergy >= 10 && PowerManager.CanCast(SNOPower.Monk_Serenity))
{
return new GilesPower(SNOPower.Monk_Serenity, 0f, vNullLocation, iCurrentWorldID, -1, USE_ANY_TIME, USE_INSTANTLY);

and it works better for me now

 

[CCCComboBreaker]

Just luck.
One of my bots has stashed far more than usual, the other hasn't stashed an item in the past two hours.
I've been watching both, they're both picking up the loot, one is simply finding better items

same here.
the only things on floor are low level items.

 

[shinavaka]

in the next ver can you put in an option to turn off combat, i want to use all the other plugins except combat, i find belphegor is better for my build even with the speed issues.

 

[Pranasas]

What can I do about my barb chasing every single pesky fallen grunt when there are like 5 fallen prophets further away spawning them? I feel it takes too much time given just how insignificant those grunts are...

Ideally I'd love to set up a logic like:
WHILE "fallen prophet" is nearby { ignore "fallen grunt" }

 

[Marc_NL]

Hey Giles,

I was wondering if you could rework your lootrule-system It's stashing crap items, and I think it's because of the way it scores things. I think it's because Magic Find and Gold Find give a lot of points. And if attribute > 150 it also gets a really high score

So examples are: Armor - Belt 'Copperlock Defense'. Score = 16122 Vitality=90. Magic Find %=19 / Armor - Pants 'Attack Goliath'. Score = 20036 Dexterity=74. Vitality=98. Magic Find %=20

Or Armor - Chest 'Knight's Lux'. Score = 20991 Dexterity=169. Vitality=245. This is also a crap item, no all res, no nothing.

And last but not least: WeaponRange - TwoHandCrossbow 'Sanguine Bough'. Score = 84479 Vitality=158. Life On Hit=946. Life Steal %=3. DPS=867

I think twohanders should be something like DPS < 900 = thrash

I know I can tune the score, but then I would also thrash good items, that do have good stats! So I think some of the stats simply weigh to heavy.

 

[devious21]

in the next ver can you put in an option to turn off combat, i want to use all the other plugins except combat, i find belphegor is better for my build even with the speed issues.

The reason combat is integrated with this plugin is so the stasher can temporarily 'turn off' combat and pick up items. With Belphegor, I don't think its possible.

 

[tenaciouzd]

How you know if a plugin is shit or not:

Start a2 profile with 100 pots using belphegor = 10 pots when you next check on it

Use giles with 10 pots left = come back with 53 pots.

Thanks you giles for your work, and the improvements you made to the WD spells. Once I get something good that sells for a lot expect some income to your paypal.

Kudos buddy, here a e-beer for you.

 

[Champagne]

getting issues with stash.

everything was installed clean and fresh like i always do, with 1.0.1. i set the items configs to only pick up yellows lvl60+ and acc lvl54+ with sell trash option ticked. i left it running for about 24hours checked all character and had almost no items stashed and the ones that did get stashed were trash.

i then tried 1.1, left for work and 6hours later here i am with nearly empty stash except for one bot had a echoing fury in it

im only using trinity and ciggarc with the newest db .222

 

[devious21]

getting issues with stash.

everything was installed clean and fresh like i always do, with 1.0.1. i set the items configs to only pick up yellows lvl60+ and acc lvl54+ with sell trash option ticked. i left it running for about 24hours checked all character and had almost no items stashed and the ones that did get stashed were trash.

i then tried 1.1, left for work and 6hours later here i am with nearly empty stash except for one bot had a echoing fury in it

im only using trinity and ciggarc with the newest db .222

Did you check the Junk Log to see what stats the items it was salvaging had?

 

[sjenkins]

I have found a workaround for the leap issue, if you remove this bit of code from the cs file he will not leap outside of combat.

find and delete:
// Leap movement for a barb
if (GilesTrinity.hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
DateTime.Now.Subtract(GilesTrinity.dictAbilityLastUse[SNOPower.Barbarian_Leap]).TotalMilliseconds >= GilesTrinity.dictAbilityRepeatDelay[SNOPower.Barbarian_Leap] &&
fDistanceNeeded >= 25f && fDistanceNeeded <= 35f &&
PowerManager.CanCast(SNOPower.Barbarian_Leap) && !ShrinesInArea(vMoveToTarget))
{
Vector3 vTargetAimPoint = MathEx.CalculatePointFrom(vMoveToTarget, vMyCurrentPosition, fDistanceNeeded - 2f);
ZetaDia.Me.UsePower(SNOPower.Barbarian_Leap, vTargetAimPoint, GilesTrinity.iCurrentWorldID, -1);
GilesTrinity.dictAbilityLastUse[SNOPower.Barbarian_Leap] = DateTime.Now;
return;
}

And this will cause him to leap even when at full health.
Find and change:

// Leaps used on when off-cooldown, or when out-of-range
if (!bBuffsOnly && targetCheckTarget != null && !bFindPureRanged && !bAvoidanceEmergency && !playerStatus.bIsIncapacitated && hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
(playerStatus.dCurrentHealthPct <= 0.75 || fDistanceFromTarget >= 18f) &&
GilesUseTimer(SNOPower.Barbarian_Leap, true) && PowerManager.CanCast(SNOPower.Barbarian_Leap))

to:

// Leaps used on when off-cooldown, or when out-of-range
if (!bBuffsOnly && targetCheckTarget != null && !bFindPureRanged && !bAvoidanceEmergency && !playerStatus.bIsIncapacitated && hashPowerHotbarAbilities.Contains(SNOPower.Barbarian_Leap) &&
(playerStatus.dCurrentHealthPct <= 1 || fDistanceFromTarget >= 18f) &&
GilesUseTimer(SNOPower.Barbarian_Leap, true) && PowerManager.CanCast(SNOPower.Barbarian_Leap))

Thank you Giles for making such clear and to the point notes in your code

HOLY SHIT...First off...GILES YOU ARE THE MAN!!!! I am a long time user of Honorbuddy, but i quit playing wow, and i have to admit sir, i'd love to learn some code from you =)
You are very dedicated and i will also be donating to your accomplishments, i respect you a ton (even if you are making a bot for a game) lol...

Respect bro...

MY 2 CENTS...

Do what Gary7 says...AND TURN OFF "Attempt to avoid AoE's" watch your rend barb rip through shit...im astonished watching mine now.


EDIT : Also set to pick up your health globes to ".65" (someone else posted how to do this as well)
Meh Double EDIT : if you are still having trouble dieing more than 2 times an hour (im not but your gear may be weaker) you can try the passive skill Juggernaught with this setup, should work quite well with frozen packs =)

 

[Champagne]

Did you check the Junk Log to see what stats the items it was salvaging had?

yeh, didnt go through all of it but seen some nice items like a 1h xbow 900+ dps with loh, pants/chest with 120vit 50int i think and 2sockets with all res. all way under the default score

 

[frosty]

i think the scoring needs some change:
- trifecta items are scored low
- gf or mf without good stats get scored ridiculously high
- items with slightly lower main stat, vit and all resist get scored quite low
- slightly lower DPS with critdmg and socket gets scored low

 

[gotteshand]

Another skill issue regarding CM/Frost Nova/Energy Twister/Explosive Blast - Wizard Builds.

Due to the changes made to most of the Energy Twister Runes most notable Wicked Wind where the proc rate was reduced from 0.25 to 0.125 most of us now use the Storm Chaser Rune since it has a proc rate of 0.5 which is pretty important to recuperate Arcane power as well as life (LoH). Now what does that mean well it means the Range settings for Energy Twister the plugin has right now are off. Because Storm Chaser is random and you can not tell where it will to its important that the bot moves in as close as possible to the targets before starting to cast. It doesnt need to move in at point blank range but 6-12 yards is a good indicator which will mash up nicely with Explosive Blast range which is 12 yards as well.

Ideally it would be like this:

Monsters detected bot activates Diamond Skin, moves in freezes them with Frost Nova, moves closer and then starts casting Energy Twister/Explosive Blast (Explosive Blast should be cast at the same time as Frost Nova since it has a delay..). This would also really help against Fallen Prophets since due to the random nature of Storm Chaser Rune it uses up allot of Arcane power to kill a single target. Also allot of stuff CM Builds don't really need to avoid due to their nature of being able to tank massive DPS such as plague as long as there's enough monster/elites around the bot he wont die to plague due to LoH.


Also the bot is leaving out allot of treasure goblins right now he's not really chasing them even doh he could and should I mean there is no harm in chasing them as long as there is no elites.

 

[LordBob]

not sure if this has been addressed but we dont need to replace the loot rules file with trinity? or do we need to dl the giles loot rules from old post?

 

[firerebel]

Treasure goblins are terribly bugged for me. If they start teleporting, it just freezes completely. Won't attack, move, or do anything but stand still. I have to set it to ignore them as if I leave it on normal or prioritize that will get me killed any time he sees one.

 

[Ash]

Thank you Giles, for all your hard work. Vast improvement over the default routines and previous plugins, and it's a relief to not have to worry about loot being missed anymore.

Combat seems smoother, especially fallen shamans. If I had to find weaker areas it'd be item scoring and avoidance.

I might be wrong, but it seems that the score of a stat increases exponentially as the stat increases. So items with high rolls in the primary stats get stashed a lot, while items with a range of desirable stats (trifecta for example), but more average rolls in all of them, get trashed. Weighting the score based on the combination of desirable stats still seems a little weak. An item with just the primary stats is never going to be worth much, no matter how high they are. Add in some allres, and even if the primary stats drop the price still jumps up. Add in a slot specific stat (crit% on helm and bracers, life% on shoulder and belt), and the value can increase by several factors.

I run into a lot of avoidance issues when the bot, for whatever reason, can't get away from an aoe. Happens often with waller elite packs, and in narrow areas. Sits there trying to run away, when if it turned around and started attacking, it could probably survive from loh and revenge. I've messed with the range and health values (I'm alright with taking a couple ticks of arcane beam as long as I'm not actually sitting on the orb, rather than spending 90% of the fight trying to find a safe spot), which I think has helped a little, but avoidance stucks are still probably the majority of my deaths. Not geared enough to turn off avoidance alltogether, so I'm very much looking forward to v1.2

 

[Dbuddy]

- goblins are missed quite often. (for example when white mobs near and the gobo is pulled with AoE Damage...) :/
- not sure if the loot rules fit fine for weapons. (sold 950 dps with 150 int to vendor) (well, it's crap anyway)

+ Critical Mass is working way better
+ avoidance is getting better
+ some little bugs i had with older plugins are gone

 

[kdong]

i think the scoring needs some change:
- trifecta items are scored low
- gf or mf without good stats get scored ridiculously high
- items with slightly lower main stat, vit and all resist get scored quite low
- slightly lower DPS with critdmg and socket gets scored low

i second that. in addition, bots missing some loot, might be a DB issue?

i missed 4 level 62 and 4 level 63 rares in the last 7 hour run