[Plugin] Giles Stash & Loot Rule Replacer

[Hajkfas]

Hmm, interesting! I'll definitely see if I can replicate that. Was your inventory semi-full of unID stuff, or already ID stuff, or a bit of a mix, when you started the bot (if you can remember). I can't think from memory what would cause that, but will definitely experiment!

I have tried it with semi-full id and non ids. Seems to fix itself if I disable/reenable plugin however!

Might also have something to do with stopping the bot sometimes then resuming.

 

[Wiga]

Aha. That's definitely my plugin then. Fresh install is always good - in a fresh folder (don't just copy a new DB into the already existing DB folder), with freshly downloaded plugins etc. Also double check that there is room in your stash for the items, and you haven't set the only free-space as "protected stash pages" in the settings tab of DemonBuddy (can you confirm if you do have any pages protected at all?).

If it still has issues, could you list the other plugins you use, and worst case scenario, if it's not going to be too much trouble, it might be helpful to see screenshots of your 3 stash pages and your backpack (you can obviously cut all other information out - ie names of stuff, anything that might identify you) - you could upload them to imgur.com and just send me a private forum message with a link to them. I know that's quite a bit of effort, but it might help me work out what could be causing the stash issues (perhaps it's certain size items trying to fit in specific spaces in the stash, based on where the stash items are currently arranged, or something very unusual like that!?).

Profile: [A1 - Inferno] Champion-Farming
Plugins: [Plugin] Giles Stash & Loot Rule Replacer; [Plugin] Unstucker - restarts if your character gets stuck (v1.8); and GilesIgnoreStuff (the newest version)
Combat Routine: Belphegor the official combat routine

It looks like it has an issue if you have more than 100 Mythic Health potions in the inventory, once I manually forced the health potions into the inventory it finished it's sequence flawlessly. I turned on stash Health Potions I will see if the next run still freezes.

I will take some screen shots when it does its town run if it locks up since I made the above changes.

 

[GilesSmith]

Profile: [A1 - Inferno] Champion-Farming
Plugins: [Plugin] Giles Stash & Loot Rule Replacer; [Plugin] Unstucker - restarts if your character gets stuck (v1.8); and GilesIgnoreStuff (the newest version)
Combat Routine: Belphegor the official combat routine
It looks like it has an issue if you have more than 100 Mythic Health potions in the inventory, once I manually forced the health potions into the inventory it finished it's sequence flawlessly. I turned on stash Health Potions I will see if the next run still freezes.
I will take some screen shots when it does its town run if it locks up since I made the above changes.

That definitely helps, I'll have a look at the stack-handling code and see if I can improve things there, sounds like it's getting confused if you already have a full-stack of something in your backpack, trying to merge it with other stacks in your stash - fingers crossed it'll be something dead obvious to fix for the next version, thanks! (also, you're using pretty much an identical setup routine and plugins as me ).

 

[Wiga]

That definitely helps, I'll have a look at the stack-handling code and see if I can improve things there, sounds like it's getting confused if you already have a full-stack of something in your backpack, trying to merge it with other stacks in your stash - fingers crossed it'll be something dead obvious to fix for the next version, thanks! (also, you're using pretty much an identical setup routine and plugins as me ).

It is definitely a stacking issue. It hung up this time trying to stash a flawless square ruby and a flawless square topaz, both of which I didn't have any in my stash. When it started the stashing process it stashed a stack of 2 flawless square emeralds fine before hanging on the ruby and topaz. Once I forced the topaz and ruby into my stash it finished the sequence flawlessly.

Edit: Just completed another town run and it completed it perfectly. It seems as long as there was the equivalent gems and potions in the inventory already it stashes fine, but if there wasn't one in there already it got confused.

 

[GilesSmith]

It is definitely a stacking issue. It hung up this time trying to stash a flawless square ruby and a flawless square topaz, both of which I didn't have any in my stash. When it started the stashing process it stashed a stack of 2 flawless square emeralds fine before hanging on the ruby and topaz. Once I forced the topaz and ruby into my stash it finished the sequence flawlessly.
Edit: Just completed another town run and it completed it perfectly. It seems as long as there was the equivalent gems and potions in the inventory already it stashes fine, but if there wasn't one in there already it got confused.

Thanks for the info, I'm certain I have fixed all the issues with stackable items now - re-did the stashing routine, it handles a lot more intelligently now no matter how the stacks are spread out between stash/backpack. I'll hold the update until I finish the bonus-scores for good multi-stat-combos though, but shouldn't be long

 

[Wiga]

Thanks for the info, I'm certain I have fixed all the issues with stackable items now - re-did the stashing routine, it handles a lot more intelligently now no matter how the stacks are spread out between stash/backpack. I'll hold the update until I finish the bonus-scores for good multi-stat-combos though, but shouldn't be long

No problem I can wait, Great work on the plugin by the way.

 

[GilesSmith]

v1.2 uploaded:
- Fixed issues with the stashing routine getting stuck when handling stacks of items in certain situations.
- Added in some special bonus multipliers for certain stat combinations getting good rolls (eg getting a high roll on both magic find and gold find on the same item).
- Changed filenames for the stash logs to "StashLog - <character name> - <character class>.log" rather than filling the folder with date-based filenames.
- Improved the output of the backpack test and stash log files (only very slightly!).

 

[Wiga]

v1.2 uploaded:
- Fixed issues with the stashing routine getting stuck when handling stacks of items in certain situations.
- Added in some special bonus multipliers for certain stat combinations getting good rolls (eg getting a high roll on both magic find and gold find on the same item).
- Changed filenames for the stash logs to "StashLog - <character name> - <character class>.log" rather than filling the folder with date-based filenames.
- Improved the output of the backpack test and stash log files (only very slightly!).

That was quick, testing it out now.

 

[protossop]

Please upload a version that picks up all blues and salvages them. This is important for crafters.

 

[Hajkfas]

Please upload a version that picks up all blues and salvages them. This is important for crafters.

Just change

<!-- *ANY* yellow ilvl 61+ - should ALWAYS work because no itemBaseType or itemType or complex stat listings -->
   <ItemRule description="Any rare ilvl 61+">
     <StatRules>
       <Rule stat="Level" minValue="61" quality="[FONT=Arial Black][B][SIZE=4]Rare4[/SIZE][/B][/FONT]" />
     </StatRules>
   </ItemRule>

to Magic1

 

[GilesSmith]

Please upload a version that picks up all blues and salvages them. This is important for crafters.

For those unable to edit the loot rules in notepad, the attachments on the first post now contain six lootules - I simply copied the 3 loot-rules already up (for ilvl 61, 62 or 63), and edited the pickup quality to blue (magic1) instead of yellow (rare4).

Go and download whichever suits you best. The loot-rules are otherwise unchanged.

(I also somehow screwed up the download count on the plugin file attachments when doing this, which is a shame )

 

[protossop]

For those unable to edit the loot rules in notepad, the attachments on the first post now contain six lootules - I simply copied the 3 loot-rules already up (for ilvl 61, 62 or 63), and edited the pickup quality to blue (magic1) instead of yellow (rare4).

Go and download whichever suits you best. The loot-rules are otherwise unchanged.

(I also somehow screwed up the download count on the plugin file attachments when doing this, which is a shame )

I'm using "Giles_blue_ilvl61_PluginRules.xml" and notice it doesn't pick up low ilvl blues. Can you change it to pick up every blue no matter the ilvl, then salvage them? All blues salvage into essences so they are worth picking up no mater the ilvl.

 

[GilesSmith]

I'm using "Giles_blue_ilvl61_PluginRules.xml" and notice it doesn't pick up low ilvl blues. Can you change it to pick up every blue no matter the ilvl, then salvage them? All blues salvage into essences so they are worth picking up no mater the ilvl.

Why would you want hell-level craft materials? I'm not going to provide a loot rule for every single possible circumstance - I imagine it's very rare that a player looking for a plugin to filter out only valuable loot, also wants to salvage low-level items that give hell-materials (which I think are entirely worthless?). I've provided loot rules down to the lowest-requirements to get inferno craft materials (61+ blues with 59+ blue jewelry).

If you want to edit this further to get hell craft materials (and I don't know why you would want to do this if you're keen to use a plugin dedicated to only getting you high-value items), you will have to edit the loot rules to pickup any level item, and edit the salvage rules to salvage any level item. Open Notepad (every Windows has this), or any other text editor you like (Notepad ++ etc.). Drag the loot rules .xml file into the Notepad window. You'll soon discover how easy they are to edit, and have the satisfaction of putting in a little work and teaching yourself a new skill to get completely custom results

 

[kaime]

tested and I got stuck on the path from vendor to salvaging npc in town, on the fence precisely.

 

[protossop]

Why would you want hell-level craft materials? I'm not going to provide a loot rule for every single possible circumstance - I imagine it's very rare that a player looking for a plugin to filter out only valuable loot, also wants to salvage low-level items that give hell-materials (which I think are entirely worthless?). I've provided loot rules down to the lowest-requirements to get inferno craft materials (61+ blues with 59+ blue jewelry).

If you want to edit this further to get hell craft materials (and I don't know why you would want to do this if you're keen to use a plugin dedicated to only getting you high-value items), you will have to edit the loot rules to pickup any level item, and edit the salvage rules to salvage any level item. Open Notepad (every Windows has this), or any other text editor you like (Notepad ++ etc.). Drag the loot rules .xml file into the Notepad window. You'll soon discover how easy they are to edit, and have the satisfaction of putting in a little work and teaching yourself a new skill to get completely custom results

Oops, I thought all blues you get from inferno salvages into exquisite essences. Nvm then!

 

[GilesSmith]

tested and I got stuck on the path from vendor to salvaging npc in town, on the fence precisely.

This is a bug in DemonBuddy .176, not with this plugin. Try reverting to DemonBuddy .173 or earlier. Sucks

Oops, I thought all blues you get from inferno salvages into exquisite essences. Nvm then!

Ahh, that'd explain the confusion Yup you only get inferno-grade crafting materials from ilvl 59+ jewelry and ilvl 61+ everything else! So anything not included in the loot rules I've attached to the 1st post, is nothing worth having anyway!

 

[DeViOuS]

People who can't open notepad and figure out how to make a simple change to some loot rules should just go home. Don't kill yourself catering to everyone giles.
Just like to say I really appreciate you sharing this with us and great work on the plugins! DB would be useless to alot of us if not for people like you.

 

[delifresh]

Any chance of having it salvaging 1 item at a time instead off all at once for us paranoid people?

 

[20kilo]

There is anyway i can with your pluguin in another language client? (i will do the lootrule file myself) i just wonder about the plugin itself
Thanks in advance

 

[GilesSmith]

Any chance of having it salvaging 1 item at a time instead off all at once for us paranoid people?

Salvaging is down to DemonBuddy, and you can see me replying to the same question at the bottom of post #100 here

There is anyway i can with your pluguin in another language client? (i will do the lootrule file myself) i just wonder about the plugin itself
Thanks in advance

Have you tried using the plugin with another language client? I can't see why it wouldn't work, but you'll have to try it and let us know