[WIP] Singular - A community driven All-In-One CC - It Just Plain Works

[moachi]

I just dont understand one thing, when it's moving after some guy, because of CreateMoveToAndFace().. WoW shows that it can hit with melee strikes.. but it doesn't hit, because each time it reissue new move command to follow the target.. so, need somehow issue follow command and fire some melee strikes.. or, maybe, I don't understand something ?

P.S. another thing about targeting.. it tries to kill same target even if it's already far away... and better choose one from guys hitting in melee

 

[Impala]

Sometimes when running AB on a Disc Priest, the priest will have a difficult time targeting a monster

 

[Lockwood]

I'm thinking pvp warlock demo here.

Changes:

*Metamorph (I've added Metamorp as standard into the routine, no longer just if the target is elite).
*I've added Axe Toss as a pull opener. This makes sure if you get rogue ganked that it limits damage. Also buys you more time to dot them up and get guardians summoned and hand of guldan down.
*I've then followed it with Felstorm
*Moved Hand of Guldan up the list. This should buy you more time.
*Expanded the range of the Infernal from 10-20 (to take into account the greater range between targets in pvp)
*Added Soulburn before Drain Life (to make it instant)

I've also made changes to the resting (it was 55,now it's 50 for Soul Harvest) also placed in a wait to make sure it fully waits before moving on (was often doing it was a second then moving and cancelling the cast).



Could someone advise what the command would be to drain soul target below 25% health? 9Helps with the Glyph to get Mana back and give Sould Shards I've tried the following:

CreateSpellCast("Drain Soul", ret => Me.ManaPercent < 50 && Me.CurrentTarget > 25), Is that right?

Have a look please guys and see if I've made mistakes. I hope this helps:

I'm still working on some Melee Range CC mechanics for using fear and Death Coil (Would love some helps on this)

CreateSpellBuffOnSelf("Metamorphosis"),
CreateCastPetAction("Axe Toss")
CreateSpellCast("Hand of Gul'dan"),
CreateCastPetAction("Felstorm")
CreateSpellBuff("Immolate", true),
CreateSpellBuff("Curse of Tongues", ret => Me.CurrentTarget.PowerType == WoWPowerType.Mana),
CreateSpellBuff("Curse of Weakness", ret => Me.CurrentTarget.PowerType != WoWPowerType.Mana),
CreateSpellBuff("Bane of Doom", ret => CurrentTargetIsEliteOrBoss),

CreateSpellBuff("Bane of Agony", ret => !Me.CurrentTarget.HasAura("Bane of Doom") && (Me.CurrentTarget.HealthPercent >= 20 || CurrentTargetIsEliteOrBoss)),
// Use the infernal if we have a few mobs around us, and it's off CD. Otherwise, just use the Doomguard.
// Its a 10min CD, with a 1-1.2min uptime on the minion. Hey, any extra DPS is fine in my book!
// Make sure these 2 summons are AFTER the banes above.
new Decorator(
ret => NearbyUnfriendlyUnits.Count(u => u.Distance <= 20) > 2,
CreateSpellCastOnLocation("Summon Infernal", ret => Me.CurrentTarget.Location)
),
CreateSpellCast("Summon Doomguard"),
CreateSpellBuff("Corruption",ret => Me.CurrentTarget.HealthPercent >= 30 || CurrentTargetIsElite),
CreateSpellBuffOnSelf("Soulburn", ret => Me.HealthPercent < 70),
CreateSpellCast("Drain Life", ret => Me.HealthPercent < 70 && Me.HasAura("Soulburn")),
CreateSpellCast("Health Funnel", ret => Me.GotAlivePet && Me.Pet.HealthPercent < 70),
// TODO: Make this cast Soulburn if it's available
CreateSpellCast("Soul Fire", ret => Me.HasAura("Improved Soul Fire") || Me.HasAura("Soulburn")),
CreateSpellCast("Soul Fire", ret => Me.HasAura("Decimation")),
CreateSpellCast("Incinerate", ret => Me.HasAura("Molten Core")),
CreateSpellCast("Shadow Bolt"),
CreateSpellCast("Drain Soul", ret => Me.ManaPercent < 50 && Me.CurrentTarget > 25)
);
}
}
}

and for the common Added a wait after create healthstone (was starting to cast, then running and cancelling and then repeating and never quite cancelling). Again please advise if it is wrong:

[Class(WoWClass.Warlock)]
[Spec(TalentSpec.AfflictionWarlock)]
[Spec(TalentSpec.DemonologyWarlock)]
[Spec(TalentSpec.DestructionWarlock)]
[Spec(TalentSpec.Lowbie)]
[Behavior(BehaviorType.PreCombatBuffs)]
[Context(WoWContext.All)]
public Composite CreateWarlockPreCombatBuffs()
{
return new PrioritySelector(
CreateWaitForCast(),
CreateSpellBuffOnSelf("Create Healthstone", ret => NeedToCreateHealthStone),
CreateWaitForCast(),

[Class(WoWClass.Warlock)]
[Spec(TalentSpec.AfflictionWarlock)]
[Spec(TalentSpec.DemonologyWarlock)]
[Spec(TalentSpec.DestructionWarlock)]
[Spec(TalentSpec.Lowbie)]
[Behavior(BehaviorType.Rest)]
[Context(WoWContext.All)]
public Composite CreateWarlockRest()
{
return new PrioritySelector(
new Decorator(
ctx => Me.CastingSpell != null && Me.CastingSpell.Name == "Summon " + WantedPet && Me.GotAlivePet,
new Action(ctx => SpellManager.StopCasting())),
CreateWaitForCast(),
CreateSpellBuffOnSelf("Life Tap", ret => Me.ManaPercent < 80 && Me.HealthPercent > 60),
CreateSpellBuffOnSelf("Soul Harvest", ret => Me.CurrentSoulShards < 3 || Me.HealthPercent <= 50),
CreateWaitForCast(),
CreateDefaultRestComposite(40, 0)

 

[Lockwood]

Warlock Demo Changes

Full Details are Posted Above.

Please check and Update the Warlock CC (Not sure how to add a PVP option but this is the start of an advanced PVP build based on the original singular routine)

Will be adding Fear and Death Coil Logic soon I hope!

Not sure how to create my own CC to be able to test it, in regards to what I need to copy over to a new folder to fully road test the edited version (modifying the files means you can't load it as a CC)

If someone could explain would be much appreciated. Would love to continue contributing as I'm starting to level a fair few classes.

 

[kayes]

Uff finally, more or less PvP thing.. with enjoy was watching how my pala killed war 1vs1 on bg If anybody need retry for bgs PvP... I made it for my draenei girl, assuming pvp trink in slot 1.. so, for other races probably it would require some tuning.. or maybe not

P.S. was created against 190rev, though as base used some 138rev file which I got with buddy

Ill test it out on 3 x lvl 85 pallies fullly pvp equiped and a lvl 80 pally

 

[Xanathos]

Updated to the latest build and every time I get off my mount (as a Warlock) it is detecting the pet as "new" and is rebuilding the pet spells.

Well that's when it doesn't try to force cast the pet even though it's still there (same dismount pet bug).

 

[Smarter]

Smarter's Demo Warlock

I have re-worked the Common and Demonology portion of the Warlock, as well as made a Minor modification to PetManager. These modification to the Warlock are modeled after ElitistJerks most recent calculations of Demonology Warlock (Demonology in Cataclysm | The Demon Within (4.0.6 Updated) - Elitist Jerks).

Modifications Include:

• Re-Work of Demonology
• Dismount Before Combat (Solves Staring Issue)
• Increase of Pet Check Timer (Helps with Double Summoning)
• Addition of Healthstones to Common
• Added Continual usage of Metamorphosis
• Addition of Infernal Summoning
• Added continual usage of Felguard Abilities
• Removed PetAction Logging (As continual usage will spam that it's casting the PetAction, whether it's on cooldown or not)

I have been extensively testing these modifications in both PVE(Grinding) and with InstanceBuddy, and have found it to be the best class out there for Demo Warlocks.

Patch: View attachment Smarter's Patch.zip

 

[Lockwood]

Could some1 explain how i update my altered Warlock CC to be able to use it. This SVN stuff is new to me?

Got a red ! in the corner and won't load in HB.

Also Forum doesn't want to let me upload my patch file.

 

[Mortal]

More Fury love:

- Fixed double pull issues. (Intercepting while in the air for Heroic Leap, Heroic Throw while intercepting or Leaping)
- Fixed not pulling due to being to ~7.5 yards away spamming Intercept.
- Removed Battle Stance / Charge. (Was better than most cc's at stance dancing, but still to slow for my standards. Wasted rage and slowed starts on mobs/players.)
- Separated the Combat Buff Section into PvP, Battlegrounds, and Normal. (Will now blow cooldowns when getting ganked, Blow cooldowns as soon as its up in BG's, and use a more refined cooldown usage in Instances)
- Commented everything. (Well almost everything)
- Made Pull/Combat/CombatBuff sections easier to read.
- Added Rocketboot support for PvP.
- Added Darkflight support for PvP.
- Increased both Victory Rush's and Heroic Strike's priority. (Better rage dump, better PvE grinding)

Is there any way Apoc or Raphus could make a Composite to remove a buff? I'd like to be able to click off Inner Rage once I've dumped enough rage. So something like CreateRemoveBuff("Inner Rage", ret => Me.RagePercent < 40). Thanks.

Let me know what you think.

good work john310, been gone the last 2 weeks or so(hints why no posts...but will test it out and maybe start working on other improvments (for other classes) since Fury warrior is pretty well done

 

[Jon310]

good work john310, been gone the last 2 weeks or so(hints why no posts...but will test it out and maybe start working on other improvments (for other classes) since Fury warrior is pretty well done

Yea, seems like we put ourselves out of work on the fury warrior cc. I tried making a Shaman Resto cc, got one fully functional, but it was too slow at picking up targets that needed heals, and I also had issues with setting up working heal priorities. Seemed like it would only use the top 3 heals on the priorities list and everything else never got used. I could probably fix that last bit with some time, but with ShamWoW being as awesome as it is, its useless to release something that is so inferior.

 

[Lockwood]

Could someone please advise how I can play test my edited CC?

HB won't load it. Does it have to be committed to the SVN first to use it?

If not how can I get HB to load and use it?

Could someone please tell how I can get this working? Trying to develop a PVP demo warlock build from the base one for the Singular class!

 

[Jon310]

Could someone please advise how I can play test my edited CC?

HB won't load it. Does it have to be committed to the SVN first to use it?

If not how can I get HB to load and use it?

Could someone please tell how I can get this working? Trying to develop a PVP demo warlock build from the base one for the Singular class!

It doesn't have to be committed to the SVN first. Are you getting any error's showing in HB? Any time I made a mistake HB was really adamant about telling me what I did wrong and on what line.

If HB isn't loading the profile after you have edited it, something should spit out when you try and start HB up. Thats where your issue is.

 

[moachi]

Dunno in which thread to ask.. but I'll ask here cos working with Singular.. can somebody explain me how this priority selector works.. if Bot finds first action which satisfy the condition within priorityselector's array, it runs it and sleeps(until next pulse or smthing.. dunno how often it fires), or it tries to run others actions which are eligible as well?

 

[Lockwood]

It doesn't have to be committed to the SVN first. Are you getting any error's showing in HB? Any time I made a mistake HB was really adamant about telling me what I did wrong and on what line.

If HB isn't loading the profile after you have edited it, something should spit out when you try and start HB up. Thats where your issue is.

No idea what the issue is then mate. New to this, tbh.

I'll Have a go and if necessary post what HB says. I could use a hand with this as I have checked and no clue what is the issue here. All it was was a case of a few new things and swap arounds.

EDIT: Fixed it. Reuploaded Files in previous posts. Copy Paste them into your CC for PVP build.

 

[Mihawk]

Rogue Pull Rotation is shit.
You're saying Combat is supported and he tries to pull with Ambush (Daggers req. - as a Combatrogue you don't use daggers)

 

[Lockwood]

I have re-worked the Common and Demonology portion of the Warlock, as well as made a Minor modification to PetManager. These modification to the Warlock are modeled after ElitistJerks most recent calculations of Demonology Warlock (Demonology in Cataclysm | The Demon Within (4.0.6 Updated) - Elitist Jerks).

Modifications Include:

• Re-Work of Demonology
• Dismount Before Combat (Solves Staring Issue)
• Increase of Pet Check Timer (Helps with Double Summoning)
• Addition of Healthstones to Common
• Added Continual usage of Metamorphosis
• Addition of Infernal Summoning
• Added continual usage of Felguard Abilities
• Removed PetAction Logging (As continual usage will spam that it's casting the PetAction, whether it's on cooldown or not)

I have been extensively testing these modifications in both PVE(Grinding) and with InstanceBuddy, and have found it to be the best class out there for Demo Warlocks.

Patch: View attachment 19628

Doesn't Work for Pet Actions. HB Doesn't Compile:

File: Demonology.cs Line: 51 Error: The name 'PetAction' does not exist in the current context
File: Demonology.cs Line: 52 Error: The name 'PetAction' does not exist in the current context

 

[Mihawk]

If some1 teaches me how Honorbuddy handles area effects (in my case Distract), i will contribute a finished Combat.cs for this project. Everythind else is working like a charm.

 

[strix]

Rogue Pull Rotation is shit.
You're saying Combat is supported and he tries to pull with Ambush (Daggers req. - as a Combatrogue you don't use daggers)

Ambush does not require dagger since few months.

Search my post and get new version, combat is like 95% finished.
Except for some changes by raphus previous was mine too

 

[Smarter]

Doesn't Work for Pet Actions. HB Doesn't Compile:

File: Demonology.cs Line: 51 Error: The name 'PetAction' does not exist in the current context
File: Demonology.cs Line: 52 Error: The name 'PetAction' does not exist in the current context

Yes it does, but it wasn't modified for the latest Revision (191?), it was modified on revision 178 or something. I've updated to the latest Revision, and am updating it from there.

 

[Lockwood]

Yes it does, but it wasn't modified for the latest Revision (191?), it was modified on revision 178 or something. I've updated to the latest Revision, and am updating it from there.

So It doesn't work at present then. Just wanted to check if it was something I was doing wrong.

I'm just in the process of having a look into the same sort of thing (Felguard Actions) but with a view to a PVP build for Demo. I've be interested to find out the coding for the pet actions (and vise versa if I find out something that works first).

I'm thinking of combining the builds to make a PVE/PVP Demo Lock Build with your mods for the PVE and a slightly different priority and behaviour for the PVP.

Once I've got that stable, working and tested once my Lock gets to 85 (and if any1 else wants to help out they are more than welcome) I'll have a look at a PVP version for affliction incorporating some of the same new Fear/Death Coil logic and perhaps Felhunter/Scubbus support (Destro is nice but LazyLock seems to be the one for all you old school Destro Locks).